Re: [Gen-art] review of draft-ietf-dhc-dhcpv6-active-leasequery-03.txt
Jari Arkko <jari.arkko@piuha.net> Wed, 08 July 2015 21:59 UTC
Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 157F91A888B for <gen-art@ietfa.amsl.com>; Wed, 8 Jul 2015 14:59:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ezr8mhIQ-HAj for <gen-art@ietfa.amsl.com>; Wed, 8 Jul 2015 14:59:13 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [193.234.218.130]) by ietfa.amsl.com (Postfix) with ESMTP id 061D61A00E9 for <gen-art@ietf.org>; Wed, 8 Jul 2015 14:59:13 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 56AB92D013; Thu, 9 Jul 2015 00:59:12 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y0mXe2naDmSe; Thu, 9 Jul 2015 00:59:10 +0300 (EEST)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id C67842D00D; Thu, 9 Jul 2015 00:59:10 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_5A46DEE0-1FB9-4D2B-94E4-694C2554DECD"; protocol="application/pgp-signature"; micalg="pgp-sha512"
X-Pgp-Agent: GPGMail 2.5
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <201507061346.t66DkLaY070724@givry.fdupont.fr>
Date: Wed, 08 Jul 2015 23:59:09 +0200
Message-Id: <6BFA7707-36EC-4D73-8EF8-9E7194327C70@piuha.net>
References: <201507061346.t66DkLaY070724@givry.fdupont.fr>
To: Francis Dupont <Francis.Dupont@fdupont.fr>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/DNz5FHftGaM3RSbleIyyLHHBDjA>
Cc: gen-art@ietf.org, draft-ietf-dhc-dhcpv6-active-leasequery.all@tools.ietf.org
Subject: Re: [Gen-art] review of draft-ietf-dhc-dhcpv6-active-leasequery-03.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2015 21:59:15 -0000
Thanks for the review. Authors, shepherd/AD, do you have any comments on Francis’ TLS issue below? Jari On 06 Jul 2015, at 15:46, Francis Dupont <Francis.Dupont@fdupont.fr> wrote: > I am the assigned Gen-ART reviewer for this draft. For background on > Gen-ART, please see the FAQ at > > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. > > Please resolve these comments along with any other Last Call comments > you may receive. > > Document: draft-ietf-dhc-dhcpv6-active-leasequery-03.txt > Reviewer: Francis Dupont > Review Date: 20150701 > IETF LC End Date: 20150629 > IESG Telechat date: 20150709 > > Summary: Almost Ready > > Major issues: None > > Minor issues: the TLS part is a bit underspecified (nothing critical > as the missing text should get a quick and easy consensus) > > Nits/editorial comments: > - ToC page 2 and 12 page 27: Acknowledgements -> Acknowledgments > (you chose US spelling by using behavior :-) > > - 6.1 page 8: you assume TLS offers the same transport facility than TCP. > In fact it is not true: TCP is a pure octet stream when TLS is a > sequenced packet. This has an impact in the framing: you have to say > something about the message framing for TLS. I strongly suggest to say: > 1- the message framing for TLS uses the same format than for TCP > (so RFC 5460 5.1). > 2- one DHCP message SHOULD be carried in one TLS record. > IMHO it is easy, simple and works well with tunneling. > > - 6.2.1 page 8: MUST BE -> MUST be > > - 6.2.2 page 9: it is one of the places you should give more details > about STARTTLS. I suggest to add the STARTTLS message SHOULD be sent > without any option, and any valid option in received STARTTLS messages > should be ignored (I put the word valid to catch the bad server ID > case which BTW seems to be one of the few possible errors). > > - 6.3.1 page 9, 8.4 page 16, 8.6.1 page 20: i.e. -> i.e., > > - 8.2 page 13: requestor should proceed -> requestor SHOULD proceed ? > > - 8.2 page 14 (3 times): drop -> close > > - 8.2 page 14: verify -> validate > (my concern about verify is this term is more about the signature, > so I recommend to use RFC 5280 term, i.e., validate). > > - 8.2 page 14 and 8.3 page 14: Active Leasequery -> ACTIVELEASEQUERY ? > > - 8.4 page 17: server should close -> server SHOULD close > > - 8.4.1 page 17: may run -> MAY run or can run or... > (i.e., please avoid lower case keywords) > > - 8.4.1 page 17: can't parse: "If this should occur," > > - 8.4.1 (very end of) page 18: there may be -> there can be > > - 8.4.1 page 19: This Bulk Leasequery request should include -> SHOULD > > - 8.5 page 20: first sentence, twice: may -> can > > - 10 page 26: there is a new security mechanism proposed for DHCPv6, > secure DHCPv6. As it is clearly designed for UDP transport I don't > believe it interferes with the document so IMHO you can safely ignore it. > > - Authors' Addresses page 28: according to ITU TS E.123 international > phone numbers have no optional prefixes so there should be nothing > included in (), for instance: > +91 (080) 4365-7476 -> +91 080 4365-7476 > > Regards > > Francis.Dupont@fdupont.fr > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] review of draft-ietf-dhc-dhcpv6-active-… Francis Dupont
- Re: [Gen-art] review of draft-ietf-dhc-dhcpv6-act… Jari Arkko
- Re: [Gen-art] review of draft-ietf-dhc-dhcpv6-act… Dushyant Raghuvanshi (draghuva)
- Re: [Gen-art] review of draft-ietf-dhc-dhcpv6-act… Kim Kinnear
- Re: [Gen-art] review of draft-ietf-dhc-dhcpv6-act… Brian Haberman