Re: [Gen-art] review of draft-ietf-dhc-dhcpv6-active-leasequery-03.txt

"Dushyant Raghuvanshi (draghuva)" <draghuva@cisco.com> Thu, 09 July 2015 06:09 UTC

Return-Path: <draghuva@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4ADCD1A911D for <gen-art@ietfa.amsl.com>; Wed, 8 Jul 2015 23:09:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id axSO4FaItJeG for <gen-art@ietfa.amsl.com>; Wed, 8 Jul 2015 23:08:59 -0700 (PDT)
Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 415FA1A9118 for <gen-art@ietf.org>; Wed, 8 Jul 2015 23:08:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5132; q=dns/txt; s=iport; t=1436422139; x=1437631739; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=WU8niEqQNO/EUT5FSuJIAC+3802HPDnzKC09qZu9uxY=; b=DDQj/uJ6tx3GTLVSPxj3GW/4uim2nvaOkmgcXQt7nb8W7ubQ6mEOg2Up v+7yVQDdxT6Q/c+dKYfGmaAkmzYNjdmM3vz4URcF5nOHCibHVrqMy2gpX VJ1BU0GsLY5w33tI+4eji4GVsMRK6vJoWyahgO4sZKUnN9+OYD8uFpMch I=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0D6BQChD55V/5JdJa1bgxJUYAEFgxq4BoFwhXcCHIE7ORMBAQEBAQEBgQqEJAEBBCMEDTMSEAIBCBAEBgImAgICMBUQAgQOBYguDbcvljIBAQEBAQEBAQEBAQEBAQEBAQEBAQEXgSGKKoQ7IBAbBwSCZIFDBZQsAYRmhxmBPEWDU48yg18mg3tvAYEFJRyBBAEBAQ
X-IronPort-AV: E=Sophos;i="5.15,437,1432598400"; d="scan'208";a="166823087"
Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by alln-iport-7.cisco.com with ESMTP; 09 Jul 2015 06:08:37 +0000
Received: from xhc-rcd-x02.cisco.com (xhc-rcd-x02.cisco.com [173.37.183.76]) by rcdn-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id t6968bX5025089 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 9 Jul 2015 06:08:37 GMT
Received: from xmb-rcd-x02.cisco.com ([169.254.4.18]) by xhc-rcd-x02.cisco.com ([173.37.183.76]) with mapi id 14.03.0195.001; Thu, 9 Jul 2015 01:08:37 -0500
From: "Dushyant Raghuvanshi (draghuva)" <draghuva@cisco.com>
To: Francis Dupont <Francis.Dupont@fdupont.fr>
Thread-Topic: review of draft-ietf-dhc-dhcpv6-active-leasequery-03.txt
Thread-Index: AQHQt/JWvhy7G0/jD0qeRIrw8NyQU53TW4OA
Date: Thu, 09 Jul 2015 06:08:37 +0000
Message-ID: <D1C40BB7.46F91%draghuva@cisco.com>
References: <201507061346.t66DkLaY070724@givry.fdupont.fr>
In-Reply-To: <201507061346.t66DkLaY070724@givry.fdupont.fr>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [173.39.67.95]
Content-Type: text/plain; charset="utf-8"
Content-ID: <3AC2446CC32F224695CA74666FC61D26@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/m7NrcvjEihFf8XeZng8FI3cTbus>
Cc: "draft-ietf-dhc-dhcpv6-active-leasequery.all@tools.ietf.org" <draft-ietf-dhc-dhcpv6-active-leasequery.all@tools.ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>
Subject: Re: [Gen-art] review of draft-ietf-dhc-dhcpv6-active-leasequery-03.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2015 06:09:01 -0000

Hi Francis,

Thanks for your comments. I shall fix all below issues in next version of
the draft.
Although I have comments for couple of issues below.
Please check inline.

Thanks,
Dushyant.


On 06/07/15 19:16, "Francis Dupont" <Francis.Dupont@fdupont.fr> wrote:

>I am the assigned Gen-ART reviewer for this draft. For background on
>Gen-ART, please see the FAQ at
>
><http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>
>Please resolve these comments along with any other Last Call comments
>you may receive.
>
>Document: draft-ietf-dhc-dhcpv6-active-leasequery-03.txt
>Reviewer: Francis Dupont
>Review Date: 20150701
>IETF LC End Date: 20150629
>IESG Telechat date: 20150709
>
>Summary: Almost Ready
>
>Major issues: None
>
>Minor issues: the TLS part is a bit underspecified (nothing critical
> as the missing text should get a quick and easy consensus)
>
>Nits/editorial comments:
> - ToC page 2 and 12 page 27: Acknowledgements -> Acknowledgments
>  (you chose US spelling by using behavior :-)
>
> - 6.1 page 8: you assume TLS offers the same transport facility than TCP.
>  In fact it is not true: TCP is a pure octet stream when TLS is a
>  sequenced packet. This has an impact in the framing: you have to say
>  something about the message framing for TLS. I strongly suggest to say:
>  1- the message framing for TLS uses the same format than for TCP
>   (so RFC 5460 5.1).
>  2- one DHCP message SHOULD be carried in one TLS record.
>   IMHO it is easy, simple and works well with tunneling.
>
> - 6.2.1 page 8: MUST BE -> MUST be
>
> - 6.2.2 page 9: it is one of the places you should give more details
>  about STARTTLS. I suggest to add the STARTTLS message SHOULD be sent
>  without any option, and any valid option in received STARTTLS messages
>  should be ignored (I put the word valid to catch the bad server ID
>  case which BTW seems to be one of the few possible errors).

[Dushyant]: I understand that currently we don’t have any option to be
sent in STARTTLS message. But it could be a case that we reuse this message
for some other feature (in future) and there we may send some option in
the same.

So should we ignore that possibility and say that "STARTTLS message SHOULD
be sent
without any option”?

>
> - 6.3.1 page 9, 8.4 page 16, 8.6.1 page 20: i.e. -> i.e.,
>
> - 8.2 page 13: requestor should proceed -> requestor SHOULD proceed ?
>
> - 8.2 page 14 (3 times): drop -> close
>
> - 8.2 page 14: verify -> validate
>  (my concern about verify is this term is more about the signature,
>   so I recommend to use RFC 5280 term, i.e., validate).
>
> - 8.2 page 14 and 8.3 page 14: Active Leasequery -> ACTIVELEASEQUERY ?
>
> - 8.4 page 17: server should close -> server SHOULD close
>
> - 8.4.1 page 17: may run -> MAY run or can run or...
>  (i.e., please avoid lower case keywords)
>
> - 8.4.1 page 17: can't parse: "If this should occur,"
>
> - 8.4.1 (very end of) page 18: there may be -> there can be
>
> - 8.4.1 page 19: This Bulk Leasequery request should include -> SHOULD
>
> - 8.5 page 20: first sentence, twice: may -> can
>
> - 10 page 26: there is a new security mechanism proposed for DHCPv6,
>  secure DHCPv6. As it is clearly designed for UDP transport I don't
>  believe it interferes with the document so IMHO you can safely ignore
>it.

[Dushyant]: Secure DHCPv6 isn’t a standard yet. Can we use that as
reference?

>
> - Authors' Addresses page 28: according to ITU TS E.123 international
>  phone numbers have no optional prefixes so there should be nothing
>  included in (), for instance:
>  +91 (080) 4365-7476 -> +91 080 4365-7476
>
>Regards
>
>Francis.Dupont@fdupont.fr