Re: [Gen-art] Gen-ART review of draft-ietf-avtext-client-to-mixer-audio-level-05.txt

Emil Ivov <emcho@jitsi.org> Tue, 27 September 2011 04:15 UTC

Return-Path: <emcho@sip-communicator.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D5E055E8007; Mon, 26 Sep 2011 21:15:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.735
X-Spam-Level:
X-Spam-Status: No, score=-2.735 tagged_above=-999 required=5 tests=[AWL=-0.533, BAYES_00=-2.599, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=1.396, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mMSKpkS7ecoC; Mon, 26 Sep 2011 21:15:46 -0700 (PDT)
Received: from mail-wy0-f172.google.com (mail-wy0-f172.google.com [74.125.82.172]) by ietfa.amsl.com (Postfix) with ESMTP id A0E955E8002; Mon, 26 Sep 2011 21:15:45 -0700 (PDT)
Received: by wyh21 with SMTP id 21so5048698wyh.31 for <multiple recipients>; Mon, 26 Sep 2011 21:18:29 -0700 (PDT)
Received: by 10.227.60.193 with SMTP id q1mr2857763wbh.108.1317097109120; Mon, 26 Sep 2011 21:18:29 -0700 (PDT)
Received: from [192.168.0.3] (shm67-5-88-165-90-188.fbx.proxad.net. [88.165.90.188]) by mx.google.com with ESMTPS id y10sm34066255wbm.14.2011.09.26.21.18.26 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 26 Sep 2011 21:18:27 -0700 (PDT)
References: <4E7FA0BE.1050201@isode.com> <C3759687E4991243A1A0BD44EAC823034C42868FB9@BE235.mail.lan> <4E80FBB8.4070205@isode.com>
In-Reply-To: <4E80FBB8.4070205@isode.com>
Mime-Version: 1.0 (iPad Mail 8L1)
Content-Transfer-Encoding: 7bit
Content-Type: multipart/alternative; boundary="Apple-Mail-1--512376392"
Message-Id: <8F86CBA7-7B72-416F-98AF-ED61123AED94@jitsi.org>
X-Mailer: iPad Mail (8L1)
From: Emil Ivov <emcho@jitsi.org>
Date: Tue, 27 Sep 2011 06:20:37 +0200
To: Alexey Melnikov <alexey.melnikov@isode.com>
X-Mailman-Approved-At: Tue, 27 Sep 2011 05:37:13 -0700
Cc: Jonathan Lennox <jonathan@vidyo.com>, GeneralArea Review Team <gen-art@ietf.org>, "draft-ietf-avtext-client-to-mixer-audio-level.all@tools.ietf.org" <draft-ietf-avtext-client-to-mixer-audio-level.all@tools.ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-avtext-client-to-mixer-audio-level-05.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Sep 2011 04:15:47 -0000

Hey Alexey,

On 27 sept. 2011, at 00:24, Alexey Melnikov <alexey.melnikov@isode.com> wrote:

> Jonathan Lennox wrote:
> 
>> Hi, Alexey -- thank you for the Gen-ART review.
>> 
> Hi Jonathan,
> 
>> Alexey Melnikov writes:
>> 
>>> Question: are the two encoding of the audio level indication option specified in the document really necessary?
>>>   
>> 
>> Do you mean the one-byte vs. two-byte forms of the header extension (Figure 1 vs. Figure 2)?  These are the two forms of the generic header extensions defined by RFC 5285.
>> 
> I understood that. Does RFC 5285 require that both forms should be allowed?

It doesn't explicitly say so but it It actually does, yes. Here's what it says:

   A stream MUST contain only one-byte or two-byte
   headers: they MUST NOT be mixed within a stream.

Audio level headers can find themselves in streams that also have other, longer extensions, which do require the two-byte header. The above lines mandate that in such cases they all use the two-byte header.

In the same regard, although probably a bit less likely, nothing prevents having another sixteen header extensions in a stream that also has levels. In that case we'd need to switch to two-byte headers in order to be able to fit all the IDs.

Cheers,
Emil

--sent from my mobile

> In general, it would be good to avoid multiple representations of the same thing.
> 
>> The actual payload (one byte containing the V and level bits) is identical in the two cases; the only difference is the container.  We can add some text clarifying this point if you think it would be helpful.
>> 
>>> Nits/editorial comments:
>>> s/relys/relies ???
>>>   
>> Thanks, will fix.
>> 
>