Re: [Gen-art] Gen-ART review of draft-ietf-avtext-client-to-mixer-audio-level-05.txt

Alexey Melnikov <alexey.melnikov@isode.com> Tue, 27 September 2011 09:17 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 04D9521F8C79; Tue, 27 Sep 2011 02:17:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.512
X-Spam-Level:
X-Spam-Status: No, score=-102.512 tagged_above=-999 required=5 tests=[AWL=0.087, BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pPrcj0lAZhS5; Tue, 27 Sep 2011 02:17:52 -0700 (PDT)
Received: from rufus.isode.com (rufus.isode.com [62.3.217.251]) by ietfa.amsl.com (Postfix) with ESMTP id C66D221F8C1B; Tue, 27 Sep 2011 02:17:51 -0700 (PDT)
Received: from [192.168.1.124] ((unknown) [62.3.217.253]) by rufus.isode.com (submission channel) via TCP with ESMTPA id <ToGVYgAvpSd=@rufus.isode.com>; Tue, 27 Sep 2011 10:20:34 +0100
X-SMTP-Protocol-Errors: NORDNS
Message-ID: <4E81955F.9070400@isode.com>
Date: Tue, 27 Sep 2011 10:20:31 +0100
From: Alexey Melnikov <alexey.melnikov@isode.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915
X-Accept-Language: en-us, en
To: Emil Ivov <emcho@jitsi.org>
References: <4E7FA0BE.1050201@isode.com> <C3759687E4991243A1A0BD44EAC823034C42868FB9@BE235.mail.lan> <4E80FBB8.4070205@isode.com> <8F86CBA7-7B72-416F-98AF-ED61123AED94@jitsi.org>
In-Reply-To: <8F86CBA7-7B72-416F-98AF-ED61123AED94@jitsi.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: Jonathan Lennox <jonathan@vidyo.com>, GeneralArea Review Team <gen-art@ietf.org>, "draft-ietf-avtext-client-to-mixer-audio-level.all@tools.ietf.org" <draft-ietf-avtext-client-to-mixer-audio-level.all@tools.ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-avtext-client-to-mixer-audio-level-05.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Sep 2011 09:17:53 -0000

Emil Ivov wrote:

> Hey Alexey,

Hi Emil,

> On 27 sept. 2011, at 00:24, Alexey Melnikov <alexey.melnikov@isode.com 
> <mailto:alexey.melnikov@isode.com>> wrote:
>
>> Jonathan Lennox wrote:
>>
>>> Hi, Alexey -- thank you for the Gen-ART review.
>>
>> Hi Jonathan,
>>
>>> Alexey Melnikov writes:
>>
>>>> Question: are the two encoding of the audio level indication option 
>>>> specified in the document really necessary?  
>>>
>>> Do you mean the one-byte vs. two-byte forms of the header extension 
>>> (Figure 1 vs. Figure 2)?  These are the two forms of the generic 
>>> header extensions defined by RFC 5285.
>>
>> I understood that. Does RFC 5285 require that both forms should be 
>> allowed?
>
> It doesn't explicitly say so but it It actually does, yes. Here's what 
> it says:
>
>   A stream MUST contain only one-byte or two-byte
>   headers: they MUST NOT be mixed within a stream.
>
>
> Audio level headers can find themselves in streams that also have 
> other, longer extensions, which do require the two-byte header. The 
> above lines mandate that in such cases they all use the two-byte header.

Ok, this is good enough for me. Thanks for explaining.

> In the same regard, although probably a bit less likely, nothing 
> prevents having another sixteen header extensions in a stream that 
> also has levels. In that case we'd need to switch to two-byte headers 
> in order to be able to fit all the IDs.
>
> Cheers,
> Emil
>
> --sent from my mobile
>
>> In general, it would be good to avoid multiple representations of the 
>> same thing.
>
>>
>>> The actual payload (one byte containing the V and level bits) is 
>>> identical in the two cases; the only difference is the container. 
>>>  We can add some text clarifying this point if you think it would be 
>>> helpful.
>>
>>>
>>>> Nits/editorial comments:
>>>
>>>> s/relys/relies ???
>>>
>>>>   
>>>
>>> Thanks, will fix.
>>