[Gen-art] Gen-ART review of draft-ietf-ccamp-gmpls-ethernet-pbb-te-05.txt

<david.black@emc.com> Thu, 26 August 2010 17:01 UTC

Return-Path: <david.black@emc.com>
X-Original-To: gen-art@core3.amsl.com
Delivered-To: gen-art@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id D5C003A6AEE; Thu, 26 Aug 2010 10:01:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -106.424
X-Spam-Level:
X-Spam-Status: No, score=-106.424 tagged_above=-999 required=5 tests=[AWL=0.175, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TjSaK6dF+KTb; Thu, 26 Aug 2010 10:01:13 -0700 (PDT)
Received: from mexforward.lss.emc.com (mexforward.lss.emc.com [128.222.32.20]) by core3.amsl.com (Postfix) with ESMTP id 71AB53A6AE4; Thu, 26 Aug 2010 10:01:13 -0700 (PDT)
Received: from hop04-l1d11-si01.isus.emc.com (HOP04-L1D11-SI01.isus.emc.com [10.254.111.54]) by mexforward.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id o7QH1NCP017983 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 26 Aug 2010 13:01:24 -0400
Received: from mailhub.lss.emc.com (mailhub.lss.emc.com [10.254.221.253]) by hop04-l1d11-si01.isus.emc.com (RSA Interceptor); Thu, 26 Aug 2010 13:01:19 -0400
Received: from corpussmtp4.corp.emc.com (corpussmtp4.corp.emc.com [10.254.169.197]) by mailhub.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id o7QH1I8T011709; Thu, 26 Aug 2010 13:01:18 -0400
Received: from CORPUSMX80B.corp.emc.com ([10.254.89.202]) by corpussmtp4.corp.emc.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 26 Aug 2010 13:01:17 -0400
x-mimeole: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Thu, 26 Aug 2010 13:01:16 -0400
Message-ID: <C2D311A6F086424F99E385949ECFEBCB03810D0F@CORPUSMX80B.corp.emc.com>
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Thread-Topic: Gen-ART review of draft-ietf-ccamp-gmpls-ethernet-pbb-te-05.txt
Thread-Index: ActFQEwoDqeODIKORP6xaxUmwryiTg==
From: david.black@emc.com
To: gen-art@ietf.org, donald.fedyk@alcatel-lucent.com, hshah@force10networks.com, nabil.n.bitar@verizon.com, attila.takacs@ericsson.com
X-OriginalArrivalTime: 26 Aug 2010 17:01:17.0865 (UTC) FILETIME=[4CC8E990:01CB4540]
X-EMM-MHVC: 1
X-EMM-MFVC: 1
Cc: daniel@olddog.co.uk, ccamp@ietf.org, adrian.farrel@huawei.com, lberger@labn.net, dbrungard@att.com
Subject: [Gen-art] Gen-ART review of draft-ietf-ccamp-gmpls-ethernet-pbb-te-05.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Aug 2010 17:01:14 -0000

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq . 

Please resolve these comments along with any other comments you may receive.

Summary:
This draft is on the right track, but has open issues, described in the review.

This draft describes the use of a GMPLS control plane to configure explicit forwarding in Ethernet bridges for PBB-TE (Provider Backbone Bridge Traffic Engineering).

In general, the draft is in good shape; the two open issues are in Section 5.1.2 and are minor:
- Is the "has to allocate a VID" statement in Section 5.1.2 correct when shared forwarding
	is in use as described in Section 3.1 ?
- The error value: MPLS Label allocation failure (9) appears to be inconsistent with the
	second bullet in Section 7 that requests IANA to allocate a new error value: "PBB-TE
	Ethernet Label VID allocation failure" (suggested value: 35?)  for this case.

Nits:

In Section 2, what are the I and B components of an IB-BEB?  Interface and Bridge?

In Figure 1, the VIP acronym is not in Section 2's list of acronyms.

In Section 4.1, remove the note to IANA after 2) and instead insert this instruction into Section 7.

In Figure 4, the type is TBA.  Add an instruction to Section 7 for IANA to fill this in after it is allocated.

In the fourth bullet in Section 7, please state that the registry is created by the MLN-EXT draft if that is the case.

idnits 2.12.04 ran clean.

Thanks,
--David
----------------------------------------------------
David L. Black, Distinguished Engineer
EMC Corporation, 176 South St., Hopkinton, MA  01748
+1 (508) 293-7953             FAX: +1 (508) 293-7786
david.black@emc.com        Mobile: +1 (978) 394-7754
----------------------------------------------------