IETF Logo Mail Archive

Re: [Gen-art] Genart last call review of draft-ietf-rtgwg-policy-model-15

Yingzhen Qu <yingzhen.qu@futurewei.com> Thu, 18 June 2020 23:17 UTC

Return-Path: <yingzhen.qu@futurewei.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4C9183A10C9; Thu, 18 Jun 2020 16:17:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.09
X-Spam-Level:
X-Spam-Status: No, score=-2.09 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=futurewei.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DL6O9VSkAhcJ; Thu, 18 Jun 2020 16:17:29 -0700 (PDT)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2111.outbound.protection.outlook.com [40.107.243.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D1DA3A10C7; Thu, 18 Jun 2020 16:17:29 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R+yg0QZ5BMJg94Iw5dnUmo6z6tEjNn1OS0gU+5HizY1JSRRAAv+PhelUKAbhRfbF49198AnbjccxkeRj53PuTFqIVjde9AGyRsVPBmqs4UT30etTfjxwYyTQHFcLhbpiIYiixEqlk21ai4OKep8OURTsxgJgc0zTF4Cie9uLEdGtcKRb/axyxpxNGQr9oxUNUAneXMCy+U9VLIVKodamCEZhDieKoQicPo+AY1loNJseC28J5dtXmylLur5ludH4JqxPd6TMaNFLQzHJCYoV66fPIgloDDnlh3o15BBaVN5CH3j4rAyzdYFtfjez3sGC2NqE1YELY1QBnnQWiBmmrg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=El1kDNSHqpNI1R4/PfnoMXb0vt4tDoofDX20qHe3ir0=; b=CKQB79NGKpaRWLoecrxttrlJnrI80BgYJxziK7oH4lgCeREjmixK06LM0G3UgN5PGYkLLsDAMS/IZ0Os1gpUIZXiGRFqB2noc5wLmGU6xJ64uqwQnbPNF3epL7hfw9gF0YAvNIS7d5EiNOk3aF8gbAarzJ3vLGTiPlHt0kFTAmAcsumLX7F3pI9Dh21usgCJmBvl6B1RHQZbPia33xmYm9A5Nni7Nqshi50HzZp5zwWQpNYm+j6EUsNDqWINj7ggQYorPh3ahHeGbcetSV2sVm8jvvIfO74D/zNUxhxiieuCK4azbieBLoGyW8B3FrmIy+EEPRCerc9wHxmHf561fw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=futurewei.com; dmarc=pass action=none header.from=futurewei.com; dkim=pass header.d=futurewei.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Futurewei.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=El1kDNSHqpNI1R4/PfnoMXb0vt4tDoofDX20qHe3ir0=; b=L4U5k5o3RoNMIDaFLVa5EFiP8xqw2vWf04ni4zC0KUFGg721LMkWer0jkAfrUgnmStmOlDTEKgAiOTfEN+o+YnkcnC0uwOu86cWCH9qsDl5vYk2hTt7cUsH9V+EXXBU5Z6pnSq1ciCYov0rbm32fz8hVOjeVt4SkTAg7xqRx2QI=
Received: from BY5PR13MB3048.namprd13.prod.outlook.com (2603:10b6:a03:188::21) by BY5PR13MB3046.namprd13.prod.outlook.com (2603:10b6:a03:184::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.12; Thu, 18 Jun 2020 23:17:27 +0000
Received: from BY5PR13MB3048.namprd13.prod.outlook.com ([fe80::28f0:8a33:3418:b39b]) by BY5PR13MB3048.namprd13.prod.outlook.com ([fe80::28f0:8a33:3418:b39b%4]) with mapi id 15.20.3088.028; Thu, 18 Jun 2020 23:17:26 +0000
From: Yingzhen Qu <yingzhen.qu@futurewei.com>
To: Francesca Palombini <francesca.palombini@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "draft-ietf-rtgwg-policy-model.all@ietf.org" <draft-ietf-rtgwg-policy-model.all@ietf.org>, "rtgwg@ietf.org" <rtgwg@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-rtgwg-policy-model-15
Thread-Index: AQHWRA/OfRJMDi/P50mkAX0BMkDRyKjej8iA
Date: Thu, 18 Jun 2020 23:17:26 +0000
Message-ID: <D5E5CE01-5ECB-4F8A-9452-1C2B8981018D@futurewei.com>
References: <159233371662.7879.15194255085695763961@ietfa.amsl.com>
In-Reply-To: <159233371662.7879.15194255085695763961@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1e.0.191013
authentication-results: ericsson.com; dkim=none (message not signed) header.d=none; ericsson.com; dmarc=none action=none header.from=futurewei.com;
x-originating-ip: [2601:646:9500:c900:4096:11db:85b5:aa75]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7a70322e-1e3e-4e6b-4d11-08d813ddc3bb
x-ms-traffictypediagnostic: BY5PR13MB3046:
x-microsoft-antispam-prvs: <BY5PR13MB30460BA36A27C071E31DC923E19B0@BY5PR13MB3046.namprd13.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0438F90F17
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: wU2UC/cjKpzbAQcEOjqEVE+dBQDG0Qqu6xPRz83viUqY7ryeDgvWhE6yhWFPe81ebSXNwRGnTIxbL+U0lBrvrnjxMthAHdI9vYIUbWl6G9CQyq/GnaWhtNUnn5Uo/L3KbQA8j/J0i7lPwxvMAH1CL5l015GoKylDhZQZQQq88dIGB8i4E8DSPAiXSa+z+cjwhXr24E3IttOco4dyy/BI2d8RKDeg1Givdy13XQGImeuSM0JCnIPphA2XjBnffdslW9qJpUkW9CL0O2gSk9zIPoycd2oCijVL51FKFT/FRYcoTxruAEBuX0JQDOLdYrJJ1v/xiN9LvhWjHuXRXcsBzCQ83WSqD83d2VlIRpeulFxCmeHMEwNY2IW6kuXLy9MbqPJQC8XNCcGjpwpSj3JkeA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR13MB3048.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39850400004)(346002)(376002)(366004)(136003)(71200400001)(2616005)(6512007)(6506007)(4326008)(83380400001)(6486002)(2906002)(316002)(8936002)(5660300002)(44832011)(8676002)(54906003)(86362001)(110136005)(478600001)(33656002)(66556008)(66946007)(64756008)(66446008)(66476007)(186003)(76116006)(36756003); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: en+wEeZ8IDWYukZXAhl2iu3kaQLuqPDk7x7DgAzq/f+eP+EgOGwNJmGt4Ny2TzAXOFaLkk1HQ4ucSEr5gjioDpXsiHPmVh6vc9oALJY5Du7uVN5qbjQe+iY7fQIW9NUKEpt2lKCOnxJbpkhqEbagPLCTqERxeCGT0VCWPXoLSvX6RF2+igLQnO6BdtoXSPQE5mQNkiyI2/vEEfOcYsrly2qDyAhlGxGJrBLaV/AE8ztqO3i/VBte99PQVi0RwzUJHHrtkYbLaQdcIPW+FgflF2ZEojNWvnlY65Uu/zz1xKk4Bmzc5ojnL0RXLLkRrYzeqTzj6Y9HB9W337u7doDi8Bh1nna+EgfhG0PHX1ECon7zKZjNDk7My2JeDKK7ATsF6VVzMmn4JrjKLHiSL4hoZuNmzC8gU9ra3uTQBLljS8DovrBJt7V78MEyouzfTXBONPYgzq1nYaaeMLgSJCpUvbWoOm7CYI6KW0dgM05misYXW2emtizSdW+62Dt2QL3geh2U37zF3sADd1zRKZnfhzJjoB0cFdZJiaU9AqAXIq69T7FkN6fqi61ChNUOKnNZ
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <88132DC166D89C419B7CC3A78AB1D041@namprd13.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Futurewei.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR13MB3048.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a70322e-1e3e-4e6b-4d11-08d813ddc3bb
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2020 23:17:26.4008 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YsrGK6BZDo56nb0lIhU5fcbunTxmmKlQc6opvGPd1cGjzIuNJGcvfgLj2hvOvT6aLTv5DLxNMfxl8I42yl2z7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3046
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/YVb7ADeKplgm3uZNRxzp4TdO1UU>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-rtgwg-policy-model-15
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2020 23:17:31 -0000

Hi Francesca,

Thanks for your review and comments. 

Please see my answers inline.

Thanks,
Yingzhen

On 6/16/20, 11:56 AM, "Francesca Palombini via Datatracker" <noreply@ietf.org> wrote:

    Reviewer: Francesca Palombini
    Review result: Ready with Issues
    
    I am the assigned Gen-ART reviewer for this draft. The General Area
    Review Team (Gen-ART) reviews all IETF documents being processed
    by the IESG for the IETF Chair.  Please treat these comments just
    like any other last call comments.
    
    For more information, please see the FAQ at
    
    <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftrac.ietf.org%2Ftrac%2Fgen%2Fwiki%2FGenArtfaq&amp;data=02%7C01%7Cyingzhen.qu%40futurewei.com%7Ca69d57e8e5b14f27e14208d81226efb2%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637279305729780422&amp;sdata=XNrSYJ7%2BI3RsLS%2Fx3GkhexO2cuiBagLRyYSDHpFfihs%3D&amp;reserved=0>.
    
    Document: draft-ietf-rtgwg-policy-model-15
    Reviewer: Francesca Palombini
    Review Date: 2020-06-16
    IETF LC End Date: None
    IESG Telechat date: Not scheduled for a telechat
    
    Summary: This draft is basically ready but has one minor issue, described in
    the review.
    
    Minor issues:
    
    In the last paragraph of Section 4 there are a number of non-normative may,
    should, must. I believe the last "should" at least could be normative:
    
    >  Also, implementations should have validation to assure
    >  that there is no recursion amongst nested routing policies.
[YQ]: I'm not sure this should be normative. These are suggestions. The model provides some flexibilities, and it's up to the users to decide how to use the model.
    
    (More of a question than an issue) I was surprised that all but one references
    were considered normative. Is that common to consider the RFC that appear in
    the model as normative references for the document?
[YQ]: This has been our practice. Is there a particular one you see that should not be normative?
    
    Note that for the version reviewed, the Yang Validation for
    draft-ietf-rtgwg-policy-model-15 failed: err : Data model "ietf-if-extensions"
    not found.
[YQ]: this is a tool issue. The model has been compiled using pyang and the examples also verified with yanglint.

v2.23.0 | Report a Bug | By Email