IETF Logo Mail Archive

Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-spring-sr-replication-segment-14

Lars Eggert <lars@eggert.org> Fri, 04 August 2023 08:26 UTC

Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F8B8C151980; Fri, 4 Aug 2023 01:26:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.108
X-Spam-Level:
X-Spam-Status: No, score=-2.108 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pw8lo2PldQc4; Fri, 4 Aug 2023 01:26:54 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4680CC1522AD; Fri, 4 Aug 2023 01:26:54 -0700 (PDT)
Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id F3E9B8071F; Fri, 4 Aug 2023 11:26:50 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eggert.org; s=dkim; t=1691137611; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=HwFsYYnC+tXipTVRKjfezgYvWsW2nix0JYe0mdt+2lg=; b=CyyXet6O1xhRkd29MMvKmLsYv2Pxla00if53l+yh8v/63tWR1WQGkT4popB/eA9PFPHfVC fqUz3ff1GokWQFAs67BhK4W68PbkNoN/dOpdWn4rqK840bQzphVqtkb5jV0pW4GVeDm1bF MwKAchpYfskOwZihU+NRYTeCaNazAOv0CeHS9aErvCcpH/GYny9crYFLIwEonNuTgbuI6m bmalzX+bSSR7+cTKpqkdXQnX4rzLeT+WHF/n7Hner9Zdi3T1JFfp7S2CLRMfK+3aBDrSwF qW9LCBB+GddfRqE2s2wVnTDWGrPvd4ivhLDf/VtNuC6n6PkGzKd599Zuc+uqMg==
Content-Type: multipart/signed; boundary="Apple-Mail=_9C15F765-3CDE-4CCC-9555-D100FEEE98CA"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <168632650880.62569.14866459241619472156@ietfa.amsl.com>
Date: Fri, 04 Aug 2023 11:26:49 +0300
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-spring-sr-replication-segment.all@ietf.org, last-call@ietf.org, spring@ietf.org
Message-Id: <0B553CF9-30B4-44CA-A440-F825B4329552@eggert.org>
References: <168632650880.62569.14866459241619472156@ietfa.amsl.com>
To: Thomas Fossati <thomas.fossati@arm.com>
X-Last-TLS-Session-Version: TLSv1.2
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/g4c6xtkoTSbjvesrhWUhnteHfnY>
Subject: Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-spring-sr-replication-segment-14
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Aug 2023 08:26:58 -0000

Thomas, thank you for your review. I have entered a Discuss ballot for this document based on my own review.

Lars


> On Jun 9, 2023, at 19:01, Thomas Fossati via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Thomas Fossati
> Review result: Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
> 
> Document: draft-ietf-spring-sr-replication-segment-14
> Reviewer: Thomas Fossati
> Review Date: 2023-06-09
> IETF LC End Date: 2023-06-19
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> The premise is I am not a routing expert and I only had a high level
> understanding of segment routing before reading this document.  That
> said, I have very much enjoyed the clarity and precision of the material
> presented and I think the authors have done a really good job, thank
> you!  (BTW, I have found the terminology section especially useful to
> navigate the rest of the draft.)
> 
> The instructions to IANA are concise and clear.
> 
>> From a Gen-ART perspective I reckon the document is ready.
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments:
> 
> * §1.1, 3rd bullet: s/period/period./
> * §2.1, 4th para: s/may be leaf node/may be the leaf node/
> * §2.2, 3rd para: s/Again note/Again, note/
> * §2.2, 4th para: s/this document/this document./
> * §2.2, 5th para: s/may be leaf node/may be the leaf node/
> * §2.2.1, 2nd para: s/contains following/contains the following/
> * §2.2.1, Replication State info model: s/maybe be empty/may be empty/
> * §2.2.1: s/in a SRH. As per psuedo-code/in an SRH. As per pseudo-code/
> * §2.2.2: s/apriori/a priori/
> * §2.2.3: s/this same restrictions/this same restriction/
> * §4: s/catalog/catalogue/
> 
> 
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call

v2.23.0 | Report a Bug | By Email