Re: [Gen-art] Genart telechat review of draft-ietf-sipcore-digest-scheme-10
"Roni Even (A)" <roni.even@huawei.com> Wed, 23 October 2019 12:28 UTC
Return-Path: <roni.even@huawei.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1E3191200D8; Wed, 23 Oct 2019 05:28:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.199
X-Spam-Level:
X-Spam-Status: No, score=-4.199 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U68Xe5Jp-c0m; Wed, 23 Oct 2019 05:28:55 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 86066120842; Wed, 23 Oct 2019 05:28:55 -0700 (PDT)
Received: from LHREML712-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 69317A717DDB266ABF1A; Wed, 23 Oct 2019 13:28:52 +0100 (IST)
Received: from lhreml708-chm.china.huawei.com (10.201.108.57) by LHREML712-CAH.china.huawei.com (10.201.108.35) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 23 Oct 2019 13:28:51 +0100
Received: from lhreml708-chm.china.huawei.com (10.201.108.57) by lhreml708-chm.china.huawei.com (10.201.108.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 23 Oct 2019 13:28:51 +0100
Received: from DGGEMM423-HUB.china.huawei.com (10.1.198.40) by lhreml708-chm.china.huawei.com (10.201.108.57) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA_P256) id 15.1.1713.5 via Frontend Transport; Wed, 23 Oct 2019 13:28:51 +0100
Received: from DGGEMM506-MBX.china.huawei.com ([169.254.3.89]) by dggemm423-hub.china.huawei.com ([10.1.198.40]) with mapi id 14.03.0439.000; Wed, 23 Oct 2019 20:28:45 +0800
From: "Roni Even (A)" <roni.even@huawei.com>
To: Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>
CC: Roni Even <ron.even.tlv@gmail.com>, "last-call@ietf.org" <last-call@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>, SIPCORE <sipcore@ietf.org>, "draft-ietf-sipcore-digest-scheme.all@ietf.org" <draft-ietf-sipcore-digest-scheme.all@ietf.org>
Thread-Topic: [Gen-art] Genart telechat review of draft-ietf-sipcore-digest-scheme-10
Thread-Index: AQHViRLSQ7R64lV9bkWHewyHEr3U66dntzAw///qWoCAAIbwIA==
Date: Wed, 23 Oct 2019 12:28:44 +0000
Message-ID: <6E58094ECC8D8344914996DAD28F1CCD23D931BF@DGGEMM506-MBX.china.huawei.com>
References: <157173348155.3011.12458315336826264414@ietfa.amsl.com> <CAGL6epLBJQgEH=F9V9daEAsn3P9BWjcXsgx8K15k-Vk9FcVWmg@mail.gmail.com> <6E58094ECC8D8344914996DAD28F1CCD23D93020@DGGEMM506-MBX.china.huawei.com> <CAGL6epK0_2JvAmbUU7iiBDZoxfwnWJnoZWJRsQaG54ObdM6NEA@mail.gmail.com>
In-Reply-To: <CAGL6epK0_2JvAmbUU7iiBDZoxfwnWJnoZWJRsQaG54ObdM6NEA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.200.202.54]
Content-Type: multipart/alternative; boundary="_000_6E58094ECC8D8344914996DAD28F1CCD23D931BFDGGEMM506MBXchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/vRxn0gjLVFrjhzZp6xCnO4hYC6I>
Subject: Re: [Gen-art] Genart telechat review of draft-ietf-sipcore-digest-scheme-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Oct 2019 12:28:58 -0000
HI Rifaat, OK, no other comments Roni From: Rifaat Shekh-Yusef [mailto:rifaat.ietf@gmail.com] Sent: Wednesday, October 23, 2019 3:25 PM To: Roni Even (A) Cc: Roni Even; last-call@ietf.org; gen-art@ietf.org; SIPCORE; draft-ietf-sipcore-digest-scheme.all@ietf.org Subject: Re: [Gen-art] Genart telechat review of draft-ietf-sipcore-digest-scheme-10 Hi Roni, I agree with the ABNF issue. I will fix that in the next version of the draft. Thanks, Rifaat On Wed, Oct 23, 2019 at 1:43 AM Roni Even (A) <roni.even@huawei.com<mailto:roni.even@huawei.com>> wrote: Rifaat thanks, See in line Roni On Tue, Oct 22, 2019 at 4:38 AM Roni Even via Datatracker <noreply@ietf.org<mailto:noreply@ietf.org>> wrote: Reviewer: Roni Even Review result: Almost Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please wait for direction from your document shepherd or AD before posting a new version of the draft. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-sipcore-digest-scheme-?? Reviewer: Roni Even Review Date: 2019-10-22 IETF LC End Date: None IESG Telechat date: 2019-10-31 Summary: The document is almost ready for publication as a standard track RFC Major issues: Minor issues: 1. In section 2.4 " If the UAC cannot respond to any of the challenges in the response, then it SHOULD abandon attempts to send the request, e.g. if the UAC does not have credentials or has stale credentials for any of the realms, unless a local policy dictates otherwise." Yet RFC3261 section 22.2 " If no credentials for a realm can be located, UACs MAY attempt to retry the request with a username of "anonymous" and no password (a password of ""). Is this deprecated ? No, it is not deprecated by this document, and that part is covered by the last sentence of the quoted paragraph, which talks about a local policy. RE: I have no strong feeling it is just that the language is different 2. RFC3261 algorithm includes "MD5-sess" while section 2.6 removed it These changes are provided in the context of RFC7616, so if an implementation supports "-sess" it could always refer to that document for these details. RE: I think that the BNF algorithm = "algorithm" EQUAL ( "MD5" / "SHA-512-256" / "SHA-256"/ token ) should be algorithm = "algorithm" EQUAL ( "MD5" / "MD5-sess / "SHA-512-256" / "SHA-256"/ token ) 3. it may be good to have a backward compatibility section. I believe we covered that in the security consideration section. Do you see anything missing there? RE: OK, no problem. Regards, Rifaat Nits/editorial comments:
- [Gen-art] Genart telechat review of draft-ietf-si… Roni Even via Datatracker
- Re: [Gen-art] Genart telechat review of draft-iet… Rifaat Shekh-Yusef
- Re: [Gen-art] Genart telechat review of draft-iet… Roni Even (A)
- Re: [Gen-art] Genart telechat review of draft-iet… Rifaat Shekh-Yusef
- Re: [Gen-art] Genart telechat review of draft-iet… Roni Even (A)
- Re: [Gen-art] Genart telechat review of draft-iet… Alissa Cooper