Re: [Gen-art] [Id-event] Genart last call review of draft-ietf-secevent-http-poll-09

Mike Jones <Michael.Jones@microsoft.com> Fri, 05 June 2020 00:48 UTC

Return-Path: <Michael.Jones@microsoft.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EDCB93A0B56; Thu, 4 Jun 2020 17:48:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.101
X-Spam-Level:
X-Spam-Status: No, score=-2.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B1b3moBopWM3; Thu, 4 Jun 2020 17:48:58 -0700 (PDT)
Received: from NAM06-BL2-obe.outbound.protection.outlook.com (mail-eopbgr650104.outbound.protection.outlook.com [40.107.65.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D01FF3A0B44; Thu, 4 Jun 2020 17:48:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mSSBxlckMxM3ZYPVxyWQM8oPeHd6GvDbyqi93NW/iW6OMjwEOWEO0603kUoQoNiBkADL+BHh6lWkq3TGjbfAOOQ+ESmTzG7BN9jqQa552SBKVH5LO/7CpXYR9D6Um7KzZh8GLEO31V8+9mr3ZsE+2UHx8ai8oJukVsasUyYGNe7Ws7tvBYL9es71omYzLyo9JQKlQQZL6t8eqd1/ITg4U3NFXUbywW39/7R3eXeTVGCgHlLuvOs9sjzHokTUykuRMrdaYWo0uWHJh9fd8jSobEl23oSgVjNP9gp97gD58CqHSPM4gkWHXYExqcSziYQBb7mwQL3ScHTXuUv3wsaJow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a4hdbYXmlHt5ozVfkE9oPuGYOZi60cKac4BAVkAYKe8=; b=JCf+YTlf+Ilm3uvBshvc+IcnS/06iTEPNJEfivy0qsxwPo81KB2IxY3iXDq9AdpDUdPstygj/tE/5USd7ubHF89IEfAjKXwumPu4V3TLa1M7s8HbsXdrVZasBf3nQXP9cQFmqj1yjiyl9vZbkH873FnVckH+2B4oZVS/hQ0Y1W+uj5UIOwzY58QUkfmzHoKHgvANmPUN4dqTv9vMYgBxNxM16gYpYDxwGhmZ9F/FcqWPSe7cpmc42gybpFUVNxrQSEraYisAfwUatGkFmCiNnrXuWGzEcRYL9rqxkEtyI1juhSnQ6kkLbLLgnzAA+PjzR/JSwNpIXi1HtmBUbmBgFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a4hdbYXmlHt5ozVfkE9oPuGYOZi60cKac4BAVkAYKe8=; b=DEIZQaVCfQgNdRzIilU6iMW5pJ73aHKve2FpAQkDmYaP/6eHMLxZhtCORiPePAHAbsNWreEYvmCyIHzkDNRmrsSYPsRty8oW3v9QbGr4ZiQrQ1vvJsnmCXqyJiS269F3FtTyKoabolp6J1NF4/4podcdc/yzuCpc6I/4UbJoE4o=
Received: from CH2PR00MB0678.namprd00.prod.outlook.com (2603:10b6:610:a9::23) by CH2PR00MB0811.namprd00.prod.outlook.com (2603:10b6:610:6f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3104.0; Fri, 5 Jun 2020 00:48:52 +0000
Received: from CH2PR00MB0678.namprd00.prod.outlook.com ([fe80::f158:8611:537b:9f84]) by CH2PR00MB0678.namprd00.prod.outlook.com ([fe80::f158:8611:537b:9f84%7]) with mapi id 15.20.3109.000; Fri, 5 Jun 2020 00:48:52 +0000
From: Mike Jones <Michael.Jones@microsoft.com>
To: Robert Sparks <rjsparks@nostrum.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "draft-ietf-secevent-http-poll.all@ietf.org" <draft-ietf-secevent-http-poll.all@ietf.org>, "id-event@ietf.org" <id-event@ietf.org>
Thread-Topic: [Id-event] Genart last call review of draft-ietf-secevent-http-poll-09
Thread-Index: AdY60xKyY1QDrK2JRA2b52VtQpNZPA==
Date: Fri, 05 Jun 2020 00:48:52 +0000
Message-ID: <CH2PR00MB0678026DC6A8BE87C1068B12F5860@CH2PR00MB0678.namprd00.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=66c40b1b-742a-423c-a958-0000abe34fc2; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-06-05T00:16:58Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: nostrum.com; dkim=none (message not signed) header.d=none;nostrum.com; dmarc=none action=none header.from=microsoft.com;
x-originating-ip: [50.47.87.252]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: e1b22129-80b0-46ea-76a0-08d808ea37e0
x-ms-traffictypediagnostic: CH2PR00MB0811:
x-microsoft-antispam-prvs: <CH2PR00MB0811D768C9B7068B4272A560F5860@CH2PR00MB0811.namprd00.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0425A67DEF
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 7jlOK/pb25CCQt7C9bh4/KGUuRayc/liOAQ5Gw/r07Z1ZkPaYNSi2W6pyjO7WQuBBfycoVFeut4mIgXIdmaFDNtUXX5wDBVzYHL/n078DjPtCNRkFwleRMFwvEf+FiPTszgP7nXaNN/UYn8fS4G4EW+CY8vEvIa1l1V+IC/aJHIiIdEX5YoMhS+PcunDO2dFOGEeHqMrSL0f7lQp/DMTl4BtvtubejdTQ8KXPe/iBbw8hZinXGCr02U4JmZ/8EywpAc1DYZ+PBUVddNfLFu6TSMxhyj+JvKyhryacVYubu7UmE61zLy7W/wggdn5VKGy+DSc51DpquXhheDsxDNcWywZ4X9yrXlDc82/NGnzEgIEM5mUi/8Z8YU0RJabW8iWBcGSK7Y+3BnT96OLRoclKA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR00MB0678.namprd00.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(136003)(39860400002)(396003)(366004)(966005)(53546011)(82960400001)(83380400001)(478600001)(9686003)(33656002)(7696005)(10290500003)(64756008)(86362001)(6506007)(8676002)(66476007)(82950400001)(66946007)(8990500004)(55016002)(76116006)(66556008)(66446008)(8936002)(316002)(54906003)(110136005)(4326008)(52536014)(71200400001)(26005)(2906002)(5660300002)(186003); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: XLRYydAXhfa4h8MmRu6J8oXlZ5e8K5Z8yKEN7ZY2uIogo55MB+EX1zC527hqV7ialJNJOGJvyMz2ZH2VfBI1laZ0a/jkOBUUclk2BlA2iFXDosHNXoqXDJc1+9L7ic8klsaTbqcmEx0ps6R05R1Beg98BUOa6ERsicdP4JPgER8EzYQUsyNEoetffMPxRY7brvk7EeSwgv68R4suo18oy2d8ki7hq7W79zVYRLsR+Bw6rRKhXJ1NkMFWnT6gcytrNv7uDtLSkBCYKVyrSBT04sb4kGwyeRWWrybPySAI42WCDNkmS40wjZi6QFl2b/6MfDAkOrRgNL34Zxu2FyV6LHTE9NW84zTZ5fchThRW2EQjS2qhqTkGcscj/c2FuV0whEa8YwUexQT1CNU/QdG+z71vZV6gpkwkIscIU85yl+jh/unOID/Ub1QyDptLlwDpqaMBRwJ96ESulE0oYkFczTgEWFsKzFV3Oq/jI6h9Mu8=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1b22129-80b0-46ea-76a0-08d808ea37e0
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2020 00:48:52.5264 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1o1KrbH8ON3Ppw1YG5z8izQdoFAcioKXkN/V8gSsXkfWLc6spRSCpsZXmQFPIWR3m78el3fXKG/IJM6qMz9p3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR00MB0811
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/xW-47RpSZ1UfRbOVTdrSNviAO1A>
Subject: Re: [Gen-art] [Id-event] Genart last call review of draft-ietf-secevent-http-poll-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jun 2020 00:49:00 -0000

Thanks for the quick reply.  My responses are inline, prefixed by "Mike>".

-----Original Message-----
From: Robert Sparks <rjsparks@nostrum.com> 
Sent: Thursday, June 4, 2020 2:51 PM
To: Mike Jones <Michael.Jones@microsoft.com>; gen-art@ietf.org
Cc: last-call@ietf.org; draft-ietf-secevent-http-poll.all@ietf.org; id-event@ietf.org
Subject: Re: [Id-event] Genart last call review of draft-ietf-secevent-http-poll-09


On 6/4/20 4:27 PM, Mike Jones wrote:
> Thanks for your review, Robert.  I'm working on addressing the review comments received and wanted to have a clarifying discussion on some of yours before deciding what corresponding edits to make.
>
> I think there's a misunderstanding about "jti" values and the security 
> model.  Because communication is over a TLS-protected channel

Not always, and that's an important part of my point.

See the first sentence of section 4.1:

"   In scenarios where HTTP authorization or TLS mutual authentication
    are not used or are considered weak, "

Mike> Frankly, the text you're citing never seemed very clear or well motivated to me.  It was written by an earlier editor who since stopped working on the spec.  I'm going to just remove it and unambiguously require HTTPS.

> between two parties, it would be fine if the JTI values were totally guessable, such as "A", "B", "C", etc.  There's no opportunity for an attacker to inject traffic into or to listen to the stream.  Does that make sense to you?
_If_ it were never possible for authorization to be weak or for TLS auth to not be used, then sure. But the exception you call out at 4.1 exactly allows someone to be an attacker this way.
>
> As for limits on how long a transmitter is required to hold a SET, I propose to add this text:
>        Transmitters may also discard undelivered SETs under deployment-specific conditions,
>        such as if they have not been polled for over too long a period of time
>        or if an excessive amount of storage is needed to retain them.
That's better, but consider being a bit more specific about "too long".

Mike> That's deployment-specific, but I'm open to wording suggestions.

>
> 				-- Mike
>
> -----Original Message-----
> From: Id-event <id-event-bounces@ietf.org> On Behalf Of Robert Sparks 
> via Datatracker
> Sent: Friday, May 8, 2020 11:57 AM
> To: gen-art@ietf.org
> Cc: last-call@ietf.org; draft-ietf-secevent-http-poll.all@ietf.org; 
> id-event@ietf.org
> Subject: [Id-event] Genart last call review of 
> draft-ietf-secevent-http-poll-09
>
> Reviewer: Robert Sparks
> Review result: Ready with Issues
>
> I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-secevent-http-poll-09
> Reviewer: Robert Sparks
> Review Date: 2020-05-08
> IETF LC End Date: 2020-05-13
> IESG Telechat date: Not scheduled for a telechat
>
> Summary: Essentially ready but with some issues to consider before 
> publishing as a Proposed Standard RFC
>
> This document is well-written and easy to follow.
>
> I have a couple of edge-case issues that I think should be considered though:
>
> This document allows, and anticipates, deployments where Recipients are not well authenticated. See, for example, the first sentence of section 4.1. There is also an unstated expectation in the document that the jti of each SET is hard to guess.  If it's reasonably easy to guess jti values, a malicious Recipient could ack SETs it has never received and the Transmitter will remove that state, preventing a valid Recipient from ever receiving that SET.
>
> If that's an explicit requirement in the jwt or SET base documents for the jti to be hard to guess, please point me to it? If there's not, perhaps a short discussion in the security considerations requiring this property would be worthwhile?
>
> Is there a discussion somewhere of how long the transmitter is required to hold a given SET for a Recipient? Forever seems unreasonable.
>
>
>
> _______________________________________________
> Id-event mailing list
> Id-event@ietf.org
> https://www.ietf.org/mailman/listinfo/id-event