Re: [GROW] Working Group Last Call (WGLC) for draft-ietf-grow-bmp-peer-up (start 22/Jan/2024 end 6/Feb/2024)

Paolo Lucente <paolo@ntt.net> Tue, 06 February 2024 17:50 UTC

Return-Path: <paolo@ntt.net>
X-Original-To: grow@ietfa.amsl.com
Delivered-To: grow@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C18DC151548 for <grow@ietfa.amsl.com>; Tue, 6 Feb 2024 09:50:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.907
X-Spam-Level:
X-Spam-Status: No, score=-1.907 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EJgvsQ1QPlWX for <grow@ietfa.amsl.com>; Tue, 6 Feb 2024 09:50:40 -0800 (PST)
Received: from mail4.dllstx09.us.to.gin.ntt.net (mail4.dllstx09.us.to.gin.ntt.net [IPv6:2001:418:3ff:5::192:26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4AC8AC151081 for <grow@ietf.org>; Tue, 6 Feb 2024 09:50:40 -0800 (PST)
Received: from [172.20.6.75] (unknown [181.143.81.116]) by mail4.dllstx09.us.to.gin.ntt.net (Postfix) with ESMTPSA id 31805EE017B; Tue, 6 Feb 2024 17:50:39 +0000 (UTC)
Message-ID: <4f345db6-7eb9-4e96-b89d-eb7266f3e8ab@ntt.net>
Date: Tue, 06 Feb 2024 12:50:37 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Maxence Younsi <maxence.younsi@insa-lyon.fr>, grow@ietf.org
References: <5c4a50c0-a140-42e6-a882-6b307dce04bd@insa-lyon.fr>
From: Paolo Lucente <paolo@ntt.net>
In-Reply-To: <5c4a50c0-a140-42e6-a882-6b307dce04bd@insa-lyon.fr>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/grow/FmQtvgkBB0pn8vlyoQRpnb2IaqM>
Subject: Re: [GROW] Working Group Last Call (WGLC) for draft-ietf-grow-bmp-peer-up (start 22/Jan/2024 end 6/Feb/2024)
X-BeenThere: grow@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Grow Working Group Mailing List <grow.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/grow>, <mailto:grow-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow/>
List-Post: <mailto:grow@ietf.org>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/grow>, <mailto:grow-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Feb 2024 17:50:44 -0000

Surely Maxence, thanks for your comment. I will update the draft with 
this note.

Paolo


On 25/1/24 07:53, Maxence Younsi wrote:
> Dear all,
> 
> 
> I support the adoption of draft-ietf-grow-bmp-peer-up.
> 
> A small detail I think could be changed is that the definition of a 
> string in Section 2 should specify that the length in the TLV's Length 
> field is in bytes and not a number of character ("whose length *in 
> bytes* is given by [...]" ). It is already specified in Section 3.3:
> 
>     *  Information Length (2 bytes): The length of the following
>        Information field, in bytes.
> 
> but not in Section 2:
> 
> 2.  String Definition
> 
>     A string TLV is a free-form sequence of UTF-8 characters whose length
>     is given by the TLV's Length field.  There is no requirement to
>     terminate the string with a null (or any other particular) character
>     -- the Length field gives its termination.
> 
> 
> 
> Kind regards,
> 
> Maxence.
> 
> 
> _______________________________________________
> GROW mailing list
> GROW@ietf.org
> https://www.ietf.org/mailman/listinfo/grow