Re: [GROW] Working Group Last Call (WGLC) for draft-ietf-grow-bmp-peer-up (start 22/Jan/2024 end 6/Feb/2024)

Maxence Younsi <maxence.younsi@insa-lyon.fr> Thu, 25 January 2024 12:53 UTC

Return-Path: <maxence.younsi@insa-lyon.fr>
X-Original-To: grow@ietfa.amsl.com
Delivered-To: grow@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BCE0DC16A126 for <grow@ietfa.amsl.com>; Thu, 25 Jan 2024 04:53:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.606
X-Spam-Level:
X-Spam-Status: No, score=-2.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pl4Xjf5IBxmi for <grow@ietfa.amsl.com>; Thu, 25 Jan 2024 04:53:32 -0800 (PST)
Received: from smtpout02-ext4.partage.renater.fr (smtpout02-ext4.partage.renater.fr [194.254.241.31]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8D11CC1516E1 for <grow@ietf.org>; Thu, 25 Jan 2024 04:53:30 -0800 (PST)
Received: from zmtaauth02.partage.renater.fr (zmtaauth02.partage.renater.fr [194.254.241.25]) by smtpout20.partage.renater.fr (Postfix) with ESMTP id 884AABFB52 for <grow@ietf.org>; Thu, 25 Jan 2024 13:53:27 +0100 (CET)
Received: from zmtaauth02.partage.renater.fr (localhost [127.0.0.1]) by zmtaauth02.partage.renater.fr (Postfix) with ESMTPS id A99C8A03D8 for <grow@ietf.org>; Thu, 25 Jan 2024 13:53:27 +0100 (CET)
Received: from localhost (localhost [127.0.0.1]) by zmtaauth02.partage.renater.fr (Postfix) with ESMTP id A4DA5A048F for <grow@ietf.org>; Thu, 25 Jan 2024 13:53:27 +0100 (CET)
Received: from zmtaauth02.partage.renater.fr ([127.0.0.1]) by localhost (zmtaauth02.partage.renater.fr [127.0.0.1]) (amavis, port 10026) with ESMTP id q1GWScCsuQw4 for <grow@ietf.org>; Thu, 25 Jan 2024 13:53:27 +0100 (CET)
Received: from [10.56.68.104] (unknown [194.254.241.250]) by zmtaauth02.partage.renater.fr (Postfix) with ESMTPA id 771C3A03D8 for <grow@ietf.org>; Thu, 25 Jan 2024 13:53:27 +0100 (CET)
Content-Type: multipart/alternative; boundary="------------PUVvwBycDWq1qtFI9ee3GCpI"
Message-ID: <5c4a50c0-a140-42e6-a882-6b307dce04bd@insa-lyon.fr>
Date: Thu, 25 Jan 2024 13:53:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: grow@ietf.org
Content-Language: en-US
From: Maxence Younsi <maxence.younsi@insa-lyon.fr>
X-Virus-Scanned: clamav-milter 0.103.8 at clamav04
X-Virus-Status: Clean
X-Renater-Ptge-SpamState: clean
X-Renater-Ptge-SpamScore: 0
X-Renater-Ptge-SpamCause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdelgedgudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecutffgpfetvffgtfenuceurghilhhouhhtmecufedttdenucenucfjughrpegtkfffgggfvffuhfesrgdtreertddvjeenucfhrhhomhepofgrgigvnhgtvgcujghouhhnshhiuceomhgrgigvnhgtvgdrhihouhhnshhisehinhhsrgdqlhihohhnrdhfrheqnecuggftrfgrthhtvghrnhepuedutddvtefhtdevvdehtdejfedvuedtleelheefgfeuteetgfejleeggffftddunecukfhppeduleegrddvheegrddvgedurddvhedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepudelgedrvdehgedrvdeguddrvdehtddphhgvlhhopegluddtrdehiedrieekrddutdegngdpmhgrihhlfhhrohhmpeforgigvghntggvucgjohhunhhsihcuoehmrgigvghntggvrdihohhunhhsihesihhnshgrqdhlhihonhdrfhhrqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehgrhhofiesihgvthhfrdhorhhg
Archived-At: <https://mailarchive.ietf.org/arch/msg/grow/X20NRG9TaKrJt-GNWX8__hUm7Bo>
Subject: Re: [GROW] Working Group Last Call (WGLC) for draft-ietf-grow-bmp-peer-up (start 22/Jan/2024 end 6/Feb/2024)
X-BeenThere: grow@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Grow Working Group Mailing List <grow.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/grow>, <mailto:grow-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow/>
List-Post: <mailto:grow@ietf.org>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/grow>, <mailto:grow-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jan 2024 12:53:35 -0000

Dear all,


I support the adoption of draft-ietf-grow-bmp-peer-up.

A small detail I think could be changed is that the definition of a 
string in Section 2 should specify that the length in the TLV's Length 
field is in bytes and not a number of character ("whose length *in 
bytes* is given by [...]" ). It is already specified in Section 3.3:

    *  Information Length (2 bytes): The length of the following
       Information field, in bytes.

but not in Section 2:

2.  String Definition

    A string TLV is a free-form sequence of UTF-8 characters whose length
    is given by the TLV's Length field.  There is no requirement to
    terminate the string with a null (or any other particular) character
    -- the Length field gives its termination.



Kind regards,

Maxence.