Re: [GROW] Genart LC review: draft-ietf-grow-filtering-threats-06

Pierre Francois <pierre.francois@imdea.org> Thu, 25 June 2015 10:23 UTC

Return-Path: <pierre.francois@imdea.org>
X-Original-To: grow@ietfa.amsl.com
Delivered-To: grow@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B07841B32BC; Thu, 25 Jun 2015 03:23:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id olhmqY1yerma; Thu, 25 Jun 2015 03:23:10 -0700 (PDT)
Received: from estafeta21.imdea.org (maquina46.madrimasd.org [193.145.15.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 244681B3518; Thu, 25 Jun 2015 03:23:10 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by estafeta21.imdea.org (imdea mail daemon) with ESMTP id C707B317958; Thu, 25 Jun 2015 12:21:40 +0200 (CEST)
X-Virus-Scanned: by antispam-antivirus system at imdea.org
Received: from estafeta21.imdea.org ([127.0.0.1]) by localhost (estafeta21.imdea.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sq87Q_Hs51F0; Thu, 25 Jun 2015 12:21:40 +0200 (CEST)
Received: from [10.53.171.161] (171.Red-176-83-45.dynamicIP.rima-tde.net [176.83.45.171]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: pierre.francois) by estafeta21.imdea.org (imdea mail daemon) with ESMTPSA id 70E2F317955; Thu, 25 Jun 2015 12:21:38 +0200 (CEST)
References: <558B3AEE.2010009@nostrum.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <558B3AEE.2010009@nostrum.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Message-Id: <06DD2A90-ED25-4697-B35C-9CD9D852C7AF@imdea.org>
X-Mailer: iPhone Mail (12F70)
From: Pierre Francois <pierre.francois@imdea.org>
Date: Thu, 25 Jun 2015 12:23:02 +0200
To: Robert Sparks <rjsparks@nostrum.com>
Archived-At: <http://mailarchive.ietf.org/arch/msg/grow/GgrgS6bkFMSLq5m8IQmg7Gol66E>
Cc: General Area Review Team <gen-art@ietf.org>, "grow@ietf.org" <grow@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-grow-filtering-threats.all@ietf.org" <draft-ietf-grow-filtering-threats.all@ietf.org>
Subject: Re: [GROW] Genart LC review: draft-ietf-grow-filtering-threats-06
X-BeenThere: grow@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Grow Working Group Mailing List <grow.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/grow>, <mailto:grow-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/grow/>
List-Post: <mailto:grow@ietf.org>
List-Help: <mailto:grow-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/grow>, <mailto:grow-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2015 10:23:12 -0000

Robert,

Thanks a lot for your contribution to this work.

Comments inline [pfr]

Pierre.

Sent from my iPhone

> On Jun 25, 2015, at 1:19 AM, Robert Sparks <rjsparks@nostrum.com> wrote:
> 
> I am the assigned Gen-ART reviewer for this draft. For background on
> Gen-ART, please see the FAQ at
> 
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Please resolve these comments along with any other Last Call comments
> you may receive.
> 
> Document: draft-ietf-grow-filtering-threats-06
> Reviewer: Robert Sparks
> Review Date: 24-Jun-2015
> IETF LC End Date: 2-Jul-2015
> IESG Telechat date: not yet scheduled for a telechat
> 
> Summary: Ready with nits
> 
> From looking at the document history and list archives, this document's been around for some time, and has had some editorial push already.
> The unintended consequences it highlights are interesting, and it will be useful to operators to know these possible causes of unexpected behavior.
> 
> I encourage another strong editing pass before publication.
> 
> This is being published as an IETF-stream document. When published it reflects IETF consensus.
> There are places in the text that I think are problematic given that status. The issues are editorial, and I expect they will be easy to address.
> 
> The document uses "we" frequently. Originally, that meant the authors. It's ambiguous what it means in an IETF-stream document. I suggest editing out all occurrences. Try to avoid simply changing "we" to "the authors" - find a way to reflect what the IETF is saying here.

[pfr] I agree. We'll do that.

> 
> Is the last paragraph of 4.1 an IETF consensus position on how operators might charge one another? It would be good to find a way to word this that look more like statements of fact and less like charging advice.

[pfr] This sentence dates from the time we were interviewing ops and peering managers, asking them what they'd do. We got this as an answer a couple of times. I think Job's proposal to remove it is the right approach.


> 
> The document draws some conclusions that I think are unnecessary. For instance, "Therefore, we conclude that the reactive approach is the more reasonable recommendation to deal with unexpected flows." Why does the IETF need to say that (and is it an IETF consensus statement)? It would be enough, I think, to reduce the discussion in these sections to calling out the issues with each approach.

[pfr] Can I use the IETF vs authors trick here? 

> 
> Please simplify the sentences, and avoid passive construction. For instance, "It can be considered problematic to be causing unexpected traffic flows in other ASes." can be much shorter. After you do that, I think you'll find it easier to identify and collapse sections of redundant text.

[pfr] Thanks a lot for the feedback. 

Pierre.


> 
> RjS
>