Re: [Hipsec] WGLC: draft-ietf-hip-dex-04

Robert Moskowitz <rgm@htt-consult.com> Tue, 22 November 2016 05:34 UTC

Return-Path: <rgm@htt-consult.com>
X-Original-To: hipsec@ietfa.amsl.com
Delivered-To: hipsec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 91C65129512 for <hipsec@ietfa.amsl.com>; Mon, 21 Nov 2016 21:34:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.698
X-Spam-Level:
X-Spam-Status: No, score=-5.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-1.497, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HPkRj4oiIzHn for <hipsec@ietfa.amsl.com>; Mon, 21 Nov 2016 21:34:51 -0800 (PST)
Received: from z9m9z.htt-consult.com (z9m9z.htt-consult.com [50.253.254.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 58D6F129471 for <hipsec@ietf.org>; Mon, 21 Nov 2016 21:34:51 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by z9m9z.htt-consult.com (Postfix) with ESMTP id D088662132; Tue, 22 Nov 2016 00:34:47 -0500 (EST)
X-Virus-Scanned: amavisd-new at htt-consult.com
Received: from z9m9z.htt-consult.com ([127.0.0.1]) by localhost (z9m9z.htt-consult.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3E0HVxl8MuTf; Tue, 22 Nov 2016 00:34:43 -0500 (EST)
Received: from lx120e.htt-consult.com (unknown [192.168.160.12]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by z9m9z.htt-consult.com (Postfix) with ESMTPSA id 045BC60758; Tue, 22 Nov 2016 00:34:41 -0500 (EST)
To: Tom Henderson <tomhend@u.washington.edu>, Gonzalo Camarillo <Gonzalo.Camarillo@ericsson.com>
References: <alpine.LRH.2.01.1611191832580.24556@hymn03.u.washington.edu>
From: Robert Moskowitz <rgm@htt-consult.com>
Message-ID: <c13f0b43-d1ab-6ed0-d0ec-3f8f17d8a41f@htt-consult.com>
Date: Tue, 22 Nov 2016 00:34:41 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.LRH.2.01.1611191832580.24556@hymn03.u.washington.edu>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/hipsec/GWWmV8gPz_V5H-yG-6iIpE3WxtA>
Cc: HIP <hipsec@ietf.org>
Subject: Re: [Hipsec] WGLC: draft-ietf-hip-dex-04
X-BeenThere: hipsec@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "This is the official IETF Mailing List for the HIP Working Group." <hipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/hipsec>, <mailto:hipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/hipsec/>
List-Post: <mailto:hipsec@ietf.org>
List-Help: <mailto:hipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hipsec>, <mailto:hipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Nov 2016 05:34:55 -0000

Oh,

And Tom, thanks for the solid review.

Bob

On 11/19/2016 09:32 PM, Tom Henderson wrote:
> Gonzalo, I have reviewed HIP DEX again and believe it is ready to 
> publish, although I spotted a few minor items below that can be 
> handled in the next revision.
>
> - Tom
>
> Editorial/minor:
>
> Section 1:  The numbered list is somewhat tersely written and may be 
> hard to interpret by the newcomer to HIP specifications. Consider to 
> elaborate more (using fuller sentences and not sentence fragments).  
> e.g.:
>
> "Forfeit of Perfect Forward Secrecy with the dropping of an ephemeral 
> Diffie-Hellman key agreement." could be
> "Forfeit of the HIPv2 Perfect Forward Secrecy property due to the 
> removal of the HIPv2 ephemeral Diffie-Hellman key agreement."
>
> Section 1.1, spell out 'DoS' first time usage
>
> Section 4.1:  "Note that x and y each constitute half the final 
> session key material."  (change to 'half of the')
>
> The figure in 4.1 does not have a caption, and also, why is 'mac' 
> lowercased?
>
> Sec 4.1.3.1:  "Since only little data is protected by this SA" 
> (perhaps s/little/a small amount/)
>
> Sec. 5.2.4:  "The following new HIT Suite IDs are defined..." (s/IDs 
> are/ID is/ because there is only one defined)
>
> Sec. 6.3:  "sort(HIT-I | HIT-R) is defined as the network byte order 
> concatenation of the two HITs... comparison of the two HITs 
> interpreted as positive (unsigned) 128-bit integers in network byte 
> order"  what does it mean to define a sort on a network byte order 
> concatenation?  It seems perhaps clearer to leave endian issues out 
> (they are implicit everywhere in a protocol) and just define it as a 
> comparison on HITs interpreted as unsigned 128-bit integers (and by 
> the way, is the full 128 bits including prefix included or just the 96 
> bits)?
>
> Sec. 6.5 through 6.8:  Unlike much of this draft, these sections do 
> not just specifically call out the differences from the corresponding 
> RFC 7401 sections, but instead restate the modified processing flow, 
> and it is hard to spot what is different here.  I wonder whether it 
> would be clearer to just refer to those processing steps in RFC 7401 
> that are changed.
>
> Sec. 8:  Can a MITM reply to I1 with ICMP parameter problem, causing 
> the true response (coming later) to be ignored because the initiator 
> already gave up?  Maybe clarify here or in sec 5.4 to wait a little 
> while before accepting the result of an ICMP.
>
> Sec. 10:  Consider to update the IANA section in the style that RFC 
> 8003 (and others) used, stating the history of the registry and what 
> exactly is requested to be changed.  For example, something like "RFC 
> 5201 and later RFC 7401 established the following registry ....  This 
> document defines the following new codepoints for that registry ..."
>
> _______________________________________________
> Hipsec mailing list
> Hipsec@ietf.org
> https://www.ietf.org/mailman/listinfo/hipsec
>