Re: [homenet] Lars Eggert's Discuss on draft-ietf-homenet-naming-architecture-dhc-options-22: (with DISCUSS and COMMENT)

Daniel Migault <mglt.ietf@gmail.com> Thu, 20 October 2022 13:37 UTC

Return-Path: <mglt.ietf@gmail.com>
X-Original-To: homenet@ietfa.amsl.com
Delivered-To: homenet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB707C14CE2E; Thu, 20 Oct 2022 06:37:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g3LSI1TxeASd; Thu, 20 Oct 2022 06:37:21 -0700 (PDT)
Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 02138C14F612; Thu, 20 Oct 2022 06:37:20 -0700 (PDT)
Received: by mail-io1-xd34.google.com with SMTP id y80so17146668iof.3; Thu, 20 Oct 2022 06:37:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BHAROu2MU9Fg6O/Az9ZUmLAISl+9zpXkBe5Yvfc8ijs=; b=WxNiqmSp/8yQviG44KvApgOQxRjK+GyK/sg9blcO5xFhei+U766k2Y+gSux7AsETRM l38/OzjNPtdH2f6T0OufQa+9YTYuxxo2M1e/qKvA217MC9zi+iA8wpigpV0IRRylyl8F a6dKvNkir141jyBwTiNvTatQ3WxZKWuznKfJgWxm5lHkOBibkhFRJ/IRnPc98TcnzcGE 8VC993ViFubLPuKtOpmKpJYQlTiKTFIUY7D4WWCfhNuZV441SBFv3XyGzrHCbX9n4T8n ZzA3sCNokzZHxg/MNtxD6M+i7jknl8mWqJFo80lyQn5+VxaXp6FhmtlQUbwh4pDbHwIY q66Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BHAROu2MU9Fg6O/Az9ZUmLAISl+9zpXkBe5Yvfc8ijs=; b=cizGF5PuGby+fuzpxbl31j2Ls32RdGWN6Ur5YkHFg1u5dmBL/tgTthbD0cnrnHVZ9T Qpjo78l6mSHeyF6wLO12/Rqdnd2fGMk+vrr27R52qMoZXLN2EuzAdr6SK5sMTVKsHdef PiJLAbfh5kTr8wVY6/kWXkYvx5sX2E+MBJkyNsqClB5Ufi6z+7kwhFyU34WF39RIkBYF FuX8b+rIJ4S6f+kHSD85F8oLVU2LlnjyxPtFJnbMStExgG2GoreIZo8Ph0ouy11eDxyO PDyzsY90881CF3DszVp2uqPRqkgD7iZl7SWaKUtePqGT1ICFWXSbaTdRU4NDhU88urBw htXg==
X-Gm-Message-State: ACrzQf1WA7VJ3Q6OFFp8oTVgKsrkzSlMbudsz/a57XteK6PZMDwms3dp XG/Kquuq19GUXDYjwDJTxmpI/lE2WUkCWH3ExwaJHi5ZlXoi1A==
X-Google-Smtp-Source: AMsMyM6LzGKDUeySuRam979+WKMs2NGoTzOFr2cc0GJHJAb/qpQVxa7CBNfhjPX3PQIxO00/ozMsbt2bZI911++8lIw=
X-Received: by 2002:a05:6638:3709:b0:363:ef4b:280b with SMTP id k9-20020a056638370900b00363ef4b280bmr10440739jav.84.1666273040020; Thu, 20 Oct 2022 06:37:20 -0700 (PDT)
MIME-Version: 1.0
References: <166626845958.11296.3285156316077319642@ietfa.amsl.com>
In-Reply-To: <166626845958.11296.3285156316077319642@ietfa.amsl.com>
From: Daniel Migault <mglt.ietf@gmail.com>
Date: Thu, 20 Oct 2022 09:37:09 -0400
Message-ID: <CADZyTk=2kSfBbRiDU_wZZ1YiLd53zEOf_JXGQC0S_n=sn8bUAg@mail.gmail.com>
To: Lars Eggert <lars@eggert.org>
Cc: The IESG <iesg@ietf.org>, draft-ietf-homenet-naming-architecture-dhc-options@ietf.org, homenet-chairs@ietf.org, homenet@ietf.org, stephen.farrell@cs.tcd.ie
Content-Type: multipart/alternative; boundary="000000000000a63c0205eb776c0a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/homenet/kMSyW19UB1YaUqz-PHly7Z_TcQk>
Subject: Re: [homenet] Lars Eggert's Discuss on draft-ietf-homenet-naming-architecture-dhc-options-22: (with DISCUSS and COMMENT)
X-BeenThere: homenet@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Homenet WG mailing list <homenet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/homenet>, <mailto:homenet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/homenet/>
List-Post: <mailto:homenet@ietf.org>
List-Help: <mailto:homenet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/homenet>, <mailto:homenet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Oct 2022 13:37:24 -0000

Hi Lars,

Thanks for the comment. Please see my response inline below. The updates
associated to your comments can be found below:
https://github.com/ietf-homenet-wg/front-end-naming-delegation-dhc-options/commit/3113e186f17ed36ee3ec635b1414bdc181e06484

Yours,
Daniel


On Thu, Oct 20, 2022 at 8:21 AM Lars Eggert via Datatracker <
noreply@ietf.org> wrote:

> Lars Eggert has entered the following ballot position for
> draft-ietf-homenet-naming-architecture-dhc-options-22: Discuss
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to
> https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/
> for more information about how to handle DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
>
> https://datatracker.ietf.org/doc/draft-ietf-homenet-naming-architecture-dhc-options/
>
>
>
> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
>
> # GEN AD review of draft-ietf-homenet-naming-architecture-dhc-options-22
>
> CC @larseggert
>
> Thanks to Maria Ines Robles for the General Area Review Team (Gen-ART)
> review
> (https://mailarchive.ietf.org/arch/msg/gen-art/uld2ipgAwbN-LgVg9X1VjFAPUYY
> ).
>
> ## Discuss
>
> ### Section 4.2, paragraph 8
> ```
>      It is worth noticing that the Supported Transport field does not
>      enable to specify a port and the used port is defined by a standard.
>      In the case of DNS over TLS [RFC7858], the port is defined by
>      [RFC7858] to be 853.  The need for such flexibility has been balanced
>      with the difficulty of handling a list of tuples ( transport, port )
>      as well as the possibility to use a dedicated IP address for the DM.
> ```
> 7858 actually says
>
>    By default, a DNS server that supports DNS over TLS MUST listen for
>    and accept TCP connections on port 853, unless it has mutual
>    agreement with its clients to use a port other than 853 for DNS over
>    TLS.
>
> So it is fully permissible for a DoT server to run on a different port
> under
> such a mutual agreement. In general, for other possible transports, just
> because
> a port is assigned for use does not mean a deployment is obligated to run
> on it.
>
>
> I agree. What we are trying to say is that we did not find it useful to
enable the use of a non standard port. This is a restriction of the DHCP
option - not the DNS over TLS.

> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> ## Comments
>
> ### IANA
>
> The IANA review of this document seems to not have concluded yet.
>
> I do see IANA Expert review OK on my side. I know we have had early
review, but I cannot say it is completed. I do not expect issues though
given the early reviews.


> ### Inclusive language
>
> Found terminology that should be reviewed for inclusivity; see
> https://www.rfc-editor.org/part2/#inclusive_language for background and
> more
> guidance:
>
>  * Term `her`; alternatives might be `they`, `them`, `their`
>
> ## Nits
>
> All comments below are about very minor potential issues that you may
> choose to
> address in some way - or ignore - as you see fit. Some were flagged by
> automated tools (via https://github.com/larseggert/ietf-reviewtool), so
> there
> will likely be some false positives. There is no need to let me know what
> you
> did with these suggestions.
>
> ### Typos
>
> #### Section 2, paragraph 3
> ```
> -    to.  ISPs may leverage such infrastructure and provide the homenet
> +    to.  ISPs may leverage such infrastructure and provide the home
> network
> +                                                                   +
>  ++++
> ```
>
> changed

> ### Outdated references
>
> Document references `draft-sury-dnsext-cname-dname-00`, but `-01` is the
> latest
> available revision.
>
> ### Grammar/style
>
> #### Paragraph 1
> ```
> s document defines DHCPv6 options so an Homenet Naming Authority (HNA) can
> a
>                                      ^^
> ```
> Use "a" instead of "an" if the following word doesn't start with a vowel
> sound,
> e.g. "a sentence", "a university".
>
> fixed

> #### Section 3, paragraph 4
> ```
> 6 options provide the necessary non optional parameters described in
> Appendi
>                                 ^^^^^^^^^^^^
> ```
> This expression is usually spelled with a hyphen.
>
> #### Section 4.3, paragraph 2
> ```
> represents a supported transport, and a RDM MAY indicate the support of
> multi
>                                       ^
> ```
> Use "an" instead of "a" if the following word starts with a vowel sound,
> e.g.
> "an article", "an hour".
>
> #### Section 4.3, paragraph 6
> ```
> FC8415] govern server operation in regards to option assignment. As a
> conveni
>                                 ^^^^^^^^^^^^^
> ```
> Use "in regard to", "with regard to", or more simply "regarding".
>
>  fixed

> #### "A.3.", paragraph 4
> ```
> cribed in Appendix A.2, the HNA is expect to be able to handle multiple
> Home
>                                    ^^^^^^
> ```
> Consider using either the past participle "expected" or the present
> participle
> "expecting" here.
>
>

> ## Notes
>
> This review is in the ["IETF Comments" Markdown format][ICMF], You can use
> the
> [`ietf-comments` tool][ICT] to automatically convert this review into
> individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].
>
> [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
> [ICT]: https://github.com/mnot/ietf-comments
> [IRT]: https://github.com/larseggert/ietf-reviewtool
>
>
>
> _______________________________________________
> homenet mailing list
> homenet@ietf.org
> https://www.ietf.org/mailman/listinfo/homenet
>


-- 
Daniel Migault
Ericsson