Re: [httpapi] [Last-Call] Genart last call review of draft-ietf-httpapi-link-template-02
Christer Holmberg <christer.holmberg@ericsson.com> Tue, 16 May 2023 12:43 UTC
Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: httpapi@ietfa.amsl.com
Delivered-To: httpapi@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 53AB0C151543; Tue, 16 May 2023 05:43:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pbAeXmE1_kMB; Tue, 16 May 2023 05:43:49 -0700 (PDT)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0610.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::610]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9B7DDC151535; Tue, 16 May 2023 05:43:48 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d0RTESZmco4gFmj0NssCKr3uLyc0y4BIUlkmXwAX9rGoj9qQBtGOrR7+5bMmKofklEMoqELWClsotpNPVLeDtjA8KsxrJfw3eefNZpuqBBqgI2wN2EA177nzEjv6zY1EsblC3SBvAtTk7Scms2GJNMqK0Tr3Ums83VaIu0qb4+lNTrc2i/zOdaImGKqSnMTDxahuWmYZ0j1i/YH2hSmhKFa+ujfT9M8jtzBUPldJOhzdJ5TNSVl14u6X4dG26pblmQVZYa2OpjgJ3XP9rx2m4rZedzqvxzeI4NovtQG/T+HqDHkswtal38f3lK/fLQRB9W6YLiujb9L3NOdEVpmyvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OWzsB3oSwau5fi+6aqyOlKsHd1c0zMQvfpMhTMd9nUs=; b=ZAYqz0GwWKZN20w4SZrsV/1WCU27tNQwUBeQsgY3Trr30wuCA44U/O9N+Ion70pd1UAuiSWV0eP+521RlyWv3oKuaYoYVewciF0yW4cvSJa3acDZZbTIbUluApK+Jwpt4ldnet07301KXHH4BgSbPnZ3kP3o0hyE0a5zvCsgvRw4Benz9IMuSyxr9eUnkzk9nIUN7LjZLuBKthWKMeHgWSHCOo5p2Dt0VVSKHJgH/ZzuBJ86OupwDYuHlxIqyNMkc9X72amIJ1HE7/l6jXl5ByGUnCwaKUcUIOXOi02SSA0K6w/SLAlttMhWXlAm9KHfsYmjDWij1dEAOnAnr8Sgxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OWzsB3oSwau5fi+6aqyOlKsHd1c0zMQvfpMhTMd9nUs=; b=Vqp6E5ysPx/hxrqDEk7tVMkVC2f8vdQxyvsTiY/rZk9OCchTeX+m5MEO/vMEqNrK4fVXYhL2lU6TY96Ks3a7EEb/T+IQ+ASUnHrY+wctxEkcFwIvx4YvtzAGKqbvpjoTtGRm0cuBIE/SZGdb+au5QO+M5zQAA2K75UzvJ3l/i8s=
Received: from HE1PR07MB4441.eurprd07.prod.outlook.com (2603:10a6:7:9f::27) by AS4PR07MB9658.eurprd07.prod.outlook.com (2603:10a6:20b:4fd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 12:43:44 +0000
Received: from HE1PR07MB4441.eurprd07.prod.outlook.com ([fe80::8542:2a28:6718:b1b4]) by HE1PR07MB4441.eurprd07.prod.outlook.com ([fe80::8542:2a28:6718:b1b4%7]) with mapi id 15.20.6387.030; Tue, 16 May 2023 12:43:44 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-httpapi-link-template.all@ietf.org" <draft-ietf-httpapi-link-template.all@ietf.org>, "httpapi@ietf.org" <httpapi@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: [Last-Call] Genart last call review of draft-ietf-httpapi-link-template-02
Thread-Index: AQHZh/NE9e+/FgjmekWZ3kvfM5BIAq9c17QQ
Date: Tue, 16 May 2023 12:43:44 +0000
Message-ID: <HE1PR07MB444106B218715CCBA383793593799@HE1PR07MB4441.eurprd07.prod.outlook.com>
References: <168424064858.44084.3692769234533396629@ietfa.amsl.com>
In-Reply-To: <168424064858.44084.3692769234533396629@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: HE1PR07MB4441:EE_|AS4PR07MB9658:EE_
x-ms-office365-filtering-correlation-id: 50887f9c-4804-41d7-bad9-08db560b2f48
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: FofGbLrlmvGHvIqGFmwQW867CYGNNAW6VsmxU79Fx/wMBXg4MYvHFRzlhVLxajfKhelRlWzxOXTVe6yNQisy89nX3Ak4CyrRSYhah+OHwILKCw2oaV7SXaKt1Zft+ZxCTbJjPiDxoXZNeW6z0O4K1up4szA4i37Gd25jUXq1ebnBRvRBAznEIWI7eOyhb+KWzBezDml4NJprLeNV2NgCmiOnnGOzy7mQShrbOoHWhPCvv0HZqYIPNozY39fSTeHSTnoSmddnCdSijo9o5l4Fb7kf1xhwRwJ5CpQgeQWKINf0GyrYGrNi2V451x2oMbHhj/KN3srAvM0Bo2KLDvJyMjlqL08BYedOrBLiL1TmtHVtqoo4GZRfGXCyVT+ZvNt60B0nwTUf8t8TEbyyAGPGXx/+WiLtP82i4aKTAUx039oqZrgjFh3x04G7iS55GhfvlJVfxc22dZ4m2TyYwtFsGyBfMXg48wNYJtBeIOxXn+otiOgKAvlFuLHYtaQAjH+WKPP6tBSjgySw0VIxnltNtlDA3CX3Fk6mk9xDu3cqwi1z4uyho18aNRHHrlyARQg+n13+AYn2NmYpNrfa7tB3Fyufxc2/AhPGPeA9IdxjRko=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR07MB4441.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(396003)(39860400002)(376002)(366004)(136003)(451199021)(6916009)(66446008)(64756008)(4326008)(71200400001)(8676002)(82960400001)(66476007)(66556008)(99936003)(316002)(76116006)(55016003)(41300700001)(478600001)(66946007)(450100002)(122000001)(54906003)(8936002)(38100700002)(6506007)(186003)(9686003)(38070700005)(2906002)(26005)(83380400001)(33656002)(86362001)(966005)(44832011)(7696005)(5660300002)(52536014); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 7XdvAimAmrAP/qBsLG9xExfIZ95NXmZtb2QTv9lVqzy+UaTJo0avYeJsBjd/hL7vb/uU9xrzffOXeNzx1hDeldeFk1qpoLPfhB5pD/noD7R5TJdwM5txZ29KKUIYCfubkkZ7N++63JdGgUOwSZ9bpznqkpn9mSvnesTmFh4WB8kTMzRZQoGPiuHjxQcpcf1mVkRFpV73pZMLHikaesnA8R+irKPkh2j0dktN1zo2dMO7e+uqIcZPFVQfT5yanI2chXEXPb3qvrqacWSHdVlq2GDaHrvt3bEzur6zHOpqUHR2nYKXAAp0bDF+NwBsZ022eqYkAcEj3XTMiucc7n6v5xlJMWN6HbiXHLANOouupgyCxjB+OiD4XTrV6LLplzuyME0UoS57loMusiHXhBduQ1TIZWiE09oz6yCUZgiBhLOvn3Mj/AkYgrr29KoTNOatbYs+GSVIDhaZKrT6vEx+qGV3Aks9sfDk3KUv9d8T1m2Mwk3qh+L6gPAU9T990JLO6Dj0ioiRWwT1nrKUE/413gGKxFDa0kNVZSZOkwdtaS2YWz1AnnY7yEPvS/R6A+6nvkC5QYsBOnThtEchx+dRh2KSIq3zRB6b71GKOJCdtDeHUcyvguN+o2/NT4iW22EKomLtZofAU62weeJ/4TEotGkQ8YhSds8Fl6YG8DZkLsOdMicMrnyJr+Wyp+v9MYN6OpoeAigJsk1avMrqFpW9sSdJse19n5JFoEFNiYZT3Rrx2E4e8iMEuxYCPWgmQ1bcpbPKN42/cAjWSDSt62v3To7aGrr+pBW8i3mz5ePW7rb0hXcYuRz5QCcPOsLSdhauAYihOODdwM79AAfaY6TjGAgQx769igZ3Nir1AL3atg+gdNBTmcGrhI3Ojs20sHmzDQlXeX0LenleTUawBuynoFy32CP04mk8Z1WE31U9Qm9w6f07w9KUxsV6gkQVfm46s1QpPmkqbgSy4hVvM5np71+i6S6hGHhBdCiKxJDbuws8ZwysLEjagcXjezgwhhXGyiak7obcir7prVJNayXOId3F92S1OHD0XE01NvZ6/NwfoUZO6EsdbOWnllL6l0/MQI49VOblt+bA+XLeBA3AYx6ESY3W62kPxR1dLhB80LIGQdLXwF7x1yCGo4IpiGuEyn+hyaiFANUn4AepUtn2q+Qcu7k4xfjHEZNqBfGYAT8HGlA/JP7oj8KUzwDOZhd+0ghcQkXp68ZNhywFc6cJc9HMxMznyJq04ScG34F1MF0fK5G4SMYMj39SbT2cvMfuTzhjMiCbDBEqnEL3ErNryg/GR6x2cuE471mJ9XA2Sz5/SFDPy+fvMLTRfuB9xXZMoZ8LKLXMBOeN4Yas7rvgJ3M+XPSb4lf9Oz50qhsLKfW++9twcQNGppg7/xNSNKiF7YPDorTgezlsNCG23/Af4mzH/houeGp0PlLDD4w0D02aBgSCyfcSXPwgbbK1QEEc9xkbvYpO7e8RUXR/a1hmjgU15fLYZSTAgKNpTWPAOmHME1PBa6A+qQ+wIu62hT6utU8pyGUsBO+i5u14D+lWeBTdFGaL5nVW+VfQdet+JfWRSNaAjuJLEe4pEtO+v+eHTXOgt97FQVlhU9dkUZqfsg==
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg="SHA1"; boundary="----=_NextPart_000_0111_01D9880D.31D44E90"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HE1PR07MB4441.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50887f9c-4804-41d7-bad9-08db560b2f48
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2023 12:43:44.0419 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rmvXPPUAULUDq/YpQyQMP+5ambNg9zOG0iqXNqxl4iowwtjHoy54azjwCGVtOIxOqsp4lxNE/atFRDc3h6kFf0YWK9EJ1PwFmUgrlsaTqIc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR07MB9658
Archived-At: <https://mailarchive.ietf.org/arch/msg/httpapi/p_8QrGzZYi0hT7eZZvt11Wzqyl4>
Subject: Re: [httpapi] [Last-Call] Genart last call review of draft-ietf-httpapi-link-template-02
X-BeenThere: httpapi@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Building Blocks for HTTP APIs <httpapi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/httpapi>, <mailto:httpapi-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/httpapi/>
List-Post: <mailto:httpapi@ietf.org>
List-Help: <mailto:httpapi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/httpapi>, <mailto:httpapi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 May 2023 12:43:53 -0000
Hi, In Q2_4, I note that the URIs have been replaced by fireeye URIs... Anyway, I assume the reader will know which example in the draft I am referring to :) Regards, Christer -----Original Message----- From: last-call <last-call-bounces@ietf.org> On Behalf Of Christer Holmberg via Datatracker Sent: Tuesday, 16 May 2023 15.37 To: gen-art@ietf.org Cc: draft-ietf-httpapi-link-template.all@ietf.org; httpapi@ietf.org; last-call@ietf.org Subject: [Last-Call] Genart last call review of draft-ietf-httpapi-link-template-02 Reviewer: Christer Holmberg Review result: Ready with Issues I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. Document: draft-ietf-httpapi-link-template-12 Reviewer: Christer Holmberg Review Date: 2023-05-16 IETF LC End Date: 2023-05-29 IESG Telechat date: Not scheduled for a telechat Summary: The document is well written and easy to read. However, there are some issues and editorial nits that I would like the authors to address. Major issues: Section 2: ========== Q2_1: There is no ABNF for the header field. There are examples using both quotes ("/{username}") and angle brackets (</books/{book_id}/author>), so please include the ABNF. --- Q2_2: The text says "Parameter values MUST be Strings." It is unclear what "Strings" means. Does it mean that parameter values must be encoded as quoted-strings? If so, why? RFC8288 says that parameter values can be encoded both as token and quoted-string. --- Minor issues: N/A Nits/editorial comments: Section 2: ========== Q2_3: The text says: Link-Template: </books/{book_id}/author>; rel="author" anchor="#{book_id}" Is there a ";" missing between the rel and anchor parameters? --- Q2_4: The text says: Link-Template: "/widgets/{widget_id}" rel="https://protect2.fireeye.com/v1/url?k=31323334-501d5122-313273af-454445555731-8682063e6d15ae87&q=1&e=95c5bf1c-a087-4c32-8166-dbfbf8b8d0d8&u=https%3A%2F%2Fexample.org%2Frel%2Fwidget"; var-base="https://protect2.fireeye.com/v1/url?k=31323334-501d5122-313273af-454445555731-1500fdce5a713cb0&q=1&e=95c5bf1c-a087-4c32-8166-dbfbf8b8d0d8&u=https%3A%2F%2Fexample.org%2Fvars%2F" Is there a ";" missing at the end of the first line? --- -- last-call mailing list last-call@ietf.org https://www.ietf.org/mailman/listinfo/last-call
- [httpapi] Genart last call review of draft-ietf-h… Christer Holmberg via Datatracker
- Re: [httpapi] [Last-Call] Genart last call review… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Mark Nottingham
- Re: [httpapi] Genart last call review of draft-ie… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Mark Nottingham
- Re: [httpapi] Genart last call review of draft-ie… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Mark Nottingham
- Re: [httpapi] Genart last call review of draft-ie… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Mark Nottingham
- Re: [httpapi] Genart last call review of draft-ie… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Julian Reschke
- Re: [httpapi] Genart last call review of draft-ie… Mark Nottingham