[httpapi] Genart last call review of draft-ietf-httpapi-link-template-02
Christer Holmberg via Datatracker <noreply@ietf.org> Tue, 16 May 2023 12:37 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: httpapi@ietf.org
Delivered-To: httpapi@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 9137AC151556; Tue, 16 May 2023 05:37:28 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Christer Holmberg via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-httpapi-link-template.all@ietf.org, httpapi@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 10.3.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <168424064858.44084.3692769234533396629@ietfa.amsl.com>
Reply-To: Christer Holmberg <christer.holmberg@ericsson.com>
Date: Tue, 16 May 2023 05:37:28 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/httpapi/zNXuT-vyACzTXAcxCyqUP00cb-A>
Subject: [httpapi] Genart last call review of draft-ietf-httpapi-link-template-02
X-BeenThere: httpapi@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Building Blocks for HTTP APIs <httpapi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/httpapi>, <mailto:httpapi-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/httpapi/>
List-Post: <mailto:httpapi@ietf.org>
List-Help: <mailto:httpapi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/httpapi>, <mailto:httpapi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 May 2023 12:37:28 -0000
Reviewer: Christer Holmberg Review result: Ready with Issues I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. Document: draft-ietf-httpapi-link-template-12 Reviewer: Christer Holmberg Review Date: 2023-05-16 IETF LC End Date: 2023-05-29 IESG Telechat date: Not scheduled for a telechat Summary: The document is well written and easy to read. However, there are some issues and editorial nits that I would like the authors to address. Major issues: Section 2: ========== Q2_1: There is no ABNF for the header field. There are examples using both quotes ("/{username}") and angle brackets (</books/{book_id}/author>), so please include the ABNF. --- Q2_2: The text says "Parameter values MUST be Strings." It is unclear what "Strings" means. Does it mean that parameter values must be encoded as quoted-strings? If so, why? RFC8288 says that parameter values can be encoded both as token and quoted-string. --- Minor issues: N/A Nits/editorial comments: Section 2: ========== Q2_3: The text says: Link-Template: </books/{book_id}/author>; rel="author" anchor="#{book_id}" Is there a ";" missing between the rel and anchor parameters? --- Q2_4: The text says: Link-Template: "/widgets/{widget_id}" rel="https://example.org/rel/widget"; var-base="https://example.org/vars/" Is there a ";" missing at the end of the first line? ---
- [httpapi] Genart last call review of draft-ietf-h… Christer Holmberg via Datatracker
- Re: [httpapi] [Last-Call] Genart last call review… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Mark Nottingham
- Re: [httpapi] Genart last call review of draft-ie… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Mark Nottingham
- Re: [httpapi] Genart last call review of draft-ie… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Mark Nottingham
- Re: [httpapi] Genart last call review of draft-ie… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Mark Nottingham
- Re: [httpapi] Genart last call review of draft-ie… Christer Holmberg
- Re: [httpapi] Genart last call review of draft-ie… Julian Reschke
- Re: [httpapi] Genart last call review of draft-ie… Mark Nottingham