Re: Nits and suggestions for draft-kazuho-h2-cache-digest

Mark Nottingham <mnot@mnot.net> Tue, 31 May 2016 07:32 UTC

Return-Path: <ietf-http-wg-request+bounce-httpbisa-archive-bis2juki=lists.ie@listhub.w3.org>
X-Original-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Delivered-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C4C1312D11B for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Tue, 31 May 2016 00:32:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.347
X-Spam-Level:
X-Spam-Status: No, score=-8.347 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7vaSf-lQsbyO for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Tue, 31 May 2016 00:32:44 -0700 (PDT)
Received: from frink.w3.org (frink.w3.org [128.30.52.56]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F216D12B008 for <httpbisa-archive-bis2Juki@lists.ietf.org>; Tue, 31 May 2016 00:32:43 -0700 (PDT)
Received: from lists by frink.w3.org with local (Exim 4.80) (envelope-from <ietf-http-wg-request@listhub.w3.org>) id 1b7e6E-000188-FW for ietf-http-wg-dist@listhub.w3.org; Tue, 31 May 2016 07:28:26 +0000
Resent-Date: Tue, 31 May 2016 07:28:26 +0000
Resent-Message-Id: <E1b7e6E-000188-FW@frink.w3.org>
Received: from maggie.w3.org ([128.30.52.39]) by frink.w3.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from <mnot@mnot.net>) id 1b7e69-00017E-Ko for ietf-http-wg@listhub.w3.org; Tue, 31 May 2016 07:28:21 +0000
Received: from mxout-07.mxes.net ([216.86.168.182]) by maggie.w3.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from <mnot@mnot.net>) id 1b7e67-00022d-Ud for ietf-http-wg@w3.org; Tue, 31 May 2016 07:28:21 +0000
Received: from [192.168.1.101] (unknown [120.149.194.112]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.mxes.net (Postfix) with ESMTPSA id 1D7A222E1F3; Tue, 31 May 2016 03:27:54 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Mark Nottingham <mnot@mnot.net>
In-Reply-To: <CANatvzziDCY1CyJTaTTF=4isLDUC8f6vupuKES9TF3T-z3y87w@mail.gmail.com>
Date: Tue, 31 May 2016 17:27:52 +1000
Cc: Martin Thomson <martin.thomson@gmail.com>, HTTP Working Group <ietf-http-wg@w3.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <14E1C048-BF2B-4D87-A09D-518B5C6FFE66@mnot.net>
References: <CABkgnnX38oLEgZRxzL4OzfZX5u5haU_Q7eka5iewqnTge20_vg@mail.gmail.com> <974C0CB0-69C9-4085-A280-27367692DEAB@mnot.net> <CANatvzziDCY1CyJTaTTF=4isLDUC8f6vupuKES9TF3T-z3y87w@mail.gmail.com>
To: Kazuho Oku <kazuhooku@gmail.com>
X-Mailer: Apple Mail (2.3124)
Received-SPF: pass client-ip=216.86.168.182; envelope-from=mnot@mnot.net; helo=mxout-07.mxes.net
X-W3C-Hub-Spam-Status: No, score=-8.2
X-W3C-Hub-Spam-Report: AWL=1.357, BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, W3C_AA=-1, W3C_DB=-1, W3C_IRA=-1, W3C_IRR=-3, W3C_WL=-1
X-W3C-Scan-Sig: maggie.w3.org 1b7e67-00022d-Ud 969c471f7eb409ff02774a9fc614c804
X-Original-To: ietf-http-wg@w3.org
Subject: Re: Nits and suggestions for draft-kazuho-h2-cache-digest
Archived-At: <http://www.w3.org/mid/14E1C048-BF2B-4D87-A09D-518B5C6FFE66@mnot.net>
Resent-From: ietf-http-wg@w3.org
X-Mailing-List: <ietf-http-wg@w3.org> archive/latest/31677
X-Loop: ietf-http-wg@w3.org
Resent-Sender: ietf-http-wg-request@w3.org
Precedence: list
List-Id: <ietf-http-wg.w3.org>
List-Help: <http://www.w3.org/Mail/>
List-Post: <mailto:ietf-http-wg@w3.org>
List-Unsubscribe: <mailto:ietf-http-wg-request@w3.org?subject=unsubscribe>

Done:
  https://github.com/mnot/I-D/commit/b2761011291677b

> On 31 May 2016, at 5:12 PM, Kazuho Oku <kazuhooku@gmail.com> wrote:
> 
> 2016-05-31 14:24 GMT+09:00 Mark Nottingham <mnot@mnot.net>:
>> 
>>> On 15 May 2016, at 1:43 AM, Martin Thomson <martin.thomson@gmail.com> wrote:
>>> 
>>>> From small to large:
>>> 
>>> Nit:
>>>      2.  If "W" and "V" are equal, continue to the next "V".
>>> 
>>> This should be next "W", I think.
>> 
>> There is no next W...
>> 
>> 
>>> I think that Q would be better encoded as a series of 0 bits followed
>>> by a 1 bit.  The reason I say that is that it is (marginally) easier
>>> to generate the values then by masking in the R value in the right
>>> place in a freshly calloc'd piece of memory.
>> 
>> I'm not fussed; Kazuho?
> 
> I do not mind either way, so it might be better to change it now.
> 
>> 
>>> This document really needs to describe what the contents of the cache
>>> digest are, and to describe how to decode the cache digest.  Without
>>> defining what it means to receive and decode this information, this
>>> specification almost says nothing at all.
>> 
>> Whatever happened to "left as an exercise to the reader?"
>> 
>> :)
>> 
>> Yes, we do.
>> 
>> Cheers,
>> 
>> 
>> --
>> Mark Nottingham   https://www.mnot.net/
>> 
> 
> 
> 
> -- 
> Kazuho Oku

--
Mark Nottingham   https://www.mnot.net/