Nits and suggestions for draft-kazuho-h2-cache-digest

Martin Thomson <martin.thomson@gmail.com> Sat, 14 May 2016 15:48 UTC

Return-Path: <ietf-http-wg-request+bounce-httpbisa-archive-bis2juki=lists.ie@listhub.w3.org>
X-Original-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Delivered-To: ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 847F712D182 for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Sat, 14 May 2016 08:48:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.336
X-Spam-Level:
X-Spam-Status: No, score=-6.336 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, DKIM_SIGNED=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_DKIM_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (2048-bit key) reason="fail (body has been altered)" header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gB9PYG35xvwL for <ietfarch-httpbisa-archive-bis2Juki@ietfa.amsl.com>; Sat, 14 May 2016 08:48:50 -0700 (PDT)
Received: from frink.w3.org (frink.w3.org [128.30.52.56]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9426B12D143 for <httpbisa-archive-bis2Juki@lists.ietf.org>; Sat, 14 May 2016 08:48:50 -0700 (PDT)
Received: from lists by frink.w3.org with local (Exim 4.80) (envelope-from <ietf-http-wg-request@listhub.w3.org>) id 1b1bjt-0002jq-0a for ietf-http-wg-dist@listhub.w3.org; Sat, 14 May 2016 15:44:25 +0000
Resent-Date: Sat, 14 May 2016 15:44:25 +0000
Resent-Message-Id: <E1b1bjt-0002jq-0a@frink.w3.org>
Received: from lisa.w3.org ([128.30.52.41]) by frink.w3.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from <martin.thomson@gmail.com>) id 1b1bjm-0002j5-9r for ietf-http-wg@listhub.w3.org; Sat, 14 May 2016 15:44:18 +0000
Received: from mail-io0-f177.google.com ([209.85.223.177]) by lisa.w3.org with esmtps (TLS1.2:RSA_ARCFOUR_SHA1:128) (Exim 4.80) (envelope-from <martin.thomson@gmail.com>) id 1b1bjl-0001XY-2s for ietf-http-wg@w3.org; Sat, 14 May 2016 15:44:17 +0000
Received: by mail-io0-f177.google.com with SMTP id d62so165996237iof.2 for <ietf-http-wg@w3.org>; Sat, 14 May 2016 08:43:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to; bh=/4R0X4y3jcwwIl/U9oWS2QMoWwPo9+zYCZNOV1Tbe/Y=; b=YvvggmWtnhazEQdVXilMkNfqw8IAUCGmagRSBCElV4BRWwT+hltB8OwBvrDbvVPS+z JLXyd1QNxho/TE8rFWUVXmVeMUyPclCZ/p2arzVWoEIOHUEqlb1EJo4xGpS9KcgiEWvK 1SvWCUk+/RD/bT4vrxyrsL1wmT5J8zLbaYPV+S3nvYH0Gz6OdY7mwKm2QbtOTV08bAZ2 cf3DBPYDcyYpgHsusqfVgeemvnG7EanyT3pTBVkFbE4ib8fDwwus4zVQbi3L31Eb/dzZ MGZn6gLxYSUvr00Kip1YpzOSkUa6/SMDQcldTi+vMciyklbz0p0JhsY2HnwOQ15xBZN2 /bew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=/4R0X4y3jcwwIl/U9oWS2QMoWwPo9+zYCZNOV1Tbe/Y=; b=Ph09YaJyO1nLTJ2xaBuB4mB7+90N0cLo1JwpuLHZT/WpLVC3IkC9nqn3EYenUKnvA8 w1THPdAfrDZmKpEk/+jiVTumjadi0paD+ldThWpuSO5CTKE1890k7Z3NgX/ySrj6RmYY ikXA6pNcWRiFiYUY6uLjYE4Rv5mQHXCBkbqSPKudi+BQD2dH81qmAHnl6oEw5xbOicIa JtqbiYZqi8y92Um1EBRoZAoc51pOw4T2YynVEvMVq2wHy/aAv2w/8yCP1HZYyMRb4isu I2zs18aEVTziFB+TzvyRBdIg9Z5Dv2BqlKeZBH1dnKIMMdLbeMtv2Dk+Sa3MreRYBmYn gVog==
X-Gm-Message-State: AOPr4FWrgKN3otzcBkee7zHZzZJYv2T7Ux4NjSRIfPVYQpLXCCE5cm0jRpwlF15je8BZ1TPCSJFyXFYcVKNN/A==
MIME-Version: 1.0
X-Received: by 10.107.161.195 with SMTP id k186mr1566975ioe.190.1463240631319; Sat, 14 May 2016 08:43:51 -0700 (PDT)
Received: by 10.36.43.82 with HTTP; Sat, 14 May 2016 08:43:51 -0700 (PDT)
Date: Sun, 15 May 2016 01:43:51 +1000
Message-ID: <CABkgnnX38oLEgZRxzL4OzfZX5u5haU_Q7eka5iewqnTge20_vg@mail.gmail.com>
From: Martin Thomson <martin.thomson@gmail.com>
To: HTTP Working Group <ietf-http-wg@w3.org>
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=209.85.223.177; envelope-from=martin.thomson@gmail.com; helo=mail-io0-f177.google.com
X-W3C-Hub-Spam-Status: No, score=-6.9
X-W3C-Hub-Spam-Report: AWL=0.884, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, W3C_AA=-1, W3C_DB=-1, W3C_IRA=-1, W3C_IRR=-3, W3C_WL=-1
X-W3C-Scan-Sig: lisa.w3.org 1b1bjl-0001XY-2s 18f65d462548bfef41011f7f9ca1d36b
X-Original-To: ietf-http-wg@w3.org
Subject: Nits and suggestions for draft-kazuho-h2-cache-digest
Archived-At: <http://www.w3.org/mid/CABkgnnX38oLEgZRxzL4OzfZX5u5haU_Q7eka5iewqnTge20_vg@mail.gmail.com>
Resent-From: ietf-http-wg@w3.org
X-Mailing-List: <ietf-http-wg@w3.org> archive/latest/31645
X-Loop: ietf-http-wg@w3.org
Resent-Sender: ietf-http-wg-request@w3.org
Precedence: list
List-Id: <ietf-http-wg.w3.org>
List-Help: <http://www.w3.org/Mail/>
List-Post: <mailto:ietf-http-wg@w3.org>
List-Unsubscribe: <mailto:ietf-http-wg-request@w3.org?subject=unsubscribe>

>From small to large:

Nit:
       2.  If "W" and "V" are equal, continue to the next "V".

This should be next "W", I think.

I think that Q would be better encoded as a series of 0 bits followed
by a 1 bit.  The reason I say that is that it is (marginally) easier
to generate the values then by masking in the R value in the right
place in a freshly calloc'd piece of memory.

This document really needs to describe what the contents of the cache
digest are, and to describe how to decode the cache digest.  Without
defining what it means to receive and decode this information, this
specification almost says nothing at all.