Re: [i2rs] I-D Action: draft-ietf-i2rs-yang-l2-network-topology-09.txt

Qin Wu <> Mon, 26 August 2019 12:54 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id C9F7F1200B3 for <>; Mon, 26 Aug 2019 05:54:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id l01Pvf-HVY5p for <>; Mon, 26 Aug 2019 05:54:53 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 24B2E12004C for <>; Mon, 26 Aug 2019 05:54:53 -0700 (PDT)
Received: from (unknown []) by Forcepoint Email with ESMTP id D65CDAC8B3BB5AD37529 for <>; Mon, 26 Aug 2019 13:54:50 +0100 (IST)
Received: from ( by ( with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 26 Aug 2019 13:54:50 +0100
Received: from ([]) by ([fe80::74d9:c659:fbec:21fa%31]) with mapi id 14.03.0439.000; Mon, 26 Aug 2019 20:51:44 +0800
From: Qin Wu <>
To: tom petch <>, "" <>
CC: Susan Hares <>
Thread-Topic: I-D Action: draft-ietf-i2rs-yang-l2-network-topology-09.txt
Thread-Index: AdVcDEDRqqVTTZmoTwqpxkMvlt8trg==
Date: Mon, 26 Aug 2019 12:51:43 +0000
Message-ID: <>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
x-originating-ip: []
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <>
Subject: Re: [i2rs] I-D Action: draft-ietf-i2rs-yang-l2-network-topology-09.txt
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Mon, 26 Aug 2019 12:54:56 -0000

Thanks Tom for follow up comments, please see my reply inline below.
发件人: tom petch [] 
发送时间: 2019年8月24日 0:39
收件人: Qin Wu <>;
抄送: Susan Hares <>
主题: Re: I-D Action: draft-ietf-i2rs-yang-l2-network-topology-09.txt


I said that I might look some more and I have.

I still think that you need references for 802.1ad and 802.1ah.  It is not a question of whether or not they are imported, it is where does the reader go to find out more about e.g. QinQ and that needs nailing down to a specific document, and in the case of the IEEE, that needs a date, as you give for 802.1Q.

Talking of which, I find that Rob imports that IEEE module from a different document; 802.1Qcp; um.

[Qin]: Okay, will add all these IEEE related references.
And, in the same vein, I would like a reference for LLDP.

[Qin]:I think it is IEEE 802.1AB and will add.
[Qin]: Thanks.
leaf rate
what are the units?
[Qin]: We select Mbps as units and will add.

        leaf maximum-frame-size {
what is a frame, what headers are included and what not?  This is a fraught topic

[Qin]: It is layer 2 frame, it could be Ethernet frame, it could be PPP frame, they are all layer 2 frame.

/ternimation point/termination point/

[Qin]: Fixed, thanks.
     leaf vlan-name {
any constraints on length or character set?  I like them although am conscious that some YANG doctors do not.
[Qin]:Good point, the constraint is 32 characters and will length constraint, thanks.
     leaf encapsulation {
the description exceeds the permissible line length for an RFC
[Qin]:Fixed, thanks.
          type enumeration {
            enum in-use {
             value 0;
again a personal preference - I like to see zero kept for a special purpose (e.g. cannot be determined) unless there is a strong reason to use it (e.g. it is what the protocol has been using for years)
[Qin]:Good, I will skip value 0, thanks!

Tom Petch

----- Original Message -----
From: "Qin Wu" <>
Sent: Monday, August 19, 2019 8:08 AM

> v-09 is posted to address Tom's comments.
> The diff is:
> Becuase datatracker pyang integration tool issue, Data model
"ieee802-dot1q-types" can not been found
> And imported into the model defined in this draft.
> -Qin
> -----邮件原件-----
> 发件人: I-D-Announce [] 代表
> 发送时间: 2019年8月19日 15:04
> 收件人:
> 抄送:
> 主题: I-D Action: draft-ietf-i2rs-yang-l2-network-topology-09.txt
> A New Internet-Draft is available from the on-line Internet-Drafts
> This draft is a work item of the Interface to the Routing System WG of
the IETF.
>         Title           : A YANG Data Model for Layer-2 Network
>         Authors         : Jie Dong
>                           Xiugang Wei
>                           Qin Wu
>                           Mohamed Boucadair
>                           Anders Liu
> Filename        : draft-ietf-i2rs-yang-l2-network-topology-09.txt
> Pages           : 31
> Date            : 2019-08-19
> Abstract:
>    This document defines a YANG data model for Layer 2 network
>    topologies.
> Editorial Note (To be removed by RFC Editor)
>    Please update these statements within the document with the RFC
>    number to be assigned to this document:
>    o  "This version of this YANG module is part of RFC XXXX;"
>    o  "RFC XXXX: A YANG Data Model for Layer-2 Network Topologies";
>    o  reference: RFC XXXX
>    Please update the "revision" date of the YANG module.
> The IETF datatracker status page for this draft is:
> There are also htmlized versions available at:
> A diff from the previous version is available at:
> Please note that it may take a couple of minutes from the time of
submission until the htmlized version and diff are available at
> Internet-Drafts are also available by anonymous FTP at:
> _______________________________________________
> I-D-Announce mailing list
> Internet-Draft directories: or