Re: [i2rs] I-D Action: draft-ietf-i2rs-yang-l2-network-topology-09.txt

["Rob Wilton (rwilton)" <[e-mail]>]

Hi Tom,

Please see inline ...

> -----Original Message-----
> From: i2rs <[e-mail]> On Behalf Of tom petch
> Sent: 23 August 2019 17:39
> To: Qin Wu <[e-mail]>; [e-mail]
> Cc: Susan Hares <[e-mail]>
> Subject: Re: [i2rs] I-D Action: draft-ietf-i2rs-yang-l2-network-topology-
> 09.txt
> 
> Qin
> 
> I said that I might look some more and I have.
> 
> I still think that you need references for 802.1ad and 802.1ah.  It is not
> a question of whether or not they are imported, it is where does the
> reader go to find out more about e.g. QinQ and that needs nailing down to
> a specific document, and in the case of the IEEE, that needs a date, as
> you give for 802.1Q.
> 
> Talking of which, I find that Rob imports that IEEE module from a
> different document; 802.1Qcp; um.
[RW] 
802.1Qcp (https://standards.ieee.org/standard/802_1Qcp-2018.html) is the amendment to 802.1Q-2018 (https://standards.ieee.org/standard/802_1Q-2018.html) that defines some bridging YANG models and the ieee802-dot1q-types.yang YANG models.

I've emailed the relevant folks at IEEE to ask what the correct reference is, and then presumably we can be consistent for all RFCs.

Thanks,
Rob


> 
> And, in the same vein, I would like a reference for LLDP.
> 
> /defned/defined/
> 
> leaf rate
> what are the units?
> 
>         leaf maximum-frame-size {
> what is a frame, what headers are included and what not?  This is a
> fraught topic
> 
> /ternimation point/termination point/
> 
>      leaf vlan-name {
> any constraints on length or character set?  I like them although am
> conscious that some YANG doctors do not.
> 
>      leaf encapsulation {
> the description exceeds the permissible line length for an RFC
> 
>           type enumeration {
>             enum in-use {
>              value 0;
> again a personal preference - I like to see zero kept for a special
> purpose (e.g. cannot be determined) unless there is a strong reason to use
> it (e.g. it is what the protocol has been using for years)
> 
> Tom Petch
> 
> ----- Original Message -----
> From: "Qin Wu" <[e-mail]>
> Sent: Monday, August 19, 2019 8:08 AM
> 
> > v-09 is posted to address Tom's comments.
> > The diff is:
> >
> https://www.ietf.org/rfcdiff?url2=draft-ietf-i2rs-yang-l2-network-topolo
> gy-09
> > Becuase datatracker pyang integration tool issue, Data model
> "ieee802-dot1q-types" can not been found
> > And imported into the model defined in this draft.
> >
> > -Qin
> > -----邮件原件-----
> > 发件人: I-D-Announce [mailto:[e-mail]] 代表
> [e-mail]
> > 发送时间: 2019年8月19日 15:04
> > 收件人: [e-mail]
> > 抄送: [e-mail]
> > 主题: I-D Action: draft-ietf-i2rs-yang-l2-network-topology-09.txt
> >
> >
> > A New Internet-Draft is available from the on-line Internet-Drafts
> directories.
> > This draft is a work item of the Interface to the Routing System WG of
> the IETF.
> >
> >         Title           : A YANG Data Model for Layer-2 Network
> Topologies
> >         Authors         : Jie Dong
> >                           Xiugang Wei
> >                           Qin Wu
> >                           Mohamed Boucadair
> >                           Anders Liu
> > Filename        : draft-ietf-i2rs-yang-l2-network-topology-09.txt
> > Pages           : 31
> > Date            : 2019-08-19
> >
> > Abstract:
> >    This document defines a YANG data model for Layer 2 network
> >    topologies.
> >
> > Editorial Note (To be removed by RFC Editor)
> >
> >    Please update these statements within the document with the RFC
> >    number to be assigned to this document:
> >
> >    o  "This version of this YANG module is part of RFC XXXX;"
> >
> >    o  "RFC XXXX: A YANG Data Model for Layer-2 Network Topologies";
> >
> >    o  reference: RFC XXXX
> >
> >    Please update the "revision" date of the YANG module.
> >
> >
> > The IETF datatracker status page for this draft is:
> >
> https://datatracker.ietf.org/doc/draft-ietf-i2rs-yang-l2-network-topolog
> y/
> >
> > There are also htmlized versions available at:
> >
> https://tools.ietf.org/html/draft-ietf-i2rs-yang-l2-network-topology-09
> >
> https://datatracker.ietf.org/doc/html/draft-ietf-i2rs-yang-l2-network-to
> pology-09
> >
> > A diff from the previous version is available at:
> >
> https://www.ietf.org/rfcdiff?url2=draft-ietf-i2rs-yang-l2-network-topolo
> gy-09
> >
> >
> > Please note that it may take a couple of minutes from the time of
> submission until the htmlized version and diff are available at
> tools.ietf.org.
> >
> > Internet-Drafts are also available by anonymous FTP at:
> > ftp://ftp.ietf.org/internet-drafts/
> >
> > _______________________________________________
> > I-D-Announce mailing list
> > [e-mail]
> > https://www.ietf.org/mailman/listinfo/i-d-announce
> > Internet-Draft directories: http://www.ietf.org/shadow.html or
> ftp://ftp.ietf.org/ietf/1shadow-sites.txt
> >
> 
> _______________________________________________
> i2rs mailing list
> [e-mail]
> https://www.ietf.org/mailman/listinfo/i2rs