Re: [Ice] Éric Vyncke's No Objection on draft-ietf-ice-pac-04: (with COMMENT)

Justin Uberti <justin@uberti.name> Tue, 28 April 2020 01:38 UTC

Return-Path: <juberti@gmail.com>
X-Original-To: ice@ietfa.amsl.com
Delivered-To: ice@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5AAD73A08B0; Mon, 27 Apr 2020 18:38:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.217
X-Spam-Level:
X-Spam-Status: No, score=-2.217 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.82, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 14_EVJb4UZPM; Mon, 27 Apr 2020 18:38:29 -0700 (PDT)
Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 42C823A0893; Mon, 27 Apr 2020 18:38:29 -0700 (PDT)
Received: by mail-lf1-f46.google.com with SMTP id w145so15518314lff.3; Mon, 27 Apr 2020 18:38:29 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p78TaqaIeFKzuXw5wUVfYsMSHbN5+NyoEoT9nOSECTg=; b=GXXQSlqqfU9JdAxJFgwo8AcOMWPWs6jo22jxRW9iDR7wtEu7PPaH7ohTsBylxTPC7W J5RB8Tq0JlGEnDJbHx/1EJj4i41C5ANV1gQR/gqJDweI0Iome3Gbd8AFxrN28ye5+Lwf V+a5WhFVTjq72BRhHKswM/NXFRVFcsw9Acmp7JzgRXm4BCOlEEmmyfchyjhtSdaSoMlC R0FWIP6YZSEoSe1t4pg39jpX1ZrPf8PW5s7hLCYx450DjYJouttUlZZvVzA2Br7qKAdY HD2O53C9bwUu0DpOfy6emeSEHrCTrPkLmzGOU7HIHAz8WjtIKOmloYhAUNW3CV6POobX k+7A==
X-Gm-Message-State: AGi0PuasSHEgb6imc4cyT5FGjRpDHRh5lfLmMraGsuA/0Ow/N1jwdn8u jqiyPOeKAjpcdxEdAX8aOhxHsz1kKxQ1Tbf7gJ4=
X-Google-Smtp-Source: APiQypLS/lkjQlTCA2A0rI3jHVY4NjX5X0w+9NozntTGoKWtiOXMdXbK0o3FgnBd6dnvFa8FbWwPll5O6sMjEO9IKYQ=
X-Received: by 2002:a19:4a03:: with SMTP id x3mr17357170lfa.159.1588037907190; Mon, 27 Apr 2020 18:38:27 -0700 (PDT)
MIME-Version: 1.0
References: <158747937967.30818.11917169559141666632@ietfa.amsl.com> <79EF9BAD-FA0C-4019-AF2C-A3A8FFC988A4@ericsson.com> <1387C0B3-1693-4A8D-83A0-0F93B99A407C@cisco.com> <44A1FCA8-0405-49D2-8589-45D1C9CBFAF4@ericsson.com>
In-Reply-To: <44A1FCA8-0405-49D2-8589-45D1C9CBFAF4@ericsson.com>
From: Justin Uberti <justin@uberti.name>
Date: Mon, 27 Apr 2020 18:38:11 -0700
Message-ID: <CALe60zC3pKqM-H1Grrbgt1hEKwma6UHHpgKi0FR2p+jmLq3VHQ@mail.gmail.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
Cc: "Eric Vyncke (evyncke)" <evyncke@cisco.com>, The IESG <iesg@ietf.org>, "draft-ietf-ice-pac@ietf.org" <draft-ietf-ice-pac@ietf.org>, "ice-chairs@ietf.org" <ice-chairs@ietf.org>, "ice@ietf.org" <ice@ietf.org>, Nils Ohlmeier <nohlmeier@mozilla.com>
Content-Type: multipart/alternative; boundary="000000000000591c2005a44fe398"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ice/I2o-bIf35kBoRVbJJwzFIpjjojo>
Subject: Re: [Ice] Éric Vyncke's No Objection on draft-ietf-ice-pac-04: (with COMMENT)
X-BeenThere: ice@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Interactive Connectivity Establishment \(ICE\)" <ice.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ice>, <mailto:ice-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ice/>
List-Post: <mailto:ice@ietf.org>
List-Help: <mailto:ice-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ice>, <mailto:ice-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2020 01:38:32 -0000

I looked into this a bit more closely and I tend to agree that 'race
condition' isn't the ideal term here, because most of the listed situations
(3.1, 3.2) are not timing-specific. Here's my simple suggestion:

OLD:
        However, there is an inherent race condition
        here; if, before learning about any peer-reflexive candidates, an
        endpoint runs out of candidate pairs to check, either because it has
        none, or it considers them all to have failed, it will prematurely
        declare failure and terminate ICE processing. This race condition
can
        occur in many common situations.

NEW:
        However, there is an inherent *problem*
        here; if, before learning about any peer-reflexive candidates, an
        endpoint runs out of candidate pairs to check, either because it has
        none, or it considers them all to have failed, it will prematurely
        declare failure and terminate ICE processing. This *problem* can
        occur in many common situations.



On Tue, Apr 21, 2020 at 2:45 PM Christer Holmberg <
christer.holmberg@ericsson.com> wrote:

> Hi Éric,
>
> Thanks for your comments! Unless Justin says it's not a race condition,
> I'll keep it :)
>
> Regards,
>
> Christer
>
> On 21/04/2020, 22.24, "Eric Vyncke (evyncke)" <evyncke@cisco.com> wrote:
>
>     Hello Christer,
>
>     Thank you for the explanation about the update of a document still
> "blocked" in the RFC editor queue. Up to you and your responsible AD.
>
>     Even after Barry's kind explanations about "race conditions" (in
> French "conditions de course" :-) ...), I feel that this does not apply to
> this document (cfr use case in section 3.1) but I really do not mind. Just
> wanted to raise a flag.
>
>     Regards and thank you for your document
>
>     -éric
>
>     -----Original Message-----
>     From: Christer Holmberg <christer.holmberg@ericsson.com>
>     Date: Tuesday, 21 April 2020 at 18:29
>     To: Eric Vyncke <evyncke@cisco.com>, The IESG <iesg@ietf.org>
>     Cc: "draft-ietf-ice-pac@ietf.org" <draft-ietf-ice-pac@ietf.org>, "
> ice-chairs@ietf.org" <ice-chairs@ietf.org>, "ice@ietf.org" <ice@ietf.org>,
> Nils Ohlmeier <nohlmeier@mozilla.com>
>     Subject: Re: Éric Vyncke's No Objection on draft-ietf-ice-pac-04:
> (with COMMENT)
>
>         Hi Éric,
>
>         Thank You for the review! Please see inline.
>
>
> ----------------------------------------------------------------------
>             COMMENT:
>
> ----------------------------------------------------------------------
>
>             > Thank you for this short and easy to read document.
>             >
>             > But, I cannot refrain from wondering about this part as the
> trickle-ice I-D is
>             > still in RFC editor queue => easier to fix it in the body of
> the trickle-ice
>             > IMHO (could be wrong): "[RFC EDITOR NOTE: Please replace RFC
> XXXX with the RFC
>             > number of draft-ietf-ice-trickle once it has been
> published.  Please also
>             >   indicate that this specification updates RFC XXXX.]"
>
>         Originally we assumed that trickle-ice was going to be published
> before ice-pac. The reason trickle-ice has been on hold in the RFC editor
> queue is because it is part of the Cluster 238 collection of drafts, which
> all are intended to be published at the same time.
>
>         Having said that, we think it is more clear to fix both RFC 8445
> and trickle-ice in the same place (this draft). Much of the content is
> describing the problems, and making the trickle update in trickle-ice would
> mean that we would have to copy/paste most of the text there.
>
>             > I also wonder why section 1 talks about 'race conditions'
> while the issue is
>             > related to a too short default time-out or in the use cases
> of section 3. (in
>             > my mind, 'race conditions' is an unusual sequence of events).
>
>         English is not my native language, so I hope Justin can comment on
> this.
>
>         Regards,
>
>         Christer
>
>
>
>
>
>
>
>
>
>