Re: [Idr] Bug in RFC 7911 (add-paths) and tie-breaking
Gyan Mishra <hayabusagsm@gmail.com> Thu, 24 June 2021 23:20 UTC
Return-Path: <hayabusagsm@gmail.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AEFD23A2EFE for <idr@ietfa.amsl.com>; Thu, 24 Jun 2021 16:20:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.087
X-Spam-Level:
X-Spam-Status: No, score=-1.087 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_REMOTE_IMAGE=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MkBpSk4_Hcwk for <idr@ietfa.amsl.com>; Thu, 24 Jun 2021 16:20:06 -0700 (PDT)
Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 39A043A2EFC for <idr@ietf.org>; Thu, 24 Jun 2021 16:20:05 -0700 (PDT)
Received: by mail-pg1-x52c.google.com with SMTP id v7so6038421pgl.2 for <idr@ietf.org>; Thu, 24 Jun 2021 16:20:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xwQVgL/0QXa9hCr/8IqkSy5B4J/DoiwRgMTLX8h8hlg=; b=vFyO6ajWVjE8jjuc1UmY7jp7Q0zGS+wdcokt7hcET/O7cXijTcQ3v1JgPs3Ic5YkNu RxaM01asy/BB5OX+1g29c1R7jiHU20TgQmrjMTkmwyI4cqJXZxr5u/VRDjFh+YJkI/Tp jPPtiwpbhi6gW014VA3zsPOQ0AdNinJdNQ5XIY2vIBaz3/rsAwgn8foiY9F6BIbgfr3e PNDpCwWalyC4xCEJ5AGy7g/RlT+J07wZXaoatCC4nYy1+WFVH/7rLzqXcz05JdOcAAvl v6Ev5lMn0GsvXplLzNHckhUVckjeiK5H7/HBzHx5oaBnp1adFflJYIM6AvCY342IU6Sv EN3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xwQVgL/0QXa9hCr/8IqkSy5B4J/DoiwRgMTLX8h8hlg=; b=XCYhGO8wTnneGgnzv1Xu88XlchAg7wcrA+gwbwGT5NvQnhriiObHd50s1f2rw51bk4 ik9wjqwtZkqK+mK3chZgttyz7dHvG+ssd/2q573eUaFnxqts8xO5GAH9zbpUeS5jXraF p3v4ZVtdwLzYQdMDpuPn449hGAzQg6gQfFrt5/7xe4BbVlCG2sbMoOL51NrcCOl7Be8o LOmFbi9IyhIG859tuiGbHq2dX+lKWK+/m28iPFAy6W+BMDtQaW3r5p1uHGppXNAFw5W3 AgJVMXU8L/BWw0+4T+9tG0XN7GoNZzGFXTBJbiBc7300pZ/TeJ8HRH/IknL+p81TaVfh 10jw==
X-Gm-Message-State: AOAM531rtoUKfhJqWSi7GBYGsr3IHO0qeV7lpVuCLjjwrs4kau4TBpxy DdkD3HIpcoi9PSWqOtENq3oHio6Ols3u9gbFuTM=
X-Google-Smtp-Source: ABdhPJzPTRnrN66jE7G9T217BzghGRzY0H/tgWyqjRyda/sLpRvNeW9HILMe2YTIoQ/VRKKGQ0xtog+L/UuYG6gwVKo=
X-Received: by 2002:a65:52c8:: with SMTP id z8mr6922980pgp.50.1624576804899; Thu, 24 Jun 2021 16:20:04 -0700 (PDT)
MIME-Version: 1.0
References: <F689CF63-236D-401D-9C8E-AC1C39CDE772@juniper.net> <CAOj+MMHg1f2rFNHZLM-j7Jx-ji_zWLhesmrNdS5LWfsNk_x9sw@mail.gmail.com> <BYAPR11MB3207351F5FA437DD807E576BC0079@BYAPR11MB3207.namprd11.prod.outlook.com> <BYAPR11MB32077F99EB6206C6BF8D2BDFC0079@BYAPR11MB3207.namprd11.prod.outlook.com>
In-Reply-To: <BYAPR11MB32077F99EB6206C6BF8D2BDFC0079@BYAPR11MB3207.namprd11.prod.outlook.com>
From: Gyan Mishra <hayabusagsm@gmail.com>
Date: Thu, 24 Jun 2021 19:19:54 -0400
Message-ID: <CABNhwV2Ympa9mx15z1kceJ2nMQHmhkoMY-tEr-SRNCZwcyqc+g@mail.gmail.com>
To: "Jakob Heitz (jheitz)" <jheitz=40cisco.com@dmarc.ietf.org>
Cc: John Scudder <jgs=40juniper.net@dmarc.ietf.org>, Robert Raszuk <robert@raszuk.net>, "dwalton76@gmail.com" <dwalton76@gmail.com>, "idr@ietf. org" <idr@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000005dd08e05c58b43fa"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/HF4F6MBbscPImGqEjEKSpQzSyiU>
Subject: Re: [Idr] Bug in RFC 7911 (add-paths) and tie-breaking
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jun 2021 23:20:11 -0000
RFC 7911 section 2 The assignment of the Path Identifier for a path by a BGP speaker is purely a local matter. However, the Path Identifier MUST be assigned in such a way that the BGP speaker is able to use the (Prefix, Path Identifier) to uniquely identify a path advertised to a neighbor. A BGP speaker that re-advertises a route MUST generate its own Path Identifier to be associated with the re-advertised route. A BGP speaker that receives a route should not assume that the identifier carries any particular semantics. As the path-is is locally generated it should always be unique - 32 bit unsigned integer. Gyan On Thu, Jun 24, 2021 at 6:28 PM Jakob Heitz (jheitz) <jheitz= 40cisco.com@dmarc.ietf.org> wrote: > And then when the attribute length is equal, you'll need another > tie-breaker. > > > > Regards, > > Jakob. > > > > *From:* Idr <idr-bounces@ietf.org> *On Behalf Of * Jakob Heitz (jheitz) > *Sent:* Thursday, June 24, 2021 3:20 PM > *To:* Robert Raszuk <robert@raszuk.net>; John Scudder <jgs= > 40juniper.net@dmarc.ietf.org> > *Cc:* dwalton76@gmail.com; idr@ietf. org <idr@ietf.org> > *Subject:* Re: [Idr] Bug in RFC 7911 (add-paths) and tie-breaking > > > > Then the code would have to compute the attribute length for each path, > carry it along and pass it to the bestpath compare function. > > For what? To increase convergence time? > > Because simple byte length will not be good enough and people will start > arguing that > > an extended community is just as valuable as a regular community and count > the number of communities > > rather than bytes and then the tunnel attribute is longer and on and on. > > I vote for path-id. > > > > Regards, > > Jakob. > > > > *From:* Idr <idr-bounces@ietf.org> *On Behalf Of *Robert Raszuk > *Sent:* Thursday, June 24, 2021 1:40 PM > *To:* John Scudder <jgs=40juniper.net@dmarc.ietf.org> > *Cc:* dwalton76@gmail.com; idr@ietf. org <idr@ietf.org> > *Subject:* Re: [Idr] Bug in RFC 7911 (add-paths) and tie-breaking > > > > John, > > > > > because it’s technically possible to receive two routes for the same > destination, from the same peer, with different path-id, and with all > tie-break metrics the same > > > > While this is not about risk of loops, those paths may possibly contain > different optional attributes otherwise they would be rather duplicates. > > > > More specifically one of them may contain additional optional attributes > while the other may not. > > > > Perhaps with add-paths while we are at this discussion it may make sense > to choose the path with a longer list of BGP path attributes as such > path may be more useful to receivers. > > > > Only then when the number of such attributes is the same fall to path_id > as tie-break. > > > > Thx, > > Robert > > > > > > On Thu, Jun 24, 2021 at 8:15 PM John Scudder <jgs= > 40juniper.net@dmarc.ietf.org> wrote: > > Hi Folks, > > Claudio recently pointed out a bug in RFC 7911 to the authors, and we > thought we should let the WG know. The gist of the bug is that the > tie-breaking process is underspecified, because it’s technically possible > to receive two routes for the same destination, from the same peer, with > different path-id, and with all tie-break metrics the same (all the way > down to peer address). My guess — but it’s only a guess, I haven’t checked > — is that implementations may mostly have chosen to prefer the first path > received.[*] But the only thing we can say with confidence is “it’s > underspecified and therefore implementation-dependent.” > > When I worked through this, my conclusion was that whatever option an > implementation chooses should be safe, since by definition the paths are > equivalent all the way down. I don’t see a way to form a loop even if every > router in the network makes arbitrary — and conflicting — choices in this > situation, since by definition of IGP distance, if a given router A makes > an arbitrary choice, none of its neighbors when presented with the same set > of routes will make a conflicting arbitrary choice, since the options are: > > - The peer is closer to both destinations, in which case it can make any > choice it wants, the traffic will not loop back to A, > - The peer is further from both destinations, in which case it can make > any choice it wants, the traffic will not loop back from A, > - The peer is closer to one and further from the other destination, in > which case it isn’t faced with a dilemma, it will choose the closer (and > the traffic won’t go back towards A). > > I guess if you’re in a network that doesn’t have IGP distances at all > (maybe everything is static routed?) or if IGP distances don’t follow the > usual rules of IGP “physics”, then you could create a problem. But those > are pathological cases where we’d expect BGP not to work very well anyway. > > Claudio suggested that path-id would be a good final tie-break; that makes > sense to me. We could do a quick update to 7911 to standardize this new > tie-break, we could do a bis of 7911 to include the new tie-break, or we > could just leave things as they are, relying on my argument above that says > there is no strong need to standardize a tie-break since any choice is OK. > > For the moment, this is just an FYI for the WG. Thanks very much to > Claudio for pointing out the bug! > > —John > > [*] You may notice that it’s possible to have two such paths packed into > the same update in some circumstances, which makes the choice even more > arbitrary since it’s pretty notional to say one has arrived before the > other. > _______________________________________________ > Idr mailing list > Idr@ietf.org > https://www.ietf.org/mailman/listinfo/idr > > _______________________________________________ > Idr mailing list > Idr@ietf.org > https://www.ietf.org/mailman/listinfo/idr > -- <http://www.verizon.com/> *Gyan Mishra* *Network Solutions A**rchitect * *Email gyan.s.mishra@verizon.com <gyan.s.mishra@verizon.com>* *M 301 502-1347*
- [Idr] Bug in RFC 7911 (add-paths) and tie-breaking John Scudder
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Gyan Mishra
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Robert Raszuk
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Jakob Heitz (jheitz)
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Jakob Heitz (jheitz)
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Gyan Mishra
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… bruno.decraene
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Claudio Jeker
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Claudio Jeker
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… bruno.decraene
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Robert Raszuk
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… bruno.decraene
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Gyan Mishra
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Robert Raszuk
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… bruno.decraene
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Robert Raszuk
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… bruno.decraene
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Claudio Jeker
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Robert Raszuk
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Jeffrey Haas
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Robert Raszuk
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… John Scudder
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Jeffrey Haas
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Jeffrey Haas
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Nick Hilliard
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Gyan Mishra
- Re: [Idr] Bug in RFC 7911 (add-paths) and tie-bre… Gyan Mishra