Re: [Idr] RtgDir review: draft-ietf-idr-shutdown-05

Job Snijders <job@instituut.net> Sat, 11 February 2017 16:02 UTC

Return-Path: <job@instituut.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 36A501298C6 for <idr@ietfa.amsl.com>; Sat, 11 Feb 2017 08:02:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=instituut-net.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nEOC1LnOlMoF for <idr@ietfa.amsl.com>; Sat, 11 Feb 2017 08:02:30 -0800 (PST)
Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C05FF1298C5 for <idr@ietf.org>; Sat, 11 Feb 2017 08:02:29 -0800 (PST)
Received: by mail-wm0-x22b.google.com with SMTP id r141so68724074wmg.1 for <idr@ietf.org>; Sat, 11 Feb 2017 08:02:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=instituut-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aTcz3VV9gbdzmNrfN8T3+Z9qlLrlQtiyaEbHIEnljUY=; b=yqEv2Ic9BKiMIQimVbxaE5wCTQ06MNqLugvfvWixlWK3PcCvfhQF7lMgFDEQgz+Q4l Ue7CdvmJtnUCIHokNN7fvyTyzO3dSnBae0SxMCqz+1Y4j3gAFvl1z7KCu0X09BQWQp+2 EcdL1D9NVoxGDWx4LiaCSVe+EiQF/RzBUtP/QvHn8mopcWlSNbMVuq4QCypm4unpGVWn 4uFQdb/3LBJpAuuOLDHWyicdW3RI4lZepceBELNFtLk+qvqs2o7N9KP3Vbn5QKZU2fKF ZTytTMntkoS35jF+CXG1+jebqCr7oyhkfw6HOu0p5dje7wQws+wYYOecSKJuvc2rAcCS Z5RA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aTcz3VV9gbdzmNrfN8T3+Z9qlLrlQtiyaEbHIEnljUY=; b=bI2YRaiQpz1enjhdXFLwq1tvWawnoJmTIFvYrDWGEq7ei2sm0P0i7K1LXurC7DeWh6 1AsyRqoTEBg7MqXIQqSKbTvsa1tzNLnXZyJTJBHhJvtih9jqykDjM6xZpVOrbBELeEDv kgrtG7yHgPpjhQI59xOVYG35+QOMIMF4qoOKuBszFJOcl4KIORsBLM4+Xeq/GtAtf9zg 1TcU7ghgtDqNeUexukK+sfNoyXxK9WhDNZac4uBzssShS7Yo6Jmb9ouBDBkanB1lITlx dFjypL82dcdUAJBLXOJJDzGRc7j2eGcV2kCFpODJIK92hxHvB9uU6913iS7uJX5iJnp+ 3ZZQ==
X-Gm-Message-State: AMke39kQjkp1K47skb3RjNVMgygogl7c0goEgME35WlHp/r0BqY4nSa0DFtv2BQ3tUUTNg==
X-Received: by 10.28.229.73 with SMTP id c70mr29424035wmh.82.1486828948181; Sat, 11 Feb 2017 08:02:28 -0800 (PST)
Received: from localhost ([2001:67c:208c:10:20c9:492e:ef4f:1342]) by smtp.gmail.com with ESMTPSA id t202sm3933133wmt.28.2017.02.11.08.02.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Feb 2017 08:02:27 -0800 (PST)
Date: Sat, 11 Feb 2017 17:02:26 +0100
From: Job Snijders <job@instituut.net>
To: Lou Berger <lberger@labn.net>
Message-ID: <20170211160226.GB1049@Vurt.local>
References: <ebd9efed-4a8c-df1e-4edf-d80ad0aa688e@labn.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ebd9efed-4a8c-df1e-4edf-d80ad0aa688e@labn.net>
X-Clacks-Overhead: GNU Terry Pratchett
User-Agent: Mutt/1.7.2 (2016-11-26)
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/K9sUYHPs7030po7evDt_qzUk50s>
Cc: rtg-ads@ietf.org, idr@ietf.org, draft-ietf-idr-shutdown.all@ietf.org, rtg-dir@ietf.org
Subject: Re: [Idr] RtgDir review: draft-ietf-idr-shutdown-05
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Feb 2017 16:02:32 -0000

Dear Lou,

draft-ietf-idr-shutdown-06 was published just now to address your
comments. 

On Thu, Feb 09, 2017 at 08:01:13PM -0500, Lou Berger wrote:
> Minor Issues:
>     In reading the document it's unclear if Shutdown Communication field
> must include a trailing zero or not.  (I authored something similar once
> and had an interop problem where one implementation assumed null
> termination was required and included in length, while the other didn't.
> Our intent was no null required, but the spec wasn't explicit.)   Either
> are fine, and given there are implementations you might just want to
> have the spec match the implementation.

The following clarification has been added to the Shutdown Communication
field: "This field is not NUL terminated." 

https://tools.ietf.org/rfcdiff?url2=draft-ietf-idr-shutdown-06.txt 

> Nits:
>   
> https://tools.ietf.org/idnits?url=https://tools.ietf.org/id/draft-ietf-idr-shutdown-05.txt
> reports nits that should be fixed.

The abstract and Copyright Notice have been updated to fix the nits.

Kind regards,

Job