[Idr] Barry Leiba's Discuss on draft-ietf-idr-flow-spec-v6-17: (with DISCUSS and COMMENT)

Barry Leiba via Datatracker <noreply@ietf.org> Sun, 01 November 2020 02:57 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: idr@ietf.org
Delivered-To: idr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 66EBE3A0E14; Sat, 31 Oct 2020 19:57:03 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Barry Leiba via Datatracker <noreply@ietf.org>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-idr-flow-spec-v6@ietf.org, idr-chairs@ietf.org, idr@ietf.org, Jie Dong <jie.dong@huawei.com>, aretana.ietf@gmail.com, jie.dong@huawei.com
X-Test-IDTracker: no
X-IETF-IDTracker: 7.21.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Barry Leiba <barryleiba@computer.org>
Message-ID: <160419942295.32103.6403833617114377383@ietfa.amsl.com>
Date: Sat, 31 Oct 2020 19:57:03 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/UkEKhr-J22nCjCR4Jn96hN7HP6s>
Subject: [Idr] Barry Leiba's Discuss on draft-ietf-idr-flow-spec-v6-17: (with DISCUSS and COMMENT)
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Nov 2020 02:57:04 -0000

Barry Leiba has entered the following ballot position for
draft-ietf-idr-flow-spec-v6-17: Discuss

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-idr-flow-spec-v6/



----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

This should be extremely straightforward: either there’s a typo... or I simply
don’t understand.  In the Abstract:

   Dissemination of Flow Specification Rules provides a Border Gateway
   Protocol extension for the propagation of traffic flow information
   for the purpose of rate limiting or filtering IPv4 protocol data
   packets.

Is that supposed to say “IPv6”?


----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

A few minor comments:

— Section 3.1 —

   The offset has been defined
   to allow for flexible matching on part of the IPv6 address where it
   is required to skip (don't care) of N first bits of the address.

I can’t parse this sentence, nor make sense of the parenthetical.  Can you
reword it?

   In the case Length minus Offset is 0 every address matches.  Length
   MUST always be in the range 0-128 and Length minus Offset MUST always
   be 0 or more, otherwise this component is malformed.

Is there actually value in allowing 129 ways to match every address
(length=offset=0, length=offset=1, length=offset=87, and so on)?  If not, it
seems less prone to error to say that length=offset=0 matches every address,
and otherwise length MUST be greater than offset or the component is malformed.
 No?

— Section 3.8.1 —

   Neither for the destination prefix pattern (length - offset = 32 bit)
   nor for the source prefix pattern (length - offset = 40 bit) any
   padding is needed (both patterns end on a octet boundary).

This isn’t grammatical.  How about this?:

NEW
   Padding is not needed either for the destination prefix pattern
   (length - offset = 32 bit) or for the source prefix pattern
   (length - offset = 40 bit), as both patterns end on a octet
   boundary.
END