Re: [Idr] [Gen-art] Genart last call review of draft-ietf-idr-ext-opt-param-11

Lars Eggert <lars@eggert.org> Thu, 22 April 2021 13:36 UTC

Return-Path: <lars@eggert.org>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0E1763A0744; Thu, 22 Apr 2021 06:36:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NlQ_xV_hxgQi; Thu, 22 Apr 2021 06:35:58 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 63C093A0656; Thu, 22 Apr 2021 06:35:57 -0700 (PDT)
Received: from [IPv6:2a00:ac00:4000:400:2c15:b00:a499:f10f] (unknown [IPv6:2a00:ac00:4000:400:2c15:b00:a499:f10f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id D4C0960033C; Thu, 22 Apr 2021 16:35:49 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1619098549; bh=1pdYS386uIZBCjEebzD9elArv1ZKmVsaDRdqTXKTpfk=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=yD1Y7LirKhUmuoZeXxJUtonQsXICQVKbzgY/JgJy+BJvG7kCykz0UixwcYd6Bf5qx T1MqvzY01acqQbER4BlCxXXN0m0RYtoo8TqEtTnkFhquu9ypRH2cXIEqIlYQEo2PY9 e839X8LxgreDXS8etY7lTUNdo9Eojg5U6BaRPkBw=
From: Lars Eggert <lars@eggert.org>
Message-Id: <FD10CF43-7160-4DD5-BEAC-99EF1A3E2FD5@eggert.org>
Content-Type: multipart/signed; boundary="Apple-Mail=_1576C0D4-48FD-40BD-8860-2D74F6896BF4"; protocol="application/pgp-signature"; micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Date: Thu, 22 Apr 2021 16:35:49 +0300
In-Reply-To: <161851524693.27672.11525659031465457077@ietfa.amsl.com>
Cc: gen-art@ietf.org, draft-ietf-idr-ext-opt-param.all@ietf.org, idr@ietf.org, last-call@ietf.org
To: Christer Holmberg <christer.holmberg@ericsson.com>
References: <161851524693.27672.11525659031465457077@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3654.60.0.2.21)
X-MailScanner-ID: D4C0960033C.A3AD6
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/gTa2yHwAtYYJsOqkCVYHPJqezsc>
Subject: Re: [Idr] [Gen-art] Genart last call review of draft-ietf-idr-ext-opt-param-11
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2021 13:36:02 -0000

Christer, thank you for your review . I have entered a No Objection ballot for this document.

Lars


> On 2021-4-15, at 22:34, Christer Holmberg via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Christer Holmberg
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-idr-ext-opt-param-11
> Reviewer: Christer Holmberg
> Review Date: 2021-04-15
> IETF LC End Date: 2021-04-09
> IESG Telechat date: 2021-04-22
> 
> Summary: The document is easy to read, and I have no technical issues. However,
> I do have a minor question, and a couple of editorial suggestions, that I'd
> like the authors to address.
> 
> Major issues: N/A
> 
> Minor issues:
> 
> Q1: As far as I understand, the document only defines a new BGP OPEN Optional
> Parameter Type, but does not modify/add procedures in RFC 4271. So, is the
> document really an update to RFC 4271? And, when reading RFC 5429, I cannot
> find any text saying that new parameter types would require an update to RFC
> 4271. I also looked at a few other RFCs that add new values to the BGP IANA
> registry, and they were not updating any RFC.
> 
> Nits/editorial comments:
> 
> Q2: I suggest that Section 2 is renamed to  "New Optional Parameter Type code",
> or something like that. OR, if the document really is updating RFC 4271,
> perhaps "Update to RFC 4271".
> 
> Q3: I suggest that Section 3 is renamed to "Backward Compatibility", or
> something like that.
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art