Re: [Idr] draft-rosen-idr-extcomm-iana-00.txt

Jon Mitchell <jrmitche@puck.nether.net> Fri, 14 June 2013 04:34 UTC

Return-Path: <jrmitche@puck.nether.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB6E621F991F for <idr@ietfa.amsl.com>; Thu, 13 Jun 2013 21:34:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[AWL=0.000, BAYES_00=-2.599]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gbcocu-pO+xG for <idr@ietfa.amsl.com>; Thu, 13 Jun 2013 21:34:54 -0700 (PDT)
Received: from puck.nether.net (puck.nether.net [IPv6:2001:418:3f4::5]) by ietfa.amsl.com (Postfix) with ESMTP id 46E9A21F98AD for <idr@ietf.org>; Thu, 13 Jun 2013 21:34:54 -0700 (PDT)
Received: from puck.nether.net (localhost [127.0.0.1]) by puck.nether.net (8.14.7/8.14.5) with ESMTP id r5E4Yoit000672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 14 Jun 2013 00:34:50 -0400
Received: (from jrmitche@localhost) by puck.nether.net (8.14.7/8.14.7/Submit) id r5E4YoNn000671; Fri, 14 Jun 2013 00:34:50 -0400
Date: Fri, 14 Jun 2013 00:34:49 -0400
From: Jon Mitchell <jrmitche@puck.nether.net>
To: Yakov Rekhter <yakov@juniper.net>
Message-ID: <20130614043449.GA21715@puck.nether.net>
References: <201306121433.r5CEXWL75028@magenta.juniper.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <201306121433.r5CEXWL75028@magenta.juniper.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (puck.nether.net [127.0.0.1]); Fri, 14 Jun 2013 00:34:50 -0400 (EDT)
Cc: idr@ietf.org, erosen@cisco.com
Subject: Re: [Idr] draft-rosen-idr-extcomm-iana-00.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/idr>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jun 2013 04:34:55 -0000

On 12/06/13 07:33 -0700, Yakov Rekhter wrote:
> Sue and John,
> 
> The authors of draft-rosen-idr-extcomm-iana-00.txt would like
> the IDR WG to accept this draft as an IDR WG document.
> 

Support adoption, comments below can be sorted out after acceptance...

A few comments or questions - not an implementor so possibly off base
on a few of these:

Section 3 - nit - it's not totally clear that RFC5701 defines the two
high order octets as "Type Field".  It certainly implies it, but calls
it by various other names throughout.

Section 4 - Can I suggest "Standards Action" for new Types, or at
least something more specific than request to IANA.

Section 5.1.1 - first thought it was mistake that simpson draft had
full type considering all other flowspec actions are sub-type of
experimental, but guess this is a point to take up with those authors
(although draft expired).  Might be easier if you specify in
paranthesis no sub-types for 0x04, 0x05, 0x08.  0x06 could use
standard wording of "Sub-types are defined in..."

Section 5.2 - it would be easier to understand I think if you split
transitive and non-transitive sub-types into seperate sub-sections.

Section 5.2.1 - this doesn't mention if it's transitive /
non-transitive, mute if you follow advice above.  Also - would it make
sense to order these sub-sections by type order?

Section 5.2.2 - Section header says Transitive, Registry Name says
Non-Transitive?

Section 5.2.10 - this section nor anywhere else in document talks
about Traffic Actions (for flow spec) which is currently referenced in
BGP Extended Communities registry - will it be removed from the
registry or should 0x07 just have a comment/reference to it's 
seperate registry? 

Section 6 - should you just change title of Section 5 then?

Section 10 - Considering this redefines every registry and has content
in it, maybe a note to IANA/RFC Editor to hold publication until URL
references to the actual re-organized IANA registries, which will be
more useful to future readers than stale content in Section 5.

Thanks,

-Jon