RE: gen-ART LC review of draft-ietf-mpls-mldp-hsmp-04

"Roni Even" <ron.even.tlv@gmail.com> Tue, 10 December 2013 05:14 UTC

Return-Path: <ron.even.tlv@gmail.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C00A01AE1BC; Mon, 9 Dec 2013 21:14:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.9
X-Spam-Level:
X-Spam-Status: No, score=0.9 tagged_above=-999 required=5 tests=[BAYES_40=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0QUgF_VxEeO5; Mon, 9 Dec 2013 21:14:05 -0800 (PST)
Received: from mail-ee0-x22b.google.com (mail-ee0-x22b.google.com [IPv6:2a00:1450:4013:c00::22b]) by ietfa.amsl.com (Postfix) with ESMTP id 86A5C1AE1BA; Mon, 9 Dec 2013 21:14:04 -0800 (PST)
Received: by mail-ee0-f43.google.com with SMTP id c13so1939213eek.16 for <multiple recipients>; Mon, 09 Dec 2013 21:13:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:references:in-reply-to:subject:date:message-id:mime-version :content-type:thread-index:content-language; bh=rKTif6eRXlV0IOfwLzd2HDXb1THVXZ5eAMD7NNMA48k=; b=0c0IRbSHYbby56cFZkiiu4Sj/I7NbRfndqb7YV3PIU8QgLrmK+hrcYJZXvvP5Hf0iD LWuPdDGJBQ50QmsTXZTUQPNgcTmn4NC8oD+4WskRKLiZX3IYhJqAnTx6XnP4kFfqzVCv j9Leu5tSrNmSyNzoGy+ymFOd3DJcgOJuq6oAXFg01wkMJqQZ5gDd9/Rka9PJG8oi5wZr i3dgj+bhsomKEjzv7qm+M1WazjnJMRJGIR9t/mJAw7ljbM1ZTKK9vEfJkE1N+pNJEhcp u2hYuS+A1NABK+sLFoZlMBfEOycHB2+wgc4lKTdEZlxLo1TPhxZPN85dHqw8sgk6v5NM XfsA==
X-Received: by 10.15.32.73 with SMTP id z49mr15946043eeu.27.1386652439029; Mon, 09 Dec 2013 21:13:59 -0800 (PST)
Received: from RoniE ([109.67.11.64]) by mx.google.com with ESMTPSA id 4sm6817349eed.14.2013.12.09.21.13.55 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Dec 2013 21:13:57 -0800 (PST)
From: Roni Even <ron.even.tlv@gmail.com>
To: 'Lizhong Jin' <lizho.jin@gmail.com>, draft-ietf-mpls-mldp-hsmp.all@tools.ietf.org, ietf@ietf.org, gen-art@ietf.org
References: <02c601cef441$64352860$2c9f7920$@gmail.com> <03dd01cef556$e5a5e450$b0f1acf0$@gmail.com>
In-Reply-To: <03dd01cef556$e5a5e450$b0f1acf0$@gmail.com>
Subject: RE: gen-ART LC review of draft-ietf-mpls-mldp-hsmp-04
Date: Tue, 10 Dec 2013 07:10:24 +0200
Message-ID: <03ef01cef566$247e7660$6d7b6320$@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_03F0_01CEF576.E808F410"
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQJIKFJ9mRb0ffAYWPPy3dZw9o9G5QKH/jGymUY7ItA=
Content-Language: en-us
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Dec 2013 05:14:08 -0000

Hi Lizhong,

See inline

Roni



From: Lizhong Jin [mailto:lizho.jin@gmail.com]
Sent: 10 December, 2013 5:21 AM
To: 'Roni Even'; draft-ietf-mpls-mldp-hsmp.all@tools.ietf.org;
ietf@ietf.org; gen-art@ietf.org
Subject: RE: gen-ART LC review of draft-ietf-mpls-mldp-hsmp-04



Hi Roni,

Thank you for the review. Please see reply in line.

Lizhong



From: Roni Even [mailto:ron.even.tlv@gmail.com]
Sent: 2013年12月9日 2:15
To: draft-ietf-mpls-mldp-hsmp.all@tools.ietf.org; ietf@ietf.org;
gen-art@ietf.org
Subject: gen-ART LC review of draft-ietf-mpls-mldp-hsmp-04



I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments you
may receive.

Document: draft-ietf-mpls-mldp-hsmp-04

Reviewer: Roni Even

Review Date:2013-12-8

IETF LC End Date: 2013-12-10

IESG Telechat date:



Summary: This draft is ready for publication as an standard track RFC.





Major issues:



Minor issues:



1.  In section 3.1 last paragraph  “If the peer has not advertised the
corresponding capability, then label messages using the HSMP FEC Element
SHOULD NOT be sent to the  peer. “. Why use a SHOULD NOT and not MUSR NOT

[Lizhong] I follow the description in RFC6388 section 2.1. But let me try to
explain. There may exist some rare cases that the peer does not have the
capability negotiation function, but still support HSMP. This could only
happen if the node has pre-knowledge of the peer’s HSMP capability. In that
case, label message could be sent to the peer.

To Ice, if you have any opinion, please comment.

[Roni Even] Thanks for explaining. Maybe you can add such text to the
document in order to explain why it is a should but it is up to you. I am OK
with any decision you make





Nits/editorial comments:

1.	In section 2 for PTP IEEE1588 need a reference. There is a reference
in the reference section but it is not used. Also the tictoc reference is
not used.

[Lizhong] thank you. Will fix in next version.