RE: gen-ART LC review of draft-ietf-mpls-mldp-hsmp-04

"Lizhong Jin" <lizho.jin@gmail.com> Tue, 10 December 2013 03:21 UTC

Return-Path: <lizho.jin@gmail.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 714311AE13D; Mon, 9 Dec 2013 19:21:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.451
X-Spam-Level: *
X-Spam-Status: No, score=1.451 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, MIME_CHARSET_FARAWAY=2.45, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GQH5_hIHK-WH; Mon, 9 Dec 2013 19:21:27 -0800 (PST)
Received: from mail-pb0-x236.google.com (mail-pb0-x236.google.com [IPv6:2607:f8b0:400e:c01::236]) by ietfa.amsl.com (Postfix) with ESMTP id 87E4C1AE029; Mon, 9 Dec 2013 19:21:27 -0800 (PST)
Received: by mail-pb0-f54.google.com with SMTP id un15so6654603pbc.41 for <multiple recipients>; Mon, 09 Dec 2013 19:21:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:references:in-reply-to:subject:date:message-id:mime-version :content-type:thread-index:content-language; bh=0GYRft3nHZG1SM4odk/N3KH6oNItA4OFrLxnKMuDSrw=; b=XNucCDGzk3BDjOros885oVos6dtCqUTTv/aX6Zm6GMPcU1Tii/C0mjh8e8HRLsgTGX 9RLUhBRWpM38u1R2rWbxrSHp/Lw4qdCXjMZJp4KnsVmakXs6lVziaXC2RuvQiwye4lqQ t8/hZCnSdF7ctH2w/knOQ0p5UUgvT+1UTq3igS7NJ+aMTbSSKYveMqJyuLzs6HKfWwRB mKpBCzo6NizfXSbyLv7c2S5m+H/wozkLJSSCSIcLCs9YXaodN6AZy+TFfYsqdhcVmCTe TArZFmh51jdr/wzV99jgxnDQAxVcq+menSAQtbSdca4EsqN3TkSkXge06TKen3dlhKkH yUZg==
X-Received: by 10.68.170.66 with SMTP id ak2mr193022pbc.5.1386645682554; Mon, 09 Dec 2013 19:21:22 -0800 (PST)
Received: from LIZHONGJ ([180.166.53.21]) by mx.google.com with ESMTPSA id ae5sm30195742pac.18.2013.12.09.19.21.18 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Dec 2013 19:21:21 -0800 (PST)
From: Lizhong Jin <lizho.jin@gmail.com>
To: 'Roni Even' <ron.even.tlv@gmail.com>, draft-ietf-mpls-mldp-hsmp.all@tools.ietf.org, ietf@ietf.org, gen-art@ietf.org
References: <02c601cef441$64352860$2c9f7920$@gmail.com>
In-Reply-To: <02c601cef441$64352860$2c9f7920$@gmail.com>
Subject: RE: gen-ART LC review of draft-ietf-mpls-mldp-hsmp-04
Date: Tue, 10 Dec 2013 11:21:16 +0800
Message-ID: <03dd01cef556$e5a5e450$b0f1acf0$@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_03DE_01CEF599.F3CC3190"
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQJIKFJ9mRb0ffAYWPPy3dZw9o9G5ZlaRACw
Content-Language: zh-cn
X-Mailman-Approved-At: Tue, 10 Dec 2013 08:32:43 -0800
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Dec 2013 03:21:29 -0000

Hi Roni,

Thank you for the review. Please see reply in line.

Lizhong

 

From: Roni Even [mailto:ron.even.tlv@gmail.com] 
Sent: 2013Äê12ÔÂ9ÈÕ 2:15
To: draft-ietf-mpls-mldp-hsmp.all@tools.ietf.org; ietf@ietf.org;
gen-art@ietf.org
Subject: gen-ART LC review of draft-ietf-mpls-mldp-hsmp-04

 

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments you
may receive.

Document: draft-ietf-mpls-mldp-hsmp-04

Reviewer: Roni Even

Review Date:2013¨C12-8

IETF LC End Date: 2013-12¨C10

IESG Telechat date: 

 

Summary: This draft is ready for publication as an standard track RFC.

 

 

Major issues:

 

Minor issues:

 

1.  In section 3.1 last paragraph  ¡°If the peer has not advertised the
corresponding capability, then label messages using the HSMP FEC Element
SHOULD NOT be sent to the  peer. ¡°. Why use a SHOULD NOT and not MUSR NOT

[Lizhong] I follow the description in RFC6388 section 2.1. But let me try to
explain. There may exist some rare cases that the peer does not have the
capability negotiation function, but still support HSMP. This could only
happen if the node has pre-knowledge of the peer¡¯s HSMP capability. In that
case, label message could be sent to the peer. 

To Ice, if you have any opinion, please comment.

 

Nits/editorial comments:

1.	In section 2 for PTP IEEE1588 need a reference. There is a reference
in the reference section but it is not used. Also the tictoc reference is
not used.

[Lizhong] thank you. Will fix in next version.