Re: Gen-ART LC review of draft-ietf-mpls-return-path-specified-lsp-ping-12

Loa Andersson <loa@pi.nu> Wed, 28 August 2013 14:20 UTC

Return-Path: <loa@pi.nu>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5506211E813A; Wed, 28 Aug 2013 07:20:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.549
X-Spam-Level:
X-Spam-Status: No, score=-102.549 tagged_above=-999 required=5 tests=[AWL=0.050, BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 48JZT6KHO0rk; Wed, 28 Aug 2013 07:20:12 -0700 (PDT)
Received: from pipi.pi.nu (pipi.pi.nu [83.168.239.141]) by ietfa.amsl.com (Postfix) with ESMTP id 794B911E811F; Wed, 28 Aug 2013 07:20:12 -0700 (PDT)
Received: from [192.168.5.58] (81-229-83-119-no65.business.telia.com [81.229.83.119]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: loa@pi.nu) by pipi.pi.nu (Postfix) with ESMTPSA id B6CD918033E4; Wed, 28 Aug 2013 16:20:11 +0200 (CEST)
Message-ID: <521E071F.7050607@pi.nu>
Date: Wed, 28 Aug 2013 16:20:15 +0200
From: Loa Andersson <loa@pi.nu>
User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: Roni Even <ron.even.tlv@gmail.com>
Subject: Re: Gen-ART LC review of draft-ietf-mpls-return-path-specified-lsp-ping-12
References: <041001cea3ef$6a931b60$3fb95220$@gmail.com>
In-Reply-To: <041001cea3ef$6a931b60$3fb95220$@gmail.com>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 8bit
Cc: gen-art@ietf.org, draft-ietf-mpls-return-path-specified-lsp-ping.all@tools.ietf.org, ietf@ietf.org
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ietf>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Aug 2013 14:20:17 -0000

Roni,

Thanks for an insightful review, you have captured much of what we
been struggling with when it comes to the IANA allocations.

On 2013-08-28 15:06, Roni Even wrote:
> I am the assigned Gen-ART reviewer for this draft. For background on
> Gen-ART, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>
> Please resolve these comments along with any other Last Call comments
> you may receive.
>
> Document: draft-ietf-mpls-return-path-specified-lsp-ping-12
> Summary: This draft is almost ready for publication as a standard track RFC.
>
> Major issues:
>
> Minor issues:
>
> I am not clear on the sub-TLV in section 6.2
>
>  1. If a new sub-TLV is defined for TLV type 1 do they need also to be
>     added to TLV type 21.

Yes the document says "Directly copied from TLV Type 1, MUST NOT be
assigned" the intention is that this applies to future sub-TLVs also.
I guess it could be changed to "Directly copied from TLV Type 1
(including future allocations for TLV Type 1, MUST NOT be assigned"
if that makes thing clearer.

>     This should be clear, and if there is some
>     relation I think it should be reflected in the IANA registry for TLV
>     type 1

I guess that makes sense - but it has not been the what we've done 
earlier - I think we could add this where needed by directly
communicate  this to IANA.

>  2. For the vendor or private use why a difference policy than the rest
>     of the sub-TLV registry

We don't assign vendor private use at all, so by default it is
different. I don't see that it could be different.

/Loa
>
> Nits/editorial comments:
>
>  1. In section 3.4 I assume that “TC” is traffic class. It will be good
>     to expand and have reference.
>

-- 


Loa Andersson                        email: loa@mail01.huawei.com
Senior MPLS Expert                          loa@pi.nu
Huawei Technologies (consultant)     phone: +46 739 81 21 64