[Int-dir] Intdir early review of draft-ietf-opsawg-tsvwg-udp-ipfix-03

Joseph Touch via Datatracker <noreply@ietf.org> Sat, 13 January 2024 04:02 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: int-dir@ietf.org
Delivered-To: int-dir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C8188C14CF0D; Fri, 12 Jan 2024 20:02:57 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Joseph Touch via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
Cc: draft-ietf-opsawg-tsvwg-udp-ipfix.all@ietf.org, opsawg@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.2.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <170511857780.9087.10362348707608655283@ietfa.amsl.com>
Reply-To: Joseph Touch <touch@strayalpha.com>
Date: Fri, 12 Jan 2024 20:02:57 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/5BCJHcWj48AHrbSCXxShUocJpO8>
Subject: [Int-dir] Intdir early review of draft-ietf-opsawg-tsvwg-udp-ipfix-03
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Jan 2024 04:02:57 -0000

Reviewer: Joseph Touch
Review result: Ready with Issues

This review is performed as part of the INTAREA cross-area review.

There do not appear to be any INTAREA issues in this document.

NOTE: as author of the UDP options on which this document is based, I have some
other concerns noted below, which are the "issues" indicated in the review
result (ready with issues).

There are some misconceptions about UDP options that should be corrected in
this document:

Regarding SAFE options:
-       “Such options can be silently ignored by receivers without affecting
the meaning of the UDP user data” -       Should be “Such options can be
silently ignored by legacy receivers because they do not alter the UDP user
data”

Regarding UNSAFE options:
-       “Such options are not safe to ignore”
-       Should be “Such options are not safe tor legacy receivers to ignore
because they alter the UDP user data”

The document should be more clear that UDP options occur per-packet within a
flow and can be introduced at any time in the flow (unlike TCP).

Sec 4.1 needs to indicate use of a field with 256 possible values; it currently
is defined for only 32 or 64 values.