Re: [Int-dir] INTDIR Review of draft-ietf-tsvwg-rfc6040update-shim-20

Bob Briscoe <ietf@bobbriscoe.net> Thu, 23 November 2023 22:20 UTC

Return-Path: <ietf@bobbriscoe.net>
X-Original-To: int-dir@ietfa.amsl.com
Delivered-To: int-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0FC8BC19849D; Thu, 23 Nov 2023 14:20:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.106
X-Spam-Level:
X-Spam-Status: No, score=-7.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=bobbriscoe.net
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AehE2IwFxYXD; Thu, 23 Nov 2023 14:20:26 -0800 (PST)
Received: from mail-ssdrsserver2.hostinginterface.eu (mail-ssdrsserver2.hostinginterface.eu [185.185.85.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F2F99C19849C; Thu, 23 Nov 2023 14:20:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bobbriscoe.net; s=default; h=In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Content-Type:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zim+w5NtskOTDZiyQX4bikY/pFy6beHXcmH4IOxcMvA=; b=vAd7efTh4YnuTiDUiFhCrun0tR vbTeS00cjNVgkzRNs5IwianTGDL6LheM9dmviacgQiPYz68AKb2XySfit8lVjVBFS1EQyMXXrdYzh mnEsNP0tROSCHWqtOJbfu6ltIN78+zxshebtjUgTF5JtTqo5Glg0QSTKkQRiR53s340zuALa4opwM kBrIkJ/4dRFJBWtCbaZ9u1DFleER6WE/S9XdBL44G4Atp8quL7K2jg1U+eUk1s5eJxGO4WJtanhSs SZnyUGoVvc9/qEGOGWIi1CPjnEerKEuzUIhQ+xu3CoGkTgTftUF7xN2xggTyglrBIKXlMp7/cCZko Nj8+pieg==;
Received: from 67.153.238.178.in-addr.arpa ([178.238.153.67]:45516 helo=[192.168.1.29]) by ssdrsserver2.hostinginterface.eu with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from <ietf@bobbriscoe.net>) id 1r6I3i-0003I4-3A; Thu, 23 Nov 2023 22:20:24 +0000
Content-Type: multipart/alternative; boundary="------------BHGScHqM4U8n4euhXM0SwNi2"
Message-ID: <3742060d-7a84-46c2-8796-3cd524e31788@bobbriscoe.net>
Date: Thu, 23 Nov 2023 22:20:22 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-GB
To: Donald Eastlake <d3e3e3@gmail.com>, int-dir@ietf.org, draft-ietf-tsvwg-rfc6040update-shim.all@ietf.org
References: <CAF4+nEE-t=q5ZVwRZKsdy-kAatUEFVVteYN8_hdts0aAV0+g_w@mail.gmail.com>
From: Bob Briscoe <ietf@bobbriscoe.net>
In-Reply-To: <CAF4+nEE-t=q5ZVwRZKsdy-kAatUEFVVteYN8_hdts0aAV0+g_w@mail.gmail.com>
X-MagicSpam-TUUID: 50983551-ea18-47ab-a57f-0fb46828e9cb
X-MagicSpam-SUUID: d67781db-cb63-44aa-9c7c-3aa9171b02ed
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - ssdrsserver2.hostinginterface.eu
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - bobbriscoe.net
X-Get-Message-Sender-Via: ssdrsserver2.hostinginterface.eu: authenticated_id: in@bobbriscoe.net
X-Authenticated-Sender: ssdrsserver2.hostinginterface.eu: in@bobbriscoe.net
X-Source:
X-Source-Args:
X-Source-Dir:
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/eV1irVIP4Rk41eIEZ6Tdas03XEk>
Subject: Re: [Int-dir] INTDIR Review of draft-ietf-tsvwg-rfc6040update-shim-20
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Nov 2023 22:20:32 -0000

Thank you for this review, Donald.

I've adopted all you proposed changes, except...:

...I shall leave the RFC Editor to decide which textual names of RFCs 
(with an internal space) to convert to citations in brackets. Reason: 
although the RFC Editor has often applied this conversion when 
processing my own recent drafts, I am not sure it is a universal rule, 
so I would rather leave the RFC Editor to apply their current style 
rules than sink time into doing it myself, possibly wrongly. For 
instance, the RFC Editor Style Guide states that textual naming of an 
RFC must include a space, which implies textual naming of RFCs must at 
least sometimes be appropriate:
https://datatracker.ietf.org/doc/html/rfc7322#section-3.5

I have just posted rev -21 with these changes.

Thank you again.


Bob

On 22/11/2023 19:59, Donald Eastlake wrote:
> I am an assigned INT directorate reviewer for 
> <draft-ietf-tsvwg-rfc6040update-shim-20.txt>. These comments were 
> written primarily for the benefit of the Internet Area Directors. 
> Document editors and shepherd(s) should treat these comments just like 
> they would treat comments from any other IETF contributors and resolve 
> them along with any other Last Call comments that have been received. 
> For more details on the INT Directorate, see 
> https://datatracker.ietf.org/group/intdir/about/ 
> <https://datatracker.ietf.org/group/intdir/about/>.
>
> Based on my review, if I was on the IESG I would ballot this document 
> as YES.
>
> This is a well written document that updates RFC 6040 and a number of 
> other RFCs to specify/clarify the propagation of Explicit Congestion 
> Notification (ECN) between inner and outer headers when separated by a 
> shim
>
> The following are minor issues (typos, misspelling, minor text 
> improvements) with the document:
>
> - The usual way to indicate values to be assigned by IANA is to say 
> "TBD" (or, if there are multiple, TBD1, TBD2, etc.) I think that is 
> what ZZ is supposed to be so I suggest globally replacing "ZZ" with 
> "TBD" and eliminating the phrase in curly brackets in the first 
> sentence of 6.1.1.2.1.  IANA and the RFC Editor know about TBDs and to 
> replace them.
>
> - The usual way to indicate a reference to the document containing 
> that reference is "[this document]". Suggest globally replacing 
> "RFCXXXX" with "[this document]" and eliminating the often repeated 
> direction in curly brackets to the RFC Editor to replace "RFCXXXX" 
> with the document. The RFC Editor knows about "[this document]" and to 
> replace it.
>
> - Although many RFC references are square bracket references, there 
> are many cases that just have "RFC" followed by a space and the 
> number. Suggest a global search for RFC followed by a space (or new 
> line) and replace with a square bracket reference.
>
> - Suggest spelling out 3GPP on first use and/or providing a reference.
>
> Thanks,
> Donald
> ===============================
>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>  2386 Panoramic Circle, Apopka, FL 32703 USA
> d3e3e3@gmail.com

-- 
________________________________________________________________
Bob Briscoehttp://bobbriscoe.net/