Re: [iola-conversion-tool] Bug in Datatracker Agenda Code?

Ryan Cross <rcross@amsl.com> Wed, 21 March 2012 14:17 UTC

Return-Path: <rcross@amsl.com>
X-Original-To: iola-conversion-tool@ietfa.amsl.com
Delivered-To: iola-conversion-tool@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2D0C521F86F3 for <iola-conversion-tool@ietfa.amsl.com>; Wed, 21 Mar 2012 07:17:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.39
X-Spam-Level:
X-Spam-Status: No, score=-2.39 tagged_above=-999 required=5 tests=[AWL=0.208, BAYES_00=-2.599, HTML_MESSAGE=0.001]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dYIYm5AsGvYo for <iola-conversion-tool@ietfa.amsl.com>; Wed, 21 Mar 2012 07:17:30 -0700 (PDT)
Received: from mail.amsl.com (mail.amsl.com [IPv6:2001:1890:123a::1:14]) by ietfa.amsl.com (Postfix) with ESMTP id A89BD21F86E4 for <iola-conversion-tool@ietf.org>; Wed, 21 Mar 2012 07:17:30 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by c8a.amsl.com (Postfix) with ESMTP id 9D0A612C98B; Wed, 21 Mar 2012 07:17:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
Received: from c8a.amsl.com ([127.0.0.1]) by localhost (c8a.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JIL--YoFVqdV; Wed, 21 Mar 2012 07:17:30 -0700 (PDT)
Received: from [10.0.1.3] (c-98-232-67-166.hsd1.wa.comcast.net [98.232.67.166]) by c8a.amsl.com (Postfix) with ESMTPSA id 47EFA12C98A; Wed, 21 Mar 2012 07:17:30 -0700 (PDT)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: multipart/alternative; boundary=Apple-Mail-5--302552436
From: Ryan Cross <rcross@amsl.com>
In-Reply-To: <4F5500BF.9050604@levkowetz.com>
Date: Wed, 21 Mar 2012 07:17:29 -0700
Message-Id: <874725C6-E6A1-4DE5-B3FE-3EA0618ECE6A@amsl.com>
References: <8F28AC7A-8D1D-465C-A92B-DCC07197DADF@amsl.com> <4F54DC2D.1000302@levkowetz.com> <11DE49D4-2C52-492F-A467-EEE22F19382A@amsl.com> <4F54EDF2.7020200@levkowetz.com> <D26A6771-EEE8-4819-9305-FCF3CC757FD8@amsl.com> <4F5500BF.9050604@levkowetz.com>
To: Henrik Levkowetz <henrik@levkowetz.com>
X-Mailer: Apple Mail (2.1084)
Cc: Alexa Morris <amorris@amsl.com>, iola-conversion-tool@ietf.org
Subject: Re: [iola-conversion-tool] Bug in Datatracker Agenda Code?
X-BeenThere: iola-conversion-tool@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discussion of the IOLA / DB Schema Conversion Tool Project <iola-conversion-tool.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/iola-conversion-tool>
List-Post: <mailto:iola-conversion-tool@ietf.org>
List-Help: <mailto:iola-conversion-tool-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Mar 2012 14:17:31 -0000

Hi Henrik,

On Mar 5, 2012, at 10:06 AM, Henrik Levkowetz wrote:

>  3. Even after I fixed the things above, I went 'round and 'round a couple
>     of times, as I only saw a blank space where the agenda should have
>     been.  This seems to have been caused by the uploaded document having
>     a mac character set encoding and mac line-endings -- Ryan, you maybe
>     should investigate that further, and see if you should do character
>     set and line-ending conversion.  I think what's on disk should either
>     be ascii or unicode -- for drafts we check that it's pure ascii, but
>     the agendas are different, and we should maybe enforce unicode?
Does this mean the code is parsing the agenda file?  Does it need to do this?  I'm happy to add character set validation, but this would affect everyone submitting agenda's so I want to be sure that is the official requirement.

Thanks,
Ryan