Re: [iola-conversion-tool] Bug in Datatracker Agenda Code?

Henrik Levkowetz <henrik@levkowetz.com> Mon, 05 March 2012 18:06 UTC

Return-Path: <henrik@levkowetz.com>
X-Original-To: iola-conversion-tool@ietfa.amsl.com
Delivered-To: iola-conversion-tool@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8F62521F87C3 for <iola-conversion-tool@ietfa.amsl.com>; Mon, 5 Mar 2012 10:06:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.513
X-Spam-Level:
X-Spam-Status: No, score=-102.513 tagged_above=-999 required=5 tests=[AWL=0.087, BAYES_00=-2.599, NO_RELAYS=-0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6AS3XCGjBwL6 for <iola-conversion-tool@ietfa.amsl.com>; Mon, 5 Mar 2012 10:06:57 -0800 (PST)
Received: from grenache.tools.ietf.org (grenache.tools.ietf.org [IPv6:2a01:3f0:1:2::30]) by ietfa.amsl.com (Postfix) with ESMTP id C08ED21F85D3 for <iola-conversion-tool@ietf.org>; Mon, 5 Mar 2012 10:06:57 -0800 (PST)
Received: from [2a01:3f0:1:0:21e:c2ff:fe13:7e3e] (port=65308 helo=brunello.netnod.se) by grenache.tools.ietf.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.77) (envelope-from <henrik@levkowetz.com>) id 1S4cJE-0001US-RQ; Mon, 05 Mar 2012 19:06:57 +0100
Message-ID: <4F5500BF.9050604@levkowetz.com>
Date: Mon, 05 Mar 2012 19:06:55 +0100
From: Henrik Levkowetz <henrik@levkowetz.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
MIME-Version: 1.0
To: Ryan Cross <rcross@amsl.com>
References: <8F28AC7A-8D1D-465C-A92B-DCC07197DADF@amsl.com> <4F54DC2D.1000302@levkowetz.com> <11DE49D4-2C52-492F-A467-EEE22F19382A@amsl.com> <4F54EDF2.7020200@levkowetz.com> <D26A6771-EEE8-4819-9305-FCF3CC757FD8@amsl.com>
In-Reply-To: <D26A6771-EEE8-4819-9305-FCF3CC757FD8@amsl.com>
X-Enigmail-Version: 1.3.5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 2a01:3f0:1:0:21e:c2ff:fe13:7e3e
X-SA-Exim-Rcpt-To: rcross@amsl.com, amorris@amsl.com, iola-conversion-tool@ietf.org, henrik-sent@levkowetz.com
X-SA-Exim-Mail-From: henrik@levkowetz.com
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on grenache.tools.ietf.org)
Cc: Alexa Morris <amorris@amsl.com>, iola-conversion-tool@ietf.org
Subject: Re: [iola-conversion-tool] Bug in Datatracker Agenda Code?
X-BeenThere: iola-conversion-tool@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discussion of the IOLA / DB Schema Conversion Tool Project <iola-conversion-tool.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/iola-conversion-tool>
List-Post: <mailto:iola-conversion-tool@ietf.org>
List-Help: <mailto:iola-conversion-tool-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Mar 2012 18:06:58 -0000

Hi Ryan, Alexa, all,

I think I've now got this working.  Both administrative and technical
plenary shows up as they should.

There were some assumptions which didn't hold, which lead to some code
changes, and there was an encoding problem with the agenda file on disk,
as follows:

  1. The code assumed that the uploaded document would have a title which
     indicated which plenary agenda it was for -- no title was set.  I've
     now changed the code to look at the document name instead.

  2. There were actually 4 different agendas which matched the plenaries,
     and the code didn't check for state active, so I added this.

  3. Even after I fixed the things above, I went 'round and 'round a couple
     of times, as I only saw a blank space where the agenda should have
     been.  This seems to have been caused by the uploaded document having
     a mac character set encoding and mac line-endings -- Ryan, you maybe
     should investigate that further, and see if you should do character
     set and line-ending conversion.  I think what's on disk should either
     be ascii or unicode -- for drafts we check that it's pure ascii, but
     the agendas are different, and we should maybe enforce unicode?


Best regards,

	Henrik


On 2012-03-05 18:20 Ryan Cross said:
> Hi Henrik,
> 
> I show two plenary Timeslots for meeting 83, both with a Session associated.  And both sessions with agenda material attached.  So the data looks good unless I'm missing some detail of scheduling plenaries.
> 
> In [38]: q=TimeSlot.objects.filter(meeting=83,type='plenary')
> 
> In [39]: q
> Out[39]: [<TimeSlot: 83: 03-28 16:30-19:30 IETF Operations and Administration Plenary, Amphitheatre Bleu>, <TimeSlot: 83: 03-26 16:30-19:30 Technical Plenary, Amphitheatre Bleu>]
> 
> In [40]: q[0].session  
> Out[40]: <Session: IETF-83: iesg 1630>
> 
> In [41]: q[1].session
> Out[41]: <Session: IETF-83: iab 1630>
> 
> Thanks,
> Ryan
> 
> On Mar 5, 2012, at 8:46 AM, Henrik Levkowetz wrote:
> 
>> Mmm, what I see here is "The plenary has not been scheduled", which
>> is a different matter.  I think this may be a failure in the scheduling
>> tool; it is possible that it hasn't connected the session with the meeting
>> slot (maybe because at the time the two plenaries were associated with the
>> same group?).  I'll try to dig a bit in the data to see what's up.
> 
> 
> 
>