IETF Logo Mail Archive

Re: [iola-conversion-tool] Bug in discuss/comment email

Ole Laursen <olau@iola.dk> Thu, 16 February 2012 16:44 UTC

Return-Path: <olau@iola.dk>
X-Original-To: iola-conversion-tool@ietfa.amsl.com
Delivered-To: iola-conversion-tool@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4DC3D21F8826 for <iola-conversion-tool@ietfa.amsl.com>; Thu, 16 Feb 2012 08:44:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.584
X-Spam-Level:
X-Spam-Status: No, score=-2.584 tagged_above=-999 required=5 tests=[AWL=0.393, BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PGsAA+rzq5jE for <iola-conversion-tool@ietfa.amsl.com>; Thu, 16 Feb 2012 08:44:31 -0800 (PST)
Received: from mail-vx0-f172.google.com (mail-vx0-f172.google.com [209.85.220.172]) by ietfa.amsl.com (Postfix) with ESMTP id B34B521F8823 for <iola-conversion-tool@ietf.org>; Thu, 16 Feb 2012 08:44:31 -0800 (PST)
Received: by vcbfk14 with SMTP id fk14so1851244vcb.31 for <iola-conversion-tool@ietf.org>; Thu, 16 Feb 2012 08:44:31 -0800 (PST)
Received: by 10.220.38.10 with SMTP id z10mr1729213vcd.48.1329410671142; Thu, 16 Feb 2012 08:44:31 -0800 (PST)
MIME-Version: 1.0
Received: by 10.52.96.130 with HTTP; Thu, 16 Feb 2012 08:44:10 -0800 (PST)
In-Reply-To: <4F3BE326.9050000@nostrum.com>
References: <4F3BE326.9050000@nostrum.com>
From: Ole Laursen <olau@iola.dk>
Date: Thu, 16 Feb 2012 17:44:10 +0100
Message-ID: <CANb2Ov+GER_HNvYKKY3dA11OGfKyv7YnzaKzj5oARi+oUeTXJA@mail.gmail.com>
To: iola-conversion-tool@ietf.org
Content-Type: text/plain; charset="ISO-8859-1"
X-Gm-Message-State: ALoCoQnj5YyfnVzbZo11wNc1Nm212Gxf8lUOExYRaoWUIEQmnJM4InHWyRyMo0eFAz0G8BjYQdkQ
Cc: Pete Resnick <presnick@qualcomm.com>
Subject: Re: [iola-conversion-tool] Bug in discuss/comment email
X-BeenThere: iola-conversion-tool@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Discussion of the IOLA / DB Schema Conversion Tool Project <iola-conversion-tool.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/iola-conversion-tool>
List-Post: <mailto:iola-conversion-tool@ietf.org>
List-Help: <mailto:iola-conversion-tool-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/iola-conversion-tool>, <mailto:iola-conversion-tool-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Feb 2012 16:44:32 -0000

2012/2/15 Robert Sparks <rjsparks@nostrum.com>:
> When adding a discuss to a document the mail that's generated is wrong (the
> subject line misses the discuss and the body doesn't have the discuss text.
> However the body says I entered a discuss.
>
> This is something I tested before and didn't see a problem. There is an
> automated test that should have caught this too.

I expanded the test slightly, and sure enough, fail. I was checking
the wrong attribute. Fixed now. Thanks to both of you!


Ole

v2.23.0 | Report a Bug | By Email