[Iot-directorate] Iotdir telechat review of draft-ietf-core-dev-urn-09
Russ Housley via Datatracker <noreply@ietf.org> Wed, 06 January 2021 21:41 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: iot-directorate@ietf.org
Delivered-To: iot-directorate@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 1162D3A12B7; Wed, 6 Jan 2021 13:41:45 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Russ Housley via Datatracker <noreply@ietf.org>
To: iot-directorate@ietf.org
Cc: core@ietf.org, draft-ietf-core-dev-urn.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.24.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <160996930502.21827.5533521556349871834@ietfa.amsl.com>
Reply-To: Russ Housley <housley@vigilsec.com>
Date: Wed, 06 Jan 2021 13:41:45 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/iot-directorate/tuv3TRsN_QUoV4qTBaaxuOltmUA>
Subject: [Iot-directorate] Iotdir telechat review of draft-ietf-core-dev-urn-09
X-BeenThere: iot-directorate@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Mailing list for the IoT Directorate Members <iot-directorate.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/iot-directorate>, <mailto:iot-directorate-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/iot-directorate/>
List-Post: <mailto:iot-directorate@ietf.org>
List-Help: <mailto:iot-directorate-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/iot-directorate>, <mailto:iot-directorate-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jan 2021 21:41:45 -0000
Reviewer: Russ Housley Review result: Almost Ready I reviewed this document as part of the IoT Directorate's effort to IoT-related IETF documents being processed by the IESG. These comments were written primarily for the benefit of the Internet Area Directors. Document authors, document editors, and WG chairs should treat these comments just like any other IETF Last Call comments. Document: draft-ietf-core-dev-urn-09 Reviewer: Russ Housley Review Date: 2021-01-06 IETF LC End Date: 2020-12-02 IESG Telechat date: 2021-01-21 A review from the IoT Directorate was requested on 2021-01-05, which is after the IETF Last Call ended. I assume that the Internet ADs want this review to help inform them during IESG Evaluation. Summary: Almost Ready Major Concerns: Section 3.2 says: The optional underscore-separated components following the hexstring are strings depicting individual aspects of a device. Not all of the DEV URN forms contain a hexstring; however, all of them are allowed to end with underscore-separated components. I suggest: The optional underscore-separated components at the end of the DEV URN depict individual aspects of a device. Section 3.2.1 says: ... and a MAC address could be represented either with uppercase or lowercase hexadecimal digits. This is not allowed by the ABNF: hexstring = 1*(hexdigit hexdigit) hexdigit = DIGIT / "a" / "b" / "c" / "d" / "e" / "f" If both cases are to be supported, the upper case letters need to be added to the ABNF to permit them. Section 4.2 says: ... 64-bit identifier that consists of 8 byte family code, 48 bit identifier unique within a family, and 8 bit CRC code [OW]. The math does not work. I suspect: s/8 byte/8 bit/ Section 6 says: ... An implementation of the DEV URN MUST NOT change these properties from what they were intended. It is not clear to me the meaning of "they" in this sentence. Please clarify. Minor Concerns: Section 3.2 says: DEV URNs do not use r-, q-, or f-components. I would have liked a bit more context here. I suggest: DEV URNs do not use r-, q-, or f-components as defined in [RFC8141]. Section 3.2.1 refers to "BASE64". Please add an informative reference to RFC 4648 to be clear. Section 4.1 uses the term "Ethernet" in two places. I think both of them should be replaced by "MAC-48". Nits: Section 3.2 says: However, due to the SenML RFC 8428 Section 4.5.1 rules, DEV URNs do not support percent-encoding. This does not seem like a "however" statement to me. Perhaps, it is a "Note that" statement. Or, just drop "However". Section 4.1: s/rests within the IEEE/ /rests with the IEEE Registration Authority/ Section 7 includes: "publicly available specification that can be pointed to." It is sufficient to say: ""publicly available specification."
- [Iot-directorate] Iotdir telechat review of draft… Russ Housley via Datatracker
- Re: [Iot-directorate] Iotdir telechat review of d… Barry Leiba
- Re: [Iot-directorate] [Last-Call] Iotdir telechat… John C Klensin
- Re: [Iot-directorate] [Last-Call] Iotdir telechat… Martin J. Dürst
- Re: [Iot-directorate] [Last-Call] Iotdir telechat… Russ Housley
- Re: [Iot-directorate] [Last-Call] Iotdir telechat… Barry Leiba
- Re: [Iot-directorate] [Last-Call] Iotdir telechat… Russ Housley
- Re: [Iot-directorate] Iotdir telechat review of d… Ãric Vyncke (evyncke)
- Re: [Iot-directorate] Iotdir telechat review of d… Jari Arkko
- Re: [Iot-directorate] Iotdir telechat review of d… Dave Thaler
- Re: [Iot-directorate] Iotdir telechat review of d… Dave Thaler
- Re: [Iot-directorate] [Last-Call] Iotdir telechat… Russ Housley
- Re: [Iot-directorate] Iotdir telechat review of d… Jari Arkko
- Re: [Iot-directorate] [Last-Call] Iotdir telechat… Jari Arkko
- Re: [Iot-directorate] Iotdir telechat review of d… Carsten Bormann
- Re: [Iot-directorate] [Last-Call] Iotdir telechat… Jari Arkko
- Re: [Iot-directorate] [Last-Call] Iotdir telechat… Russ Housley
- Re: [Iot-directorate] [Last-Call] Iotdir telechat… John C Klensin
- Re: [Iot-directorate] [Last-Call] Iotdir telechat… Jari Arkko
- Re: [Iot-directorate] [core] [Last-Call] Iotdir t… Carsten Bormann
- Re: [Iot-directorate] [Last-Call] [core] Iotdir t… Jari Arkko
- Re: [Iot-directorate] [Last-Call] [core] Iotdir t… Russ Housley