Re: [IPv6] Review feedback requested: draft-ietf-pim-rfc1112bis

Toerless Eckert <tte@cs.fau.de> Wed, 06 March 2024 01:02 UTC

Return-Path: <eckert@i4.informatik.uni-erlangen.de>
X-Original-To: ipv6@ietfa.amsl.com
Delivered-To: ipv6@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 976DFC14F708 for <ipv6@ietfa.amsl.com>; Tue, 5 Mar 2024 17:02:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.657
X-Spam-Level:
X-Spam-Status: No, score=-6.657 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XPvm2G_T9iqg for <ipv6@ietfa.amsl.com>; Tue, 5 Mar 2024 17:02:08 -0800 (PST)
Received: from faui40.informatik.uni-erlangen.de (faui40.informatik.uni-erlangen.de [131.188.34.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 135B1C14F5EC for <ipv6@ietf.org>; Tue, 5 Mar 2024 17:02:06 -0800 (PST)
Received: from faui48e.informatik.uni-erlangen.de (faui48e.informatik.uni-erlangen.de [131.188.34.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by faui40.informatik.uni-erlangen.de (Postfix) with ESMTPS id 4TqDfd4JWnznkPC; Wed, 6 Mar 2024 02:02:01 +0100 (CET)
Received: by faui48e.informatik.uni-erlangen.de (Postfix, from userid 10463) id 4TqDfd3Rdmzkn29; Wed, 6 Mar 2024 02:02:01 +0100 (CET)
Date: Wed, 06 Mar 2024 02:02:01 +0100
From: Toerless Eckert <tte@cs.fau.de>
To: Michael Richardson <mcr+ietf@sandelman.ca>
Cc: ipv6@ietf.org
Message-ID: <ZefAiaScHGcJnDP8@faui48e.informatik.uni-erlangen.de>
References: <ZeZNkgtrVqbe09wv@faui48e.informatik.uni-erlangen.de> <3680.1709673341@obiwan.sandelman.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3680.1709673341@obiwan.sandelman.ca>
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipv6/-K__Z4bc7lMSzP9g2ZT32gjxNWs>
Subject: Re: [IPv6] Review feedback requested: draft-ietf-pim-rfc1112bis
X-BeenThere: ipv6@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "IPv6 Maintenance Working Group \(6man\)" <ipv6.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipv6>, <mailto:ipv6-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipv6/>
List-Post: <mailto:ipv6@ietf.org>
List-Help: <mailto:ipv6-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipv6>, <mailto:ipv6-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2024 01:02:12 -0000

Thanks, Michael

The short answer re formatting is: the diff is IMHO almost perfect, aka: 99% of diff is payload diff.

The big removed paragraph from 7.2 and Appendix I are both about IGMPv1, so that goes away,
and the pictures in I are only the protocol header and state machiny for IGMPv1. So i think
removal of all of that is correct and was the top priority of the work.

Appendix b is all new writeup from me trying to explain some of the line of thinking that
lead to the changes made, hence to be removed, just for reviewers.

Cheers
    Toerless

The long answer re. formatting was that i was paranoid about creating useless diffs that PIM-WG
members wouldn't to read, and so to be save, i edited draft-eckert-pim-rfc1112bis-00 in txt to
guarantee a zero iddif formatting hickup when bringing the work to PIM-WG:

  diff rfc1112 -> draft-eckert-pim-rfc1112bis-00
  https://author-tools.ietf.org/diff?doc_1=rfc1112&doc_2=draft-eckert-pim-rfc1112bis-00

Then i converted to XML and i compared back to rfc1112:

  diff rfc1112 -> draft-eckert-pim-rfc1112bis-01
  https://author-tools.ietf.org/diff?doc_1=rfc1112&url_2=https://www.ietf.org/archive/id/draft-eckert-pim-rfc1112bis-01.txt

And given how that looks IMHO equally almost zero formatting diff,
i didn't bother to go back to convert rfc1112 to XML

On Tue, Mar 05, 2024 at 04:15:41PM -0500, Michael Richardson wrote:
> 
> May I suggest that you first do draft-ietf-pim-rfc1112-00,
> which would be just your updating of 1112 into kramdown/XML.
> 
> Then we can see which edits are just modernization of tools,
> and where the actual, substantive, meat is?
> 
> Appendix I goes away, and then we also have Appendix B (to-be-removed)
> Appendix I has a diagram, so maybe it's important?
> 
> --
> Michael Richardson <mcr+IETF@sandelman.ca>   . o O ( IPv6 IøT consulting )
>            Sandelman Software Works Inc, Ottawa and Worldwide



-- 
---
tte@cs.fau.de