IETF Logo Mail Archive

Re: [Lake] Genart last call review of draft-ietf-lake-edhoc-18

Göran Selander <goran.selander@ericsson.com> Fri, 20 January 2023 17:26 UTC

Return-Path: <goran.selander@ericsson.com>
X-Original-To: lake@ietfa.amsl.com
Delivered-To: lake@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 746EDC14CF1E; Fri, 20 Jan 2023 09:26:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.099
X-Spam-Level:
X-Spam-Status: No, score=-7.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8bvZgw8wCfjT; Fri, 20 Jan 2023 09:26:35 -0800 (PST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2055.outbound.protection.outlook.com [40.107.22.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B9058C14CF16; Fri, 20 Jan 2023 09:26:34 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lQr2e5CCQ6AUeLP7X9xP/Z4SMr8KQzENiwjbWgvqKQKWy7+dGq9QtkiPaTWzp/NlFO12RZznJYKRaiGvj9zKaBKGuEazYYIGTBjM3dhiL/nd3bXC4EOxvl7KUZOCojcWvFv7aODkrpJLpT293TQxBtD3yOSF/Ej8RT0vkEieB6ROmNDTxWvtzGL0M/stzFEWXTHDKlN0Er24Zav/0zGcy2xcKhiyUZQZsRuXzkR+5Eis46u6nIE7/y0IGNBshlDYAmuqjDVYO/hPX5BSuEgmzlyQKJFma/Y0cjCFh5Q6JpDS4ydFp2KG/vU9dMsfdiWaPBjsvITMfqcasq8+76hMrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MR1ZaNV2gsUvpRijDZ8siCIiGwRdvDthNx3LL0aXVdk=; b=NQQauMZBDcP3eEYsJxeQC4o0ttGQHGPuywRDd77zN48SQcGPI6ofVkPQ+W4Pics/H0uY1gkPsJLNtqsc+y7p6KijS9ddyBWcNZGZ5bxsGXIdd/zsOE7+aYLDhb252BRz5+MRPU67ivXymj3vPrpbLfPLqeAXjg7FHmV9KpBVdqlAZXTrKLK/CEpK+oK8nP1GBl22qXZ/GmxfL6TZvlwqOU6gxT6zwHIB1iAKy7PP990q8zde6zRpYZq+ofgva65AiQ638gLIzkNNDDzvUbBeek8eJAhD+ilmkdxCdqLTHgpamYtEkMhgQGnskCU2FPpa6IvBxfNUmYMyi+Y1+pE/cA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MR1ZaNV2gsUvpRijDZ8siCIiGwRdvDthNx3LL0aXVdk=; b=jQfZ1YjqdaigXiDeXkDU57tgIn2Z8gWlGFLrtVXONDJsa+oXZkjYXi3U9qKc5E2N1wDX4sC3JD8jAyRzhXWV8cZOgWwnx3ONeAIs/ahP9m0lJKG1hjui0GTTeADzMqrQFO6ecmusC6vqQ1g2TVHGUVm93LixRaWNWOlvx8sz19E=
Received: from PAXPR07MB8844.eurprd07.prod.outlook.com (2603:10a6:102:24a::19) by AM7PR07MB6897.eurprd07.prod.outlook.com (2603:10a6:20b:1b6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.27; Fri, 20 Jan 2023 17:26:30 +0000
Received: from PAXPR07MB8844.eurprd07.prod.outlook.com ([fe80::90a2:f0a6:8edc:153b]) by PAXPR07MB8844.eurprd07.prod.outlook.com ([fe80::90a2:f0a6:8edc:153b%5]) with mapi id 15.20.5986.023; Fri, 20 Jan 2023 17:26:30 +0000
From: Göran Selander <goran.selander@ericsson.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-lake-edhoc.all@ietf.org" <draft-ietf-lake-edhoc.all@ietf.org>, "lake@ietf.org" <lake@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-lake-edhoc-18
Thread-Index: AQHZFKwDwpMAHIkZX0O/APz0NXWjEq6lf4dR
Date: Fri, 20 Jan 2023 17:26:30 +0000
Message-ID: <PAXPR07MB88447683660B324238A68D9CF4C49@PAXPR07MB8844.eurprd07.prod.outlook.com>
References: <167156567611.30647.14224177801602345512@ietfa.amsl.com>
In-Reply-To: <167156567611.30647.14224177801602345512@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PAXPR07MB8844:EE_|AM7PR07MB6897:EE_
x-ms-office365-filtering-correlation-id: 838b8e62-760a-494c-d0fb-08dafb0b7835
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: bFc9G0goF1Z1Rt7C/RmrXbWu5HRKOtg9Fly2bZ0ezym+BSli2wB6XMF8BrU5NaQtrK7jtEt7bKxh6Gf2Us8lA+Yesm8qjGJmSNep4IzpYQ6E+AjggYZQ4Kf0GaqHLwPOZHkb6c2pnpPatqnoS+p47Emk2sazQhgyEWd//zsxycJIZRD2xeXb6ELKhgOzbEYoi/SkWOIv8wMkCYy/0k7C0qH6/6L6nxqbnSkUaXZ84nyB+dX6XeXcY+y4LXSeHN1cKC/XdKAHCforPazevaw6/MoCBsv1kXYDJHD1wmEoVdjbraLGMfPnsWgBvRsJHzapirD/nincR91/JQYTgDTQWFlSrgxzIENZoQHZMo18HbJuAMzfFZ0S4uX4PfR9NbUvBqhGBM6v/6PiVpN8AVgzF7hi5aVa1u8eWiPtONzstS06wkQGJfB+aWRUN6BZGSXYVp1/lKW1rikQvXKwwfSHfHl/lqwPZY3FhkjaprH9UU8V+/RU6kdyRoyhO54alYezBQJ7GsBRgVnuBJkx8P//4s0O1b3sSa+VDe2bMKuVEtnCRQyRPQu7FPf/vMs1ckZtVH4UY5urykK4tcuNwSXf7nAu2AzRMS5WVjv6WpZ8aCQU+XLVpkVOBTjEeIlq1apE+KuNt8BzLw9kAMfKmoLhBFzkBMTZ7cYzdHysPBHsrwRDPtrYAreW/eYV61K4U+2pe31gVyNrMQUafkUqHNy7IHd1xnuDrdNTqCsLtVG2UCE=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR07MB8844.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199015)(6506007)(33656002)(66899015)(55016003)(478600001)(54906003)(53546011)(7696005)(71200400001)(110136005)(966005)(66556008)(66446008)(8676002)(64756008)(66476007)(316002)(9686003)(186003)(450100002)(26005)(91956017)(76116006)(52536014)(8936002)(41300700001)(66946007)(5660300002)(83380400001)(86362001)(2906002)(4326008)(38100700002)(82960400001)(166002)(4001150100001)(38070700005)(122000001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: BJrFgclA5VH9V0Ehp3mSge7kBUeqBDq9LS27lwp+vW3oDY/5aLT+QMER98GbImZ9JnS9xokdpmHmPtOArQyDh0peNSTVOANVXQIEsyp2TnUHXDtuTMhyBz4ZsM1YzVQobBl6sm2yYzaZTWW4GWY6yc0ZiL/Ao/1WrZesiPPOYoXiTisA9BDg38+f2n1iRzmYMb1bCHu7ReksSU/zadG0tD4n5g7t9fhjooZQ2xwC20i4BEYUrUrx3Fb9p65HL+LoAl6kANO9yBKAFEZakwBG2Vr7wp7CqT7GcD/TnKU1Ri9jZHs2XTUdGyb6awQW/mT+AzMTu5xnmE+XW+WgSrTrxVkfBY7XKhj77jk/AoCrRsVjyaRFCfj2E1MxR4diVkYt16Tpc0LA1ZsRUslRcg0lFbRIBb4hUvYy2KDxVHKXCeGhuqNDw2prBEUFhqC/no9dWOavsibE8Nhg/aojfujCq9wrwffuQtD5No62mxrYrlyMpqq4spspEmzeQ4tDjnl6j1lPUnF55AMfww4l5mdDQmucfRlPspKsocmWectQ3YuwANqjcU2m9x5GaJB2XZjw+U7OHfOodKwjQKo1iTBDOFO5Y9Zh8CQvuCWICXIApf7o8U/knHgxKMiHyqGxg1yhkJarAiFGVKTG3OuYAUkO9r77m5LoPD4npmrKBb5ys0im1E1257wIq32WAdzs5sewMmfmR4tw/2H+gdFxakhnwZNHKMGCURQUxACgJWkcUkgwpxSp6D6eJFbTJe5uK02Qn2KSSNgtJLuqhjyx7I9IePKaDhiBVDjHc9/7UwoexG4FRCOIoYTnCUi161WP0GmlEn72UCBbeH34JzQYuMw5fmcGqph18TE/uY8J/eVk8Ils/o3TSsuDN66zzIhN9c/w3NPeZDgjcqfjQgUo4n1F/f/AfJFhM6WinGuQpR2qUxvVyRCEbMSN+/3NtmOdabpc/Mb3e/lbNGE4bf5DB+r4ktYYK0GXKO+fboOMoDLufwp9ky9g7vi3RbUFoORod/DszwR3fqCLFw4rZzrFOscvqYEkyvfiqteuvIuop4IDQ6GgQRznhS1q0M3NZfSyukUIE1/T/K3qgHUaiMhrFbK+e10iFsqaYVEV9MdoAoOq8eqr4tzCEiX+C0AEX1h/JNiKw4MTB75diXTtYcCz1Ebt20fTzjiIYo45DVa50peS1oj3J8f3Hy8s2gLKyTNeO1z4DWmwPmXyLi70JEbV9x5T5FqCE8eloSvVVH1IXcrIeiEaUgmo0FjhP0gFclxm1BPyn47ARO+9qBROWXqJoZKOdEj0gIrl/Ki9yLxZE4AQRz1Efhu4aDid1mzvS2SlQnLo0Wl9WQecJY8IMlQ8F0GGNJ1G0uVsmhT5cRebCj2Tx+4pDJpS/AZNysnfhtTnvaDCajDfy8W3IkGhMsTgyg3Br5jlWJ+uj1KQ1iQ1oPUe0lIOzd5Vg+3VUVvgj7J9srFz0V+TvaTIJafbWVajBK6Cvhvmmfc/2CTpx/XkYYT5118wvRa92Kb/eojiiReuNLEq+mWdGWte5KdD0DRpb8Rq+/1NFrb+9gwYg3XdMcnPYEftwcBgK0qGD9NQPcHwiQXHJ51UNdJiOVJ5S0RUdAZPW1lpDq8PTwBispKHlSVILYk=
Content-Type: multipart/alternative; boundary="_000_PAXPR07MB88447683660B324238A68D9CF4C49PAXPR07MB8844eurp_"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR07MB8844.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 838b8e62-760a-494c-d0fb-08dafb0b7835
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2023 17:26:30.5726 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XSveMA8Qzxl8DDnzm5iM7BA1Ewx6gby1ZXO38CCE3JtPwLG6TlvyGNqcRMiHmYNs/b3j9XRvy+gE61I2otJJQ7AWg+gyuVuOiZXgQ6CMw3k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR07MB6897
Archived-At: <https://mailarchive.ietf.org/arch/msg/lake/gS6lE7fEvKQr_VCPZDjzU3yBQf4>
Subject: Re: [Lake] Genart last call review of draft-ietf-lake-edhoc-18
X-BeenThere: lake@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Lightweight Authenticated Key Exchange <lake.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lake>, <mailto:lake-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lake/>
List-Post: <mailto:lake@ietf.org>
List-Help: <mailto:lake-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lake>, <mailto:lake-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jan 2023 17:26:39 -0000

Hi Christer,

Thanks very much for your genart review. We have tried to address your comments in PR #390.
https://github.com/lake-wg/edhoc/pull/390

Inline response below. Further comments are welcome.

Thanks,
Göran

From: Christer Holmberg via Datatracker <noreply@ietf.org>
Date: Tuesday, 20 December 2022 at 20:48
To: gen-art@ietf.org <gen-art@ietf.org>
Cc: draft-ietf-lake-edhoc.all@ietf.org <draft-ietf-lake-edhoc.all@ietf.org>, lake@ietf.org <lake@ietf.org>, last-call@ietf.org <last-call@ietf.org>
Subject: Genart last call review of draft-ietf-lake-edhoc-18
Reviewer: Christer Holmberg
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-lake-edhoc-18
Reviewer: Christer Holmberg
Review Date: 2022-12-20
IETF LC End Date: None
IESG Telechat date: Not scheduled for a telechat

Summary: The document is well written, and easy to read. I do have one minor
issue that I would like the authors to address.

Major issues: N/A

Minor issues:

Q1: The document talks about the Initiator and Responder roles, what messages
they send etc. But I can't find a definition of what the roles. I assume the
Initiator initiates something, but unless I have missed it it would be good to
have a few word of role definitions.
The Initiator is basically defined by the party sending message_1 and then the messages alternate between Initator and Responder. We added some more text to clarify this.
Göran



Nits/editorial comments: N/A

v2.23.0 | Report a Bug | By Email