IETF Logo Mail Archive

Re: [Lake] [Gen-art] Genart last call review of draft-ietf-lake-edhoc-18

Lars Eggert <lars@eggert.org> Tue, 22 August 2023 08:22 UTC

Return-Path: <lars@eggert.org>
X-Original-To: lake@ietfa.amsl.com
Delivered-To: lake@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 299B8C15107A; Tue, 22 Aug 2023 01:22:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.108
X-Spam-Level:
X-Spam-Status: No, score=-7.108 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XruonS-Em2hq; Tue, 22 Aug 2023 01:22:52 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5A539C169528; Tue, 22 Aug 2023 01:22:52 -0700 (PDT)
Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C06E880923; Tue, 22 Aug 2023 11:22:46 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eggert.org; s=dkim; t=1692692568; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=F55qr/eUmFOnM+QFC4uTXj+cCggu3dzm7sKdeWxr95M=; b=QNd9wozVMfD2eeCqllQQ8t3gVLZvax19wR8F9bfS1i+GYQBEpEtCvMWyBQCLH+Q6tkd+JI xj1C7kOKzbFazdkYjHKW7LaPMXNRvjnMZGCXRQz6DBnDX82xtbF85uOuCht41Q45ePR74w TI+6fQ8FGlEnFCNfRPKXSV13YwxHJTIVksPCeB2FwxbYQqomJveAceaV3cESwRFYyn7mk+ l0PZRVPzB4vNMKH3h5piI7CPkPLrGQf41gDulGehMCxl5LnvAnOnpXNqv0upN9Z3ZkIVBe u5vP5C2uEhalQmPTJCVC7LqgehCqHV/oL7QE7K7cmtsujkqqDtkGw8weFQVCyw==
Content-Type: multipart/signed; boundary="Apple-Mail=_EB893ADC-0B4A-459D-B4A2-BF958AA3DB82"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <167156567611.30647.14224177801602345512@ietfa.amsl.com>
Date: Tue, 22 Aug 2023 11:22:46 +0300
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-lake-edhoc.all@ietf.org, lake@ietf.org, last-call@ietf.org
Message-Id: <4C206207-7F41-48F2-A37A-F6A36969AD7B@eggert.org>
References: <167156567611.30647.14224177801602345512@ietfa.amsl.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-Last-TLS-Session-Version: TLSv1.2
Archived-At: <https://mailarchive.ietf.org/arch/msg/lake/mBQiPKaGCkJovdYWfiN0qsARt4Y>
Subject: Re: [Lake] [Gen-art] Genart last call review of draft-ietf-lake-edhoc-18
X-BeenThere: lake@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Lightweight Authenticated Key Exchange <lake.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lake>, <mailto:lake-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lake/>
List-Post: <mailto:lake@ietf.org>
List-Help: <mailto:lake-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lake>, <mailto:lake-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Aug 2023 08:22:56 -0000

Christer, thank you for your review. I have entered a Discuss ballot for this document based on my own review.

Lars


> On Dec 20, 2022, at 21:47, Christer Holmberg via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Christer Holmberg
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-lake-edhoc-18
> Reviewer: Christer Holmberg
> Review Date: 2022-12-20
> IETF LC End Date: None
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: The document is well written, and easy to read. I do have one minor
> issue that I would like the authors to address.
> 
> Major issues: N/A
> 
> Minor issues:
> 
> Q1: The document talks about the Initiator and Responder roles, what messages
> they send etc. But I can't find a definition of what the roles. I assume the
> Initiator initiates something, but unless I have missed it it would be good to
> have a few word of role definitions.
> 
> Nits/editorial comments: N/A
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email