IETF Logo Mail Archive

Re: [Last-Call] Genart last call review of draft-ietf-lsr-isis-flood-reflection-10

Antoni Przygienda <prz@juniper.net> Sat, 22 October 2022 09:48 UTC

Return-Path: <prz@juniper.net>
X-Original-To: last-call@ietfa.amsl.com
Delivered-To: last-call@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 75D2AC1524A6; Sat, 22 Oct 2022 02:48:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.677
X-Spam-Level:
X-Spam-Status: No, score=-7.677 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.571, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b=FWkPgCas; dkim=pass (1024-bit key) header.d=juniper.net header.b=YYGgo1BI
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sm-3NYGkaYee; Sat, 22 Oct 2022 02:48:40 -0700 (PDT)
Received: from mx0a-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9661BC1524A2; Sat, 22 Oct 2022 02:48:40 -0700 (PDT)
Received: from pps.filterd (m0108159.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29M9h19H013695; Sat, 22 Oct 2022 02:48:38 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=PPS1017; bh=T43DvQOXfkZRokgmYxc6ALfjGqXXjHXF6Mq5Yp0OMPI=; b=FWkPgCasAva3a2aoeJL6vb+9AjvgcaW0E1AM8QKNP7IvsCMxltjbuj4ZvutvHZ/CJlGh O9b4Y2kIe15IOkS5hl7Ffd4A5aSGQZU40UUDk6g8pKcEfZa6FnXsBnZZonPJltW6V5ZW 2nv1Xfa8NiGTgv8UNWf6vepwsVK3Af7Ir9RRgy+LvC/uw/3WD8WKANV7LtMrUeHcL2AT BnnKsNKVfB4WazdqBuM7XhY0Ro+60uWt8UY7A+s1h69zoWw6+qsM8nmwxg1M+sYIdiXg CbOzYzHQcfvbCvxErXPHu0U3k837h/xE0ubCukeCBkHLjDAwYfXU+26NIYSGOgAlDj9j tg==
Received: from na01-obe.outbound.protection.outlook.com (mail-eastusazlp17010007.outbound.protection.outlook.com [40.93.11.7]) by mx0a-00273201.pphosted.com (PPS) with ESMTPS id 3kbt7q1rvr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 22 Oct 2022 02:48:38 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PX72Vvnk+g1lCCilSWO36+Pvk8dPvzSX2ve5Ecnj7BtR5uc5j6Hca9Y4re1FZ/CAZr+jnCXdriJdfG74PFZVf5gT9WsOVsmBkEL7LngedQUvw/CoBUSCcSwXnRep4ZEOW6FG/8oH5J1ubPNZlKVsDjV5hLrfJmZmeqjtQ5D94VEYrFNXmfpThdc6e49VL1R6v3oI1JHBy2oiehOBGzskeDCblGRZiEW1U87PhpXgDWFWUZ1ysTvVS84HNBrndj8552JlddVlOf6xrP8zOReCS1cax3SG3pzPMrOZchyPIXXhQMTcKNFtLlUnHPGLFihee8xl3yUYh1sxz3Xfmmm4Ew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T43DvQOXfkZRokgmYxc6ALfjGqXXjHXF6Mq5Yp0OMPI=; b=UaPJBJhL1qUCcLI8nNqaFQLCnCHMp4oepK+APlpeJeKKJZMyi4NSbpAg8Ge85gXo7A6YTSVylRgj3QEIxxBsR4bvfMd0/XdBa/BvcYeJbucHvr1mITu81W7sk/wXxSdd6klE2ahUM+V5VsB3ACmwhydDKzUueTOBONwBhwFv0Ru+9IMiKRGffv44YMS/IsJWCO8nEjFJY/hmQHuFEJjhr8HvtqqTIl0AuYN5ua/SR+R/0/qaVbjhfrHDDNojoqqst1J1DUVbp+VtbJrdjB+LrdBJnyqt+cbgX1tQ6TnPa21RLronz6EY6KWoRNArqShG7U25qctU2eb3fDU5G2IXUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T43DvQOXfkZRokgmYxc6ALfjGqXXjHXF6Mq5Yp0OMPI=; b=YYGgo1BIFxtoRYlpH0cLYhRd9UaaXZtox2tq0eF0EZI7PC/+rbqFacWPIswKhApVa70YxanydbdKCgeqGJAG/Q9PH+GZ0LCgztx1H4/1aArLtKLLdh/TGJQymarX8KL0/hl1jI0AEkpwSg0ZxMgE5ZlZp/eiVTQYw8UE6iqnEyI=
Received: from CO1PR05MB8492.namprd05.prod.outlook.com (2603:10b6:303:eb::7) by BYAPR05MB4134.namprd05.prod.outlook.com (2603:10b6:a02:8f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.17; Sat, 22 Oct 2022 09:48:33 +0000
Received: from CO1PR05MB8492.namprd05.prod.outlook.com ([fe80::ea5d:bc1f:c661:e50a]) by CO1PR05MB8492.namprd05.prod.outlook.com ([fe80::ea5d:bc1f:c661:e50a%5]) with mapi id 15.20.5723.020; Sat, 22 Oct 2022 09:48:33 +0000
From: Antoni Przygienda <prz@juniper.net>
To: Roni Even <ron.even.tlv@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-lsr-isis-flood-reflection.all@ietf.org" <draft-ietf-lsr-isis-flood-reflection.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-lsr-isis-flood-reflection-10
Thread-Index: AQHY2hDn4Pl92LZ/7ka83BMBU/vpFq4aQevI
Date: Sat, 22 Oct 2022 09:48:33 +0000
Message-ID: <CO1PR05MB84927AD19E4A9C79C632E342AC2C9@CO1PR05MB8492.namprd05.prod.outlook.com>
References: <166512190677.20914.3679501208641389602@ietfa.amsl.com>
In-Reply-To: <166512190677.20914.3679501208641389602@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-Message-Flag: Flag for follow up
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=True; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2022-10-22T09:45:31.3200237Z; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CO1PR05MB8492:EE_|BYAPR05MB4134:EE_
x-ms-office365-filtering-correlation-id: a646a39a-b7b7-42da-33b5-08dab4129578
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Z5dqBBwUzVkdvAoKqF6FbJsvOo+dQZe8iRCVN18c392U77XlrsfRI/Vpe8hMT8+BmuT6wENxg2tswiJq79nN4DDZ51cn++zZUOhPDt3z5jsRRZgfuUn9VuSbmkrhbJfrViMwUiiCCtlHpQHRhEOrVS1eV0sjKOlvilzEhjRrAKQF5KWdTOxgWRsn61CFUJH6mEIRF2UhNk6ywllKXUqzNH7DM8ZopzYTLEbTjpmUp2pcJvBUWXOjbuUcP1UiEtu5kOSzliUEQycNqd6KSENChwc+C1WokitEQZ/JAydX0lPh+LAVGXBk7trN1vwCsYqG/5/VS4s6ExTZxVDV1G2J8MwgtDyUhnpp0fqaUZshH4OHyuOW+YdCxW7NwNxxUELd5LcgU8gX5lZD5uHiWofbJJrC5AvpwiZZbhYcTVH1aEAGH3LzEQFVVhwtU4EjOa8ETXkaW2MYdqBTx9jBQgju5QmslEfkmM4ukJExGGPg4ooM3DmQJBRZmXp0lJvTHzUoFwgDFlGDfTv05FkL7apvLZGlOrndgQQT5TBRO4AUGTbYvcLPrEBORth6XQy53yDQW2gSKecqpdk6sQ3WoMWKizUqgfTyNOlPLbBzIalDRaVkmZHqic3afiMExRv2iemZpZYvUgz9MbVoKHX0gDsmlnWZ9rX75ncjbk7EAEpfAhNpzf2i84KNj/qzsyD3RFLvE5zFVabULnCzVNA99Y8k6KYVgTC5glLTLZUu6DUM+bcSwHBLSZcGiL66HduemHAcoNIsy3tPUJYqCkzN2NDVthQYZSLVydBHYK6P98mxusM1Ujg8ZDsJnSv4kMJjZvp3kDrAdT7rPmBqFDGSV3AH6A==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR05MB8492.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(366004)(136003)(376002)(396003)(346002)(451199015)(110136005)(53546011)(186003)(8936002)(5660300002)(52536014)(66556008)(91956017)(26005)(54906003)(66446008)(64756008)(8676002)(33656002)(66476007)(66946007)(9686003)(76116006)(7696005)(6506007)(55016003)(122000001)(41300700001)(316002)(71200400001)(478600001)(38100700002)(4326008)(38070700005)(86362001)(4001150100001)(2906002); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: nWLKpcpG2RdLLpqNHq6XMEguGg1rwsP74JCp0D8owcptkyy/SVYMUbKW+dvlKyq7TgOGT8ISnPPB7ZUx6nsHZDE9P5UqONPQMrXGBGaSfZk0x4+BWPVq1Mx6H/1FrNpb1XzZOKJgQqcK70Nri5yycK1l+BgkccqUBduFQKai1+eZ1UPmA8uUgKrxb7oFvYketqomS33O6//2IwPilEZZtBkFU6soyWR2qw4Rw0b7gHULmSjXbPjvYMd9NDxl0yUOTgYd77XcsgfUNvSzpjd6sVpsvhEF2klYsT6Tig5cy6d0GSfKQfHPmYZ8PyKr2cRbWOt0VhPTJUhqURuzzRWxGvS2gi2TVcCmggiDgYO+9X9Bxy/VaUfArCfBp9Li/IT2EM8D3jsflV0k+7oVJ96zTZvV8ZUqhD4MuTxZ6H6SNKuTHryRvPIZ8+vSZKF90lXxieGyqIKo6yE9tGpDD2usKpxfpblFFJ7O7qyE8EKoSPBb3phldin3B2J//KkLTTgeBMCdArCMSIeQgMfph88gdjox0Uq/NmPoxw6K7bw08rL8HG758bWKvDEd0YVM0MU3THkyV8WfXXWd8k7gVs7UGwPQ4dMGkQBSIQ7D0t2NCS8uWNe+OIO37yUUr/untKgnGzZPQ2+TW1zX7v1oK4iovr6qFKrLq4kggXDPe1fbtR5PWdVDmoen4d+Q4b+5DzOYv9cCKIm/VImIXG0p64mBpm8QxJdatFLDKu98JYVBC2wRjwBRqd5R73VNNbxdexp1Hikk6N9lquksviD09TlpGVzmWe0naBkdl8uqLyfUKcj+wAbZblhfc+jx7TwM3axesTQxHCDABI69TG9y389dXqwrWnw6sBTr0IgrmdlDmv7K+DfxJ6MOH4YpqVef/eIBPJAazypBVsfXlY+LxACYH1lLbjxwR8Yal/0KOJkg6MvTKN9wbd7uQPCX/3DGpiJOn87JjHjHLNOn6OByIbPSNmeNra32ZQnvJOn5fkt4cICCJbKK+mjMjVHR4+5EpRaUf8y++xtZi1xHJaj5qorb8F2p1ztiFJ6Hp5HYDa7UmMK7kWWaga5bVY1Mhh9JTDeTQ6i0M7vgZXZYnJPt/uFbq+nnTifwe55dvOxxm0oTwWlEQfJ6KupTPZp42Ry6V0eJhES+fp+TbyI0Fe6sUoSxyxr0LigItva6dYXMNhfWnY1zgPaK6yGIZ+UQxbDsxo7vQhGsZeK7GVfsN+FDu3hWuIIeAPc34U+FCJaYE8IXieaSQa5TZ2+jSDJgWZ+BwRcoel8U/qgZfuVdI0zB3MtB5GeIFKDpMN9QJnM3eY8PUyD2w+jbEvt3Pii8/LaroGE0CyZaroAsqSTFUkzND2X/ZJLRnXrQxOicDQpepcL5v25KpUxcCVd3tq865C4GuYVVqbprJfsKR7QWVNL7jeg4qO8pOI0tVkvxscFcD+MO3VDkgfR3vlTUarWkhFku40lzegM8PTa37VNXeDo4OyApsO3Z1QR2rThJDfhQqSICGXsveIaoid1Qe5z2Er1bRH9pkl+n46JRJaoEfXQiOo5Ds8Spht6sI0lsavxORlPdTOmCVty/M+M+TDk3fMCAowpe
Content-Type: multipart/alternative; boundary="_000_CO1PR05MB84927AD19E4A9C79C632E342AC2C9CO1PR05MB8492namp_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR05MB8492.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a646a39a-b7b7-42da-33b5-08dab4129578
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2022 09:48:33.6284 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: N1xicj2X6D8Hx46KrjnCi1s3qnjB4IhJ7iAeLnXlw/3cKnuhRd4LnTl0SWAm6jk+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB4134
X-Proofpoint-ORIG-GUID: E46vw23cjz0a7x42LogJUbKe9JBV_qW8
X-Proofpoint-GUID: E46vw23cjz0a7x42LogJUbKe9JBV_qW8
X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 mlxlogscore=999 priorityscore=1501 mlxscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210220061
Archived-At: <https://mailarchive.ietf.org/arch/msg/last-call/xidb4QtCS3eOFE6KEymqko-O1bI>
Subject: Re: [Last-Call] Genart last call review of draft-ietf-lsr-isis-flood-reflection-10
X-BeenThere: last-call@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF Last Calls <last-call.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/last-call>, <mailto:last-call-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/last-call/>
List-Post: <mailto:last-call@ietf.org>
List-Help: <mailto:last-call-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/last-call>, <mailto:last-call-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Oct 2022 09:48:45 -0000

Roni, thanks for your comments


  1.  We traditionally do not specify length, one reason being that TLV format allows sub-TLVs and hence the length encompasses those as well
  2.  Clarified the case a bit and added the coma


  *   Tony

From: Roni Even via Datatracker <noreply@ietf.org>
Date: Friday, 7 October 2022 at 07:51
To: gen-art@ietf.org <gen-art@ietf.org>
Cc: draft-ietf-lsr-isis-flood-reflection.all@ietf.org <draft-ietf-lsr-isis-flood-reflection.all@ietf.org>, last-call@ietf.org <last-call@ietf.org>, lsr@ietf.org <lsr@ietf.org>
Subject: Genart last call review of draft-ietf-lsr-isis-flood-reflection-10
[External Email. Be cautious of content]


Reviewer: Roni Even
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://urldefense.com/v3/__https://trac.ietf.org/trac/gen/wiki/GenArtfaq__;!!NEt6yMaO-gk!FMPCwmdM-Z1EIR4yFEyR7C_FLew4r6SlM2STtoLgzHhAdQ1LPulnOj-UOYy0Uh52huMa_vfnmXW0$  >.

Document: draft-ietf-lsr-isis-flood-reflection-??
Reviewer: Roni Even
Review Date: 2022-10-06
IETF LC End Date: 2022-10-10
IESG Telechat date: Not scheduled for a telechat

Summary:
The documents is ready for publication as an experimental RFC with nits

Major issues:

Minor issues:

Nits/editorial comments:
1. in sections 4.2 and 4.4 I think that the length field is always 5. so why
not specify this value. 2.In section 7 second paragraph I am not sure what is
the meaning of "very very corner case". is it a unique case or a rare case or
just a corner case? also should there be a comma after "only" so it should be
"only, in which ..." otherwise I am not sure what the sentence means.




Juniper Business Use Only

v2.23.0 | Report a Bug | By Email