Re: [Lsr] Comments on draft-zhu-lsr-isis-sr-vtn-flexalgo-07

"Dongjie (Jimmy)" <jie.dong@huawei.com> Wed, 20 March 2024 23:29 UTC

Return-Path: <jie.dong@huawei.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 70804C151065; Wed, 20 Mar 2024 16:29:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.907
X-Spam-Level:
X-Spam-Status: No, score=-6.907 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o1AotTmJu7Wv; Wed, 20 Mar 2024 16:29:58 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 30E60C151090; Wed, 20 Mar 2024 16:29:41 -0700 (PDT)
Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4V0PtS5CrWz67bJY; Thu, 21 Mar 2024 07:29:04 +0800 (CST)
Received: from lhrpeml500006.china.huawei.com (unknown [7.191.161.198]) by mail.maildlp.com (Postfix) with ESMTPS id 349A1140517; Thu, 21 Mar 2024 07:29:38 +0800 (CST)
Received: from dggpemm500008.china.huawei.com (7.185.36.136) by lhrpeml500006.china.huawei.com (7.191.161.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 20 Mar 2024 23:29:37 +0000
Received: from kwepemd100004.china.huawei.com (7.221.188.31) by dggpemm500008.china.huawei.com (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Mar 2024 07:29:34 +0800
Received: from kwepemd100004.china.huawei.com ([7.221.188.31]) by kwepemd100004.china.huawei.com ([7.221.188.31]) with mapi id 15.02.1258.028; Thu, 21 Mar 2024 07:29:34 +0800
From: "Dongjie (Jimmy)" <jie.dong@huawei.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>, "lsr@ietf.org" <lsr@ietf.org>, "draft-zhu-lsr-isis-sr-vtn-flexalgo.authors@ietf.org" <draft-zhu-lsr-isis-sr-vtn-flexalgo.authors@ietf.org>
Thread-Topic: Comments on draft-zhu-lsr-isis-sr-vtn-flexalgo-07
Thread-Index: Adp7DRO7OQDSaEHHSu+gOiG5m8mGBgACSgJw
Date: Wed, 20 Mar 2024 23:29:34 +0000
Message-ID: <06c715d1b00f4a2fa3ed2ba0fdacc93a@huawei.com>
References: <BY5PR11MB4337517A2F56C0502753F69FC1332@BY5PR11MB4337.namprd11.prod.outlook.com>
In-Reply-To: <BY5PR11MB4337517A2F56C0502753F69FC1332@BY5PR11MB4337.namprd11.prod.outlook.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.126.201.210]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/3r_vE_w-lgJwhXmwfXdJUA_0-As>
Subject: Re: [Lsr] Comments on draft-zhu-lsr-isis-sr-vtn-flexalgo-07
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Mar 2024 23:29:59 -0000

Hi Les,

Thanks for the review and comments. 

Please see some replies inline:

> -----Original Message-----
> From: Les Ginsberg (ginsberg) <ginsberg@cisco.com>
> Sent: Thursday, March 21, 2024 7:32 AM
> To: lsr@ietf.org; draft-zhu-lsr-isis-sr-vtn-flexalgo.authors@ietf.org
> Subject: Comments on draft-zhu-lsr-isis-sr-vtn-flexalgo-07
> 
> This draft discusses how to use flex-algo in support of Network Resource
> Partitions (NRPs). In particular, it proposes to use a combination of L3 links and
> L2 Bundle member links as the topology associated with a given NRP. In those
> cases where an L3 link is using an L2 bundle and individual bundle members
> are "assigned" to different NRPs, it then proposes to associate the parent L3
> link with multiple flex-algos. The intent seems to be to utilize the L3 algo
> specific SIDs to assign the traffic to subsets of the L2 Bundle members.

Your reading of the intent of this document is correct. 

With the proposed mechanism, traffic with Flex-Algo specific SIDs could be steered to different partitions of the L3 link resources. 

The only thing I'd like to mention is the L2 bundle members could be virtual or physical, they are just used to represent different subsets of the link resources.


> This is extremely problematic.
> 
> The output of the L3 algo-specific SPF will be to install nexthops pointing to the
> L3 interface for packets which arrive with the L3 algo specific SID. But since the
> intent is to only forward traffic for a given algo specific SID via specific L2
> Bundle members, the L3 forwarding entries will have to be overwritten - in a
> manner not specified by the draft.

Section 4 of this document specifies the required forwarding plane behavior and the forwarding entry installation.


> The implementation complexities this introduces arise because the proposed
> solution attempts to use a Layer 3 technology (flex-algo) to control the use of
> L2 links. This should not be done.

In the proposed mechanism, Flex-Algo is still used for constraint path computation, and only the L3 links attributes are used in the computation. The L2 member links are only to partition the resources used by different Flex-Algo traffic. 


> Indeed, even independent of flex-algo, trying to use a Layer 3 routing protocol
> to control traffic flow on an L2 sub-topology is broken.
> It means that the L2 bundles have been improperly defined for use by the L3
> routing protocol.

There is no routing computation based on the "L2 sub-topology", as L2 bundle member links are not visible in the L3DB. All the Flex-Algo computation is based on the attributes of L3 links.


> RFC 8668 defines the advertisements of L2 Bundle member link attributes by
> IS-IS. The introduction of RFC 8668 states:
> 
> "...the new advertisements defined in this document are intended to be
> provided to external (to IS-IS) entities."
> 
> This means these advertisements are not to be used by the routing protocol
> itself. The association of these advertisements with the Layer 3 SIDs defined by
> Flex-Algo is a clear violation of the intended use as stated by RFC 8668.

As stated above, L2 bundle link attributes are not used in path computation. The Flex-Algo specific SIDs still point to the L3 interface based on that computation. The only change is that a Flex-Algo SID can further points to the resource of an L2 member link (consider it as a subset of the resource of the L3 link if that is easier to understand). So the L2 bundle information is only used for associating different Flex-Algo SIDs with different subsets of resources of a l3 link.  


> This draft should be abandoned.
> 
> NOTE: None of the points above should be interpreted to mean that flex-algo
> cannot be used in support of NRPs. (Whether that is a good idea or not is out
> of scope for this discussion).

AFAIK people are talking about using Flex-Algo to support NRPs. This document provides a solution to meet their needs. 


> But the proper way to do that is when the NRP maps to an L3 topology. Such a
> usage is fully supported by RFC 9350 and there is no need to write an
> additional document to define how this is to be done.

In some cases it is possible to map different NRPs to non-overlapping L3 sub-topologies, while in many other cases the same L3 link needs to participate in multiple NRPs, each of which is assigned with a subset of the link resources. The latter case cannot be supported by RFC 9350, and it is the target of this document. 


> In cases where an NRP maps to an L2 topology, some other mechanism needs
> to be defined as to how forwarding entries for a given NRP are determined and
> installed. Such a mechanism would qualify as "external to IS-IS" and therefore
> could make use of RFC 8668 advertisements.

This document also provides descriptions about this. As I mentioned it is after L3 computation, and makes use of the L2 bundle information. 


> But attempts to utilize the Layer 3 Flex-Algo technology to control traffic flow
> in an L2 topology are misguided and flawed.

As long as Flex-Algo is used for L3 topology based computation, IMO it still complies to RFC 9350. 

Best regards,
Jie (on behalf of coauthors)

> 
>    Les