IETF Logo Mail Archive

Re: [Lsr] AD Review of draft-ietf-isis-mpls-elc-10

Peter Psenak <ppsenak@cisco.com> Tue, 24 March 2020 17:16 UTC

Return-Path: <ppsenak@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 90D5A3A0D42; Tue, 24 Mar 2020 10:16:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.601
X-Spam-Level:
X-Spam-Status: No, score=-9.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ndygZYDAmSgj; Tue, 24 Mar 2020 10:16:52 -0700 (PDT)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BED243A0D33; Tue, 24 Mar 2020 10:16:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1532; q=dns/txt; s=iport; t=1585070212; x=1586279812; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=eu3ICezXcTRANvcH5942Vn+J9HEAUOzFksne0mpDuBg=; b=b4QacOf3BrlebAsKVJGvUveNpgGRT2/hPDP8stBbJzQfEIJ/mMr82oRP yQu1vDSXQg+TZlZ6nDLL+neJky1wBXpXU7VYPH7srglPHLlpDtev6hPMx OPRiTM2eo29uKGGVriwP65Pab1LrzeZQJywR74U4ifn0tJtWNTuXuZJiZ M=;
X-IronPort-AV: E=Sophos;i="5.72,301,1580774400"; d="scan'208";a="24656115"
Received: from aer-iport-nat.cisco.com (HELO aer-core-1.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 24 Mar 2020 17:16:49 +0000
Received: from [10.60.140.51] (ams-ppsenak-nitro2.cisco.com [10.60.140.51]) by aer-core-1.cisco.com (8.15.2/8.15.2) with ESMTP id 02OHGniI025257; Tue, 24 Mar 2020 17:16:49 GMT
To: Alvaro Retana <aretana.ietf@gmail.com>, "Acee Lindem (acee)" <acee@cisco.com>, "draft-ietf-isis-mpls-elc@ietf.org" <draft-ietf-isis-mpls-elc@ietf.org>
Cc: "lsr@ietf.org" <lsr@ietf.org>, "lsr-chairs@ietf.org" <lsr-chairs@ietf.org>
References: <CAMMESsyMkZgpU69GyL8TpwPS7EoO2rxTHWREOwEz7pNRFtNEJw@mail.gmail.com> <CAMMESsxwbv3aUvg_gR+Ssny=YkW3D2_6tVgDpJx9BGH_Mrdh=A@mail.gmail.com> <0d9b6c73-d309-d2ee-15e0-722df9c32629@cisco.com> <CAMMESsxy7KyCMdAFX2iRHYy78qvQ4eoXLxCRmNj1PGNdOO=QDg@mail.gmail.com> <ff3ae6d5-3bfe-d3c9-ff63-725da0d09e62@cisco.com> <CAMMESszNuZ505G_4o-z-A9ts9SR5tV+9xxDORzUPbSQiPdMcag@mail.gmail.com> <d9972943-7de7-c25d-6e2c-5a4eee77756a@cisco.com> <53F0A553-4075-40A1-A262-47E7EB72E887@cisco.com> <CAMMESswZz7REaNFQhRbPxu8eO89fhM4gD-9B4huHUcByBnQsQA@mail.gmail.com> <7f4535c1-3d1d-4c27-77f2-30150b4e9f42@cisco.com> <CAMMESsw70N1P-Bx_mONMbmgL2JWJhwSzeR8vFYoH+0ebLdD24w@mail.gmail.com> <ee75fb01-ba8a-4fa5-80ba-f6b46e1a5c28@cisco.com> <ACBC767D-39FB-4446-B5A8-7FC7381FE6F5@cisco.com> <CAMMESsxJtp5MVi8rpBsVBRBs=c4TPxvmFtxY35RLUESOwEEnug@mail.gmail.com> <a65f0105-6bf0-5843-041d-c0a0ec8d00af@cisco.com> <CAMMESswfydWJLZLRtBdeFFKj7ZGq7d5upEAPZERUD9TO0o+h2Q@mail.gmail.com>
From: Peter Psenak <ppsenak@cisco.com>
Message-ID: <88410a7c-b1e1-4255-236a-4a9f9b5d0c05@cisco.com>
Date: Tue, 24 Mar 2020 18:16:49 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <CAMMESswfydWJLZLRtBdeFFKj7ZGq7d5upEAPZERUD9TO0o+h2Q@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Outbound-SMTP-Client: 10.60.140.51, ams-ppsenak-nitro2.cisco.com
X-Outbound-Node: aer-core-1.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/DrpjIRS1wZ1lbmx3gHPgEkiGLYw>
Subject: Re: [Lsr] AD Review of draft-ietf-isis-mpls-elc-10
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2020 17:16:54 -0000

Hi Alvaro,

On 24/03/2020 17:00, Alvaro Retana wrote:
> On March 24, 2020 at 6:44:50 AM, Peter Psenak wrote:
> 
> 
>> I posted a new version - draft-ietf-isis-mpls-elc-11. It should have all
>> your inputs incorporated.
>>
>> Please let me know if you are ok with it. Once it's approved from your
>> side, I will update the OSPF draft.
> 
> Yes, it looks good to me.  

thanks for your patience.



> I just have a couple of minor nits (below)
> -- no need to address them right now, you can wait for other Last Call
> comments.
> 
> Thanks!
> 
> Alvaro.
> 
> 
> 
> 
> 86	   Recently, mechanisms have been defined to signal labels via link-
> 87	   state Interior Gateway Protocols (IGP) such as IS-IS [RFC8660].  This
> 
> [minor] Wouldn't a better reference for this be rfc8667?

done.

> 
> 
> 90	   In cases where LSPs are used for whatever reasons (e.g., SR-MPLS
> 
> [nit] s/LSPs are used for whatever reasons/LSPs are used

done

> 
> 
> 149	   assigned by IANA for EARLD-MSD.  MSD-Value field is set to the ERLD
> 
> [nit] s/MSD-Value field/The MSD-Value field

done.

> 
> 
> 199	   considerations as described in [RFC4971], [RFC7752], [RFC7794],
> 200	   [RFC8491], [RFC7752], [RFC8662],
> 
> [nit] rfc7752 is listed twice

done.

> 
> 
> 265	   [RFC4971]  Vasseur, JP., Ed., Shen, N., Ed., and R. Aggarwal, Ed.,
> 
> [minor] Please take this out, and replace the references in the text
> to point to rfc7981.

done.

thanks,
Peter
> 
>

v2.23.0 | Report a Bug | By Email