IETF Logo Mail Archive

Re: [Lsr] AD Review of draft-ietf-isis-mpls-elc-10

Alvaro Retana <aretana.ietf@gmail.com> Tue, 24 March 2020 16:00 UTC

Return-Path: <aretana.ietf@gmail.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 144523A0C92; Tue, 24 Mar 2020 09:00:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wezf1wUUHWY2; Tue, 24 Mar 2020 09:00:24 -0700 (PDT)
Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 593FB3A0CB2; Tue, 24 Mar 2020 09:00:24 -0700 (PDT)
Received: by mail-ed1-x52b.google.com with SMTP id z65so21309781ede.0; Tue, 24 Mar 2020 09:00:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=C2pznmpv5flOEYWkuqXIybRD2/OHfMzfmcH7xT1cw00=; b=LZqm/SDMx625ft8cKnJL+CdlbbYyZRkFJxJuramlzO7rtSzHr1ZoyQaU2HP3V/KbnJ kRb+AdXgjpToPFuV82AlyiNpXiTllaqaSWVKjSxIBnwulLnv5HELvOyl8lWGij8JZOm9 8PZRyHPt+GwbuO24VPwre8nUWoMdMsUBm2okc4ngIw4sNqvbivPig38znp8eyHPbwjAY Mp/6nW/GR6gE953DgnQv/Fka062JfuVSzwNc/ChBM5Wi7+td981rf92Ww1zyq9VszgA5 MRkjNdJkK0+grF/bA/ULp1aogrwEhM4T7oiWecVqfASXcHcg83wbIFa/l5fvfMMl3IF6 FwuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=C2pznmpv5flOEYWkuqXIybRD2/OHfMzfmcH7xT1cw00=; b=r/4vOTzBTwkzdUgNsry0hQyATqy8hp1XYogb/Qy7CH9puwvsOOgIQer082Om98fL9I nB0c5sbQv4T/kHHyQ0Qq7f2vGIlTm2rqkvwi/oZcKzYEyxelrtSVxGcm83EQ7BNWKVMe q/fMvkL4B07FUVt0ezRWfrdNIgKG9mA79FFzIr3fV0DproURyzWqx5i4ZZOcmZGNXJTQ Dh2AkSK3Tq4EQ2M6uw9t9YvyMtlS/keaSMDHBTNUkb32MmTnu0cAteS5A8m/NKMrNFZ4 7BctkQCUPxd/ZBSKUm4pOuHDJDwVoorSStK5EkYioOp+ocVpG8fpMcHuWmIkynyFEfom V3Gw==
X-Gm-Message-State: ANhLgQ1NirakKI5bNt9ITUX4K4s19r6HiqVRnliK39e5TUFnqdx7K3Do yu56ZavQfEDQT9AhLPOjAJXlcskNb2c7qb40wdDUPTbL
X-Google-Smtp-Source: ADFU+vtgUvpLJEe/SMDQYaky5Nl79EyLXCjYjEkxswFL2B67ujMY++7FEtKRRIGjUkc3n9uVG/mjK2DmhOo/6HM8DxE=
X-Received: by 2002:a17:906:7083:: with SMTP id b3mr25344712ejk.238.1585065622660; Tue, 24 Mar 2020 09:00:22 -0700 (PDT)
Received: from 1058052472880 named unknown by gmailapi.google.com with HTTPREST; Tue, 24 Mar 2020 16:00:21 +0000
From: Alvaro Retana <aretana.ietf@gmail.com>
In-Reply-To: <a65f0105-6bf0-5843-041d-c0a0ec8d00af@cisco.com>
References: <CAMMESsyMkZgpU69GyL8TpwPS7EoO2rxTHWREOwEz7pNRFtNEJw@mail.gmail.com> <6bd667d8-6957-894e-f11e-aa727065190c@cisco.com> <CAMMESsxwbv3aUvg_gR+Ssny=YkW3D2_6tVgDpJx9BGH_Mrdh=A@mail.gmail.com> <0d9b6c73-d309-d2ee-15e0-722df9c32629@cisco.com> <CAMMESsxy7KyCMdAFX2iRHYy78qvQ4eoXLxCRmNj1PGNdOO=QDg@mail.gmail.com> <ff3ae6d5-3bfe-d3c9-ff63-725da0d09e62@cisco.com> <CAMMESszNuZ505G_4o-z-A9ts9SR5tV+9xxDORzUPbSQiPdMcag@mail.gmail.com> <d9972943-7de7-c25d-6e2c-5a4eee77756a@cisco.com> <53F0A553-4075-40A1-A262-47E7EB72E887@cisco.com> <CAMMESswZz7REaNFQhRbPxu8eO89fhM4gD-9B4huHUcByBnQsQA@mail.gmail.com> <7f4535c1-3d1d-4c27-77f2-30150b4e9f42@cisco.com> <CAMMESsw70N1P-Bx_mONMbmgL2JWJhwSzeR8vFYoH+0ebLdD24w@mail.gmail.com> <ee75fb01-ba8a-4fa5-80ba-f6b46e1a5c28@cisco.com> <ACBC767D-39FB-4446-B5A8-7FC7381FE6F5@cisco.com> <CAMMESsxJtp5MVi8rpBsVBRBs=c4TPxvmFtxY35RLUESOwEEnug@mail.gmail.com> <a65f0105-6bf0-5843-041d-c0a0ec8d00af@cisco.com>
MIME-Version: 1.0
Date: Tue, 24 Mar 2020 16:00:21 +0000
Message-ID: <CAMMESswfydWJLZLRtBdeFFKj7ZGq7d5upEAPZERUD9TO0o+h2Q@mail.gmail.com>
To: "Acee Lindem (acee)" <acee@cisco.com>, Peter Psenak <ppsenak@cisco.com>, "draft-ietf-isis-mpls-elc@ietf.org" <draft-ietf-isis-mpls-elc@ietf.org>
Cc: "lsr@ietf.org" <lsr@ietf.org>, "lsr-chairs@ietf.org" <lsr-chairs@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/t2QXMNbjSJGoXgKiatVORBEZS-U>
Subject: Re: [Lsr] AD Review of draft-ietf-isis-mpls-elc-10
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2020 16:00:45 -0000

On March 24, 2020 at 6:44:50 AM, Peter Psenak wrote:


> I posted a new version - draft-ietf-isis-mpls-elc-11. It should have all
> your inputs incorporated.
>
> Please let me know if you are ok with it. Once it's approved from your
> side, I will update the OSPF draft.

Yes, it looks good to me.  I just have a couple of minor nits (below)
-- no need to address them right now, you can wait for other Last Call
comments.

Thanks!

Alvaro.




86	   Recently, mechanisms have been defined to signal labels via link-
87	   state Interior Gateway Protocols (IGP) such as IS-IS [RFC8660].  This

[minor] Wouldn't a better reference for this be rfc8667?


90	   In cases where LSPs are used for whatever reasons (e.g., SR-MPLS

[nit] s/LSPs are used for whatever reasons/LSPs are used


149	   assigned by IANA for EARLD-MSD.  MSD-Value field is set to the ERLD

[nit] s/MSD-Value field/The MSD-Value field


199	   considerations as described in [RFC4971], [RFC7752], [RFC7794],
200	   [RFC8491], [RFC7752], [RFC8662],

[nit] rfc7752 is listed twice


265	   [RFC4971]  Vasseur, JP., Ed., Shen, N., Ed., and R. Aggarwal, Ed.,

[minor] Please take this out, and replace the references in the text
to point to rfc7981.

v2.23.0 | Report a Bug | By Email