Re: [Lsr] Lars Eggert's No Objection on draft-ietf-lsr-rfc8920bis-04: (with COMMENT)

Acee Lindem <acee.ietf@gmail.com> Thu, 25 May 2023 14:39 UTC

Return-Path: <acee.ietf@gmail.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3017BC151711; Thu, 25 May 2023 07:39:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.096
X-Spam-Level:
X-Spam-Status: No, score=-2.096 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V6XUl_MzYqG5; Thu, 25 May 2023 07:39:42 -0700 (PDT)
Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7650BC13AE57; Thu, 25 May 2023 07:39:39 -0700 (PDT)
Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-75afa109e60so56208485a.2; Thu, 25 May 2023 07:39:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685025578; x=1687617578; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OqI/OCiOKhO78knUM2CGwLPuxt9hsN+guGResb5gkyI=; b=JvaDGw22X7ywiIjMqYUVfhTdwKhgW21kyag3V+WxDrvZHwnj/MbHdiGgkN1Hvz+Ge4 TSgy6rbZN2bCQTD/rWdPZyka367Hje/QMKhkRRi4gjg4EK82bzHqZJx1YLrWTsLdQxok WHuAk8+gAwuGwpojPBGa8E8BwlSRPzvmYeind4gNbltHlFKQF+tAua09O9/9j1gJJocJ x0jw/jZgulF+rMIWZL9LSCMK+Ax3uQ1wr6g65A0aGdfhGvCkF7TTqdOw9NdRV3DhIS4B /GEXm5t2dYCB9k6zeIat27r5rGIL9ZnWKk3jny+j7YGNJ6NqdZHHOFuiIdot8aBARddF YWAA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685025578; x=1687617578; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OqI/OCiOKhO78knUM2CGwLPuxt9hsN+guGResb5gkyI=; b=DROs1rH6Owd64U8u1AmSkf46f59Xg3ZSM1/sr9GQ5dwHCFzLZl0lRRENeWFDaQve7J Z6btM99kdXG78YVYzfaT0pU8U4BPEUTC9JSE8g8yZBRPxyuY96ZMO6c+PAyLj5Dcwwub uojhFcsqpIIDxF7bt6cTi8+zs9HG0IYj/QN0QNpLNffpcjoX2jsw1xB4+SnrRKKAZPb0 Rh/24u1q9iHMzs15ErYyuEt3rLPU74z9iTSkNGcsmItUvDNSUUEe2nHq7t79KV5omGvS /g0azVaZtm8JHpizCQsXexZiCyB4ihrOn6SxV7yUoq5yXGHSlPnlpYjpVDs4nvY78v+G O2HQ==
X-Gm-Message-State: AC+VfDy+WWiLb9qmOy6rR/kPoXwnz0O8DKLYu2fEhTybhCEgIPV7DoNM rhHpUaQ6Q46GwV5qE0yRinw=
X-Google-Smtp-Source: ACHHUZ5yOiRjMYgZcNm+7Vqfa2QtFNBh6HLX8PueEijDieqvgaGIbB/xJSjfPIGQVAq7kwZWF5PGMw==
X-Received: by 2002:a05:620a:210f:b0:75b:23a1:8e5f with SMTP id l15-20020a05620a210f00b0075b23a18e5fmr9224626qkl.48.1685025578428; Thu, 25 May 2023 07:39:38 -0700 (PDT)
Received: from smtpclient.apple ([136.56.20.4]) by smtp.gmail.com with ESMTPSA id h6-20020a37c446000000b0075b06ea03aasm426838qkm.80.2023.05.25.07.39.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 May 2023 07:39:38 -0700 (PDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\))
From: Acee Lindem <acee.ietf@gmail.com>
In-Reply-To: <BY5PR11MB4337CB4C79FEC164F2B970B0C1469@BY5PR11MB4337.namprd11.prod.outlook.com>
Date: Thu, 25 May 2023 10:39:27 -0400
Cc: Lars Eggert <lars@eggert.org>, The IESG <iesg@ietf.org>, "draft-ietf-lsr-rfc8920bis@ietf.org" <draft-ietf-lsr-rfc8920bis@ietf.org>, "lsr-chairs@ietf.org" <lsr-chairs@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, "chopps@chopps.org" <chopps@chopps.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <32CE05E8-DD13-4D26-BCCA-D50E6F51DFD3@gmail.com>
References: <168499583523.19596.2166685638257782837@ietfa.amsl.com> <BY5PR11MB4337CB4C79FEC164F2B970B0C1469@BY5PR11MB4337.namprd11.prod.outlook.com>
To: Les Ginsberg <ginsberg@cisco.com>
X-Mailer: Apple Mail (2.3731.500.231)
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/P2qcabw5fv44TGupcA84X2STmUQ>
Subject: Re: [Lsr] Lars Eggert's No Objection on draft-ietf-lsr-rfc8920bis-04: (with COMMENT)
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 May 2023 14:39:46 -0000


> On May 25, 2023, at 10:34 AM, Les Ginsberg (ginsberg) <ginsberg@cisco.com> wrote:
> 
> Lars -
> 
> Thanx for the review.
> Responses inline - though I have to say your section references are a "little bit off" - not sure why.
> 
>> -----Original Message-----
>> From: Lars Eggert via Datatracker <noreply@ietf.org>
>> Sent: Wednesday, May 24, 2023 11:24 PM
>> To: The IESG <iesg@ietf.org>
>> Cc: draft-ietf-lsr-rfc8920bis@ietf.org; lsr-chairs@ietf.org; lsr@ietf.org;
>> chopps@chopps.org; chopps@chopps.org
>> Subject: Lars Eggert's No Objection on draft-ietf-lsr-rfc8920bis-04: (with
>> COMMENT)
>> 
>> Lars Eggert has entered the following ballot position for
>> draft-ietf-lsr-rfc8920bis-04: No Objection
>> 
>> When responding, please keep the subject line intact and reply to all
>> email addresses included in the To and CC lines. (Feel free to cut this
>> introductory paragraph, however.)
>> 
>> 
>> Please refer to
>> https://www.ietf.org/about/groups/iesg/statements/handling-ballot-
>> positions/
>> for more information about how to handle DISCUSS and COMMENT positions.
>> 
>> 
>> The document, along with other ballot positions, can be found here:
>> https://datatracker.ietf.org/doc/draft-ietf-lsr-rfc8920bis/
>> 
>> 
>> 
>> ----------------------------------------------------------------------
>> COMMENT:
>> ----------------------------------------------------------------------
>> 
>> # GEN AD review of draft-ietf-lsr-rfc8920bis-03
>> 
>> CC @larseggert
>> 
>> Thanks to Roni Even for the General Area Review Team (Gen-ART) review
>> (https://mailarchive.ietf.org/arch/msg/gen-
>> art/cC3DuuZVG_NAjLDNQMr_P5B14E8).
>> 
>> ## Nits
>> 
>> All comments below are about very minor potential issues that you may
>> choose to
>> address in some way - or ignore - as you see fit. Some were flagged by
>> automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
>> will likely be some false positives. There is no need to let me know what you
>> did with these suggestions.
>> 
>> ### Grammar/style
>> 
>> #### Section 12.3.2, paragraph 1
>> ```
>> ications. It is, however, RECOMMENDED to advertise all link attributes for RS
>>                          ^^^^^^^^^^^^^^^^^^^^^^^^
>> ```
>> The verb "RECOMMENDED" is used with the gerund form.
>> 
> [LES:] I guess you mean Section 12.3.4. But AFAIK "recommended" is an adjective - not a verb.
> In any case I prefer to leave this to the RFC Editor.
> 
>> #### Section 14.1, paragraph 1
>> ```
>> ch they MUST NOT be used. A new sub-section discussing the use of zero-
>> lengt
>>                                ^^^^^^^^^^^
>> ```
>> This word is normally spelled as one.
>> 
> [LES:] I guess you mean Section 15. 
> Noted.
> 
>> #### Section 16.1, paragraph 9
>> ```
>> C 8920 included the following acknowledgements: Thanks to Chris Bowers for
>> h
>>                              ^^^^^^^^^^^^^^^^
>> ```
>> Do not mix variants of the same word ("acknowledgement" and
>> "acknowledgment")
>> within a single text.
>> 
> [LES:] Ack
> 
> I will make the spelling corrections in the next update.

Please note that RFCs should use US English as opposed British English. See section 3.1 of RFC 7322. 

Thanks,
Acee



> 
>    Les
> 
>> ## Notes
>> 
>> This review is in the ["IETF Comments" Markdown format][ICMF], You can use
>> the
>> [`ietf-comments` tool][ICT] to automatically convert this review into
>> individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].
>> 
>> [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
>> [ICT]: https://github.com/mnot/ietf-comments
>> [IRT]: https://github.com/larseggert/ietf-reviewtool
>> 
>> 
>