Re: [MIB-DOCTORS] MPLS-RT review of draft-tiruveedhula-mpls-mldp-mib-04

Kishore Tiruveedhula <kishoret@juniper.net> Thu, 21 May 2015 16:38 UTC

Return-Path: <kishoret@juniper.net>
X-Original-To: mib-doctors@ietfa.amsl.com
Delivered-To: mib-doctors@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B2E931B29FF for <mib-doctors@ietfa.amsl.com>; Thu, 21 May 2015 09:38:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4ukcPbbkQk4W for <mib-doctors@ietfa.amsl.com>; Thu, 21 May 2015 09:38:35 -0700 (PDT)
Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0115.outbound.protection.outlook.com [65.55.169.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 493641ACCF5 for <mib-doctors@ietf.org>; Thu, 21 May 2015 09:38:28 -0700 (PDT)
Received: from DM2PR05MB686.namprd05.prod.outlook.com (10.141.176.147) by DM2PR05MB687.namprd05.prod.outlook.com (10.141.176.151) with Microsoft SMTP Server (TLS) id 15.1.166.22; Thu, 21 May 2015 16:38:25 +0000
Received: from DM2PR05MB686.namprd05.prod.outlook.com ([10.141.176.147]) by DM2PR05MB686.namprd05.prod.outlook.com ([10.141.176.147]) with mapi id 15.01.0166.017; Thu, 21 May 2015 16:38:25 +0000
From: Kishore Tiruveedhula <kishoret@juniper.net>
To: Joan Cucchiara <jcucchiara@mindspring.com>, 'Loa Andersson' <loa@pi.nu>, "aldrin.ietf@gmail.com" <aldrin.ietf@gmail.com>, 'Young Lee' <youngleetx@yahoo.com>
Thread-Topic: MPLS-RT review of draft-tiruveedhula-mpls-mldp-mib-04
Thread-Index: AQHQi/KjXiTl0kx2cESz/95cy9cM452GpGmA///JvQA=
Date: Thu, 21 May 2015 16:38:24 +0000
Message-ID: <D18381E6.2A67A%kishoret@juniper.net>
References: <5550B598.40701@pi.nu> <01d301d093de$28a2b900$79e82b00$@mindspring.com>
In-Reply-To: <01d301d093de$28a2b900$79e82b00$@mindspring.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.4.8.150116
authentication-results: spf=none (sender IP is ) smtp.mailfrom=kishoret@juniper.net;
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [66.129.241.10]
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR05MB687;
x-microsoft-antispam-prvs: <DM2PR05MB6879212A32F0BE765835B94C1C10@DM2PR05MB687.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:;
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:DM2PR05MB687; BCL:0; PCL:0; RULEID:; SRVR:DM2PR05MB687;
x-forefront-prvs: 0583A86C08
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(252514010)(43544003)(164054003)(199003)(13464003)(189002)(24454002)(479174004)(377454003)(51704005)(50986999)(101416001)(105586002)(40100003)(189998001)(77156002)(5001960100002)(106356001)(99286002)(106116001)(97736004)(87936001)(36756003)(2501003)(76176999)(54356999)(2656002)(15974865002)(86362001)(81156007)(62966003)(5001920100001)(66066001)(5001830100001)(102836002)(2900100001)(68736005)(4001350100001)(77096005)(5001770100001)(5001860100001)(64706001)(92566002)(2521001)(230783001)(2950100001)(122556002)(19580395003)(4001540100001)(83506001)(19580405001)(46102003)(7059030); DIR:OUT; SFP:1102; SCL:1; SRVR:DM2PR05MB687; H:DM2PR05MB686.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <01677ABF00B6E24F8D3681D8B9A5C8BD@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2015 16:38:24.9015 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR05MB687
Archived-At: <http://mailarchive.ietf.org/arch/msg/mib-doctors/DefXG_FXJYu3W4med7nggj12jpw>
X-Mailman-Approved-At: Fri, 22 May 2015 02:21:34 -0700
Cc: "draft-tiruveedhula-mpls-mldp-mib@tools.ietf.org" <draft-tiruveedhula-mpls-mldp-mib@tools.ietf.org>, "mib-doctors@ietf.org" <mib-doctors@ietf.org>, "mpls-chairs@tools.ietf.org" <mpls-chairs@tools.ietf.org>, 'Mach Chen' <mach.chen@huawei.com>
Subject: Re: [MIB-DOCTORS] MPLS-RT review of draft-tiruveedhula-mpls-mldp-mib-04
X-BeenThere: mib-doctors@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: MIB Doctors list <mib-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mib-doctors/>
List-Post: <mailto:mib-doctors@ietf.org>
List-Help: <mailto:mib-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 May 2015 16:38:37 -0000

Thanks Joan for reviewing this. I will update the doc for the comments.

Thanks,
Kishore

On 5/21/15, 11:52 AM, "Joan Cucchiara" <jcucchiara@mindspring.com> wrote:

>Hello,  (also cc'ing MIB Doctors)
>
>To the question of is this MIB Module ready for WG adoption,
>unfortunately,  I would say "no" due to some very outdated practices that
>the authors are using which make the MIB Module NOT technically sound.
>The following two issues are very well-documented in the MIB Review
>guidelines (RFC418).   These should be extremely easy fixes, but I would
>implore that the authors  take care NOT to repeat these outdated
>practices in future draft versions.
>
>1) The  sub-id MUST be requested from IANA when the document becomes an
>RFC.  Please do NOT assign a sub-id yourselves.
>Please refer to  RFC4181.
>
>         ::= { mplsStdMIB 99 }
>
>2) LAST-UPDATED and (latest) REVISION clause dates do not agree.   They
>should always agree.  Again, please refer to RFC4181.
>
>Also, since the above needs to be updated, would also ask that the
>authors use the word "Notifications" instead of "Traps" in Section 4.
>and also put the "END" clause on the MIB Module.
>
>General Comments:
>------------------------------
>
>The approach of extending/Augmenting with existing MIB Modules, RFC3815
>and RFC3813 is a good way to  approach this MIB Module in my opinion.
>Also, glad to see that the REFERENCE Clauses are used as this helps out
>tremendously with reviewing and implementing.
>
>Potential Unknown:
>
>Would caution that NOT all of the tables seem to contain valid indices,
>as such, I do not completely understand all of the relationships between
>tables in this MIB and the other MIB Modules.  This may not be an issue
>at all, but just something to be aware of for future MIB reviews.
>Having said that, it does seem that the authors are heading in a good
>direction by making use of existing MIB Modules with extending/augmenting
>tables in this draft.   At this point, I do not have a specific concern
>and think that this will be developed during the WG group process.
>
>Review Considerations for Reviewers, specifically:
>=========================================
>"whether the document is coherent, is it useful
>(ie, is it likely to be actually useful in operational networks), and is
>the
>document technically sound?  We are interested in knowing whether the
>document is ready to be considered for WG adoption (ie, it doesn't have to
>be perfect at this point, but should be a good start)."
>
>Document is coherent in that the objects defined are useful and support
>new features of LDP.  Also, the overall organization seems like a good
>approach.   I think a good deal of thought went into the proposed MIB
>Module with regard to leveraging from existing MIB Modules.
>
>I do think that it would be useful in an operational network as this MIB
>Module extends/augments existing MIB Modules which are widely deployed.
>
>Thanks,
> -Joan
>
>
>> -----Original Message-----
>> From: Loa Andersson [mailto:loa@pi.nu]
>> Sent: Monday, May 11, 2015 9:59 AM
>> To: aldrin.ietf@gmail.com; Young Lee; Joan Cucchiara
>> Cc: mpls-chairs@tools.ietf.org; Mach Chen; draft-tiruveedhula-mpls-mldp-
>> mib@tools.ietf.org
>> Subject: MPLS-RT review of draft-tiruveedhula-mpls-mldp-mib-04
>> 
>> Sam, Young and Joan,
>> 
>> 
>> You have be selected as MPLS-RT reviewers for draft-tiruveedhula- mpls-
>> mldp-mib.
>> 
>> Note to authors: You have been CC'd on this email so that you can know
>>that
>> this review is going on. However, please do not review your own
>>document.
>> 
>> Reviews should comment on whether the document is coherent, is it useful
>> (ie, is it likely to be actually useful in operational networks), and
>>is the
>> document technically sound?  We are interested in knowing whether the
>> document is ready to be considered for WG adoption (ie, it doesn't have
>>to
>> be perfect at this point, but should be a good start).
>> 
>> Reviews should be sent to the document authors, WG co-chairs and WG
>> secretary, and CC'd to the MPLS WG email list. If necessary, comments
>>may
>> be sent privately to only the WG chairs.
>> 
>> Mach Chen is the document shepherd for this draft, the reviews should be
>> sent to him also.
>> 
>> If you have technical comments you should try to be explicit about what
>> *really* need to be resolved before adopting it as a working group
>> document, and what can wait until the document is a working group
>> document and the working group has the revision control.
>> 
>> Are you able to review this draft by May 26, 2015? Please respond in a
>>timely
>> fashion.
>> 
>> 
>> Thanks, Loa
>> (as MPLS WG chair)
>> --
>> 
>> 
>> Loa Andersson                        email: loa@mail01.huawei.com
>> Senior MPLS Expert                          loa@pi.nu
>> Huawei Technologies (consultant)     phone: +46 739 81 21 64
>> 
>> 
>> -----
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 2014.0.4800 / Virus Database: 4311/9748 - Release Date:
>>05/11/15
>