Re: [mpls] Rtgdir last call review of draft-ietf-mpls-p2mp-bfd-06

loa@pi.nu Mon, 26 February 2024 11:54 UTC

Return-Path: <loa@pi.nu>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 689A9C14F6EC; Mon, 26 Feb 2024 03:54:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.906
X-Spam-Level:
X-Spam-Status: No, score=-1.906 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h09T9EtlK8cp; Mon, 26 Feb 2024 03:54:53 -0800 (PST)
Received: from pipi.pi.nu (pipi.pi.nu [83.168.239.141]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4514BC14F6E3; Mon, 26 Feb 2024 03:54:50 -0800 (PST)
Received: from pi.nu (localhost.localdomain [127.0.0.1]) by pipi.pi.nu (Postfix) with ESMTP id 042F43A890C; Mon, 26 Feb 2024 12:54:49 +0100 (CET)
Received: from 124.106.198.177 (SquirrelMail authenticated user loa@pi.nu) by pi.nu with HTTP; Mon, 26 Feb 2024 12:54:49 +0100
Message-ID: <49c3fc046a39a0aadda2309f84c14436.squirrel@pi.nu>
In-Reply-To: <AS2PR02MB8839697CBBD90B7E98B65C38F05A2@AS2PR02MB8839.eurprd02.prod.outlook.com>
References: <170864700898.14065.4946299905740369098@ietfa.amsl.com> <CA+RyBmXitJr-57P3y_=pYEqwoHeMo4HKqPKOud-ZZ2dQQb_gGQ@mail.gmail.com> <176e1397-5b01-487f-8ae0-078bfe2f8ee7@joelhalpern.com> <CA+RyBmUMit0oc1MZTnQ0apTM8Wj_ra7Tna5JCwwMbtbKOfgyCQ@mail.gmail.com> <AS2PR02MB8839697CBBD90B7E98B65C38F05A2@AS2PR02MB8839.eurprd02.prod.outlook.com>
Date: Mon, 26 Feb 2024 12:54:49 +0100
From: loa@pi.nu
To: bruno.decraene@orange.com
Cc: Greg Mirsky <gregimirsky@gmail.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>, "draft-ietf-mpls-p2mp-bfd.all@ietf.org" <draft-ietf-mpls-p2mp-bfd.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
User-Agent: SquirrelMail/1.4.22
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
Importance: Normal
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/3BUDjDfLZhVR7txLMcRSTWyYsow>
Subject: Re: [mpls] Rtgdir last call review of draft-ietf-mpls-p2mp-bfd-06
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Feb 2024 11:54:57 -0000

Bruno,

I'm not responding for Greg, I guess he will respond for himself soon.

What you describe is very attractive and I think it will be implemented.

However, I think that what Greg was looking for was something that
wouldn't need to configured.

/Loa

> Hi Greg,
>
> My 2 cents (not following the draft).
> Another typical option may be to allow the network operator to configure,
> on the egress, an acceptable delay before reporting to the root. The
> egress would then pick a random value in this range. Statically, the more
> egress the more spread the reports to the root, which a priori would be
> good for scaling.
> It would be up to the network operator to configure the right delay
> depending on the number of the leaves and the need for fast reporting (or
> not).
>
> Totally up to you, but that would have my vote as this is a typical issue.
> (granted this is more likely an issue with protocols handling thousands of
> customers, but even for MPLS LSR scaling, RSVP-TE scaling issues are not
> unheard)
>
> Regards,
> --Bruno
>
> From: mpls <mpls-bounces@ietf.org> On Behalf Of Greg Mirsky
> Sent: Sunday, February 25, 2024 12:25 AM
> To: Joel Halpern <jmh@joelhalpern.com>
> Cc: rtg-dir@ietf.org; draft-ietf-mpls-p2mp-bfd.all@ietf.org;
> last-call@ietf.org; mpls@ietf.org
> Subject: Re: [mpls] Rtgdir last call review of
> draft-ietf-mpls-p2mp-bfd-06
>
> Hi Joel,
> thank you for the clarification. My idea is to use a rate limiter at the
> root of the p2mp LSP that may receive notifications from the leaves
> affected by the failure. I imagine that the threshold of the rate limiter
> might be exceeded and the notifications will be discarded. As a result,
> some notifications will be processed by the headend of the p2mp BFD
> session later, as the tails transmit notifications periodically until the
> receive the BFD Control message with the Final flag set.  Thus, we cannot
> avoid the congestion but mitigate the negative effect it might cause by
> extending the convergence. Does that make sense?
>
> Regards,
> Greg
>
> On Sat, Feb 24, 2024 at 2:39 PM Joel Halpern
> <jmh@joelhalpern.com<mailto:jmh@joelhalpern.com>> wrote:
>
> That covers part of my concern.  But....  A failure near the root means
> that a lot of leaves will see failure, and they will all send
> notifications converging on the root.  Those notifications themselves, not
> just the final messages, seem able to cause congestion.  I am not sure
> what can be done about it, but we aren't allowed to ignore it.
>
> Yours,
>
> Joel
> On 2/24/2024 3:34 PM, Greg Mirsky wrote:
> Hi Joel,
> thank you for your support of this work and the suggestion. Would the
> following update of the last paragraph of Section 5 help:
> OLD TEXT:
>    An ingress LSR that has received the BFD Control packet, as described
>    above, sends the unicast IP/UDP encapsulated BFD Control packet with
>    the Final (F) bit set to the egress LSR.
> NEW TEXT:
>    As described above, an ingress LSR that has received the BFD Control
>    packet sends the unicast IP/UDP encapsulated BFD Control packet with
>    the Final (F) bit set to the egress LSR.  In some scenarios, e.g.,
>    when a p2mp LSP is broken close to its root, and the number of egress
>    LSRs is significantly large, the control plane of the ingress LSR
>    might be congested by the BFD Control packets transmitted by egress
>    LSRs and the process of generating unicast BFD Control packets, as
>    noted above.  To mitigate that, a BFD implementation that supports
>    this specification is RECOMMENDED to use a rate limiter of received
>    BFD Control packets passed to processing in the control plane of the
>    ingress LSR.
>
> Regards,
> Greg
>
> On Thu, Feb 22, 2024 at 4:10 PM Joel Halpern via Datatracker
> <noreply@ietf.org<mailto:noreply@ietf.org>> wrote:
> Reviewer: Joel Halpern
> Review result: Ready
>
> Hello,
>
> I have been selected as the Routing Directorate reviewer for this draft.
> The
> Routing Directorate seeks to review all routing or routing-related drafts
> as
> they pass through IETF last call and IESG review, and sometimes on
> special
> request. The purpose of the review is to provide assistance to the Routing
> ADs.
> For more information about the Routing Directorate, please see
> https://wiki.ietf.org/en/group/rtg/RtgDir
>
> Although these comments are primarily for the use of the Routing ADs, it
> would
> be helpful if you could consider them along with any other IETF Last Call
> comments that you receive, and strive to resolve them through discussion
> or by
> updating the draft.
>
> Document: draft-name-version
> Reviewer: your-name
> Review Date: date
> IETF LC End Date: date-if-known
> Intended Status: copy-from-I-D
>
> Summary:  This document is ready for publication as a Proposed Standard.
>     I do have one question that I would appreciate being considered.
>
> Comments:
>     The document is clear and readable, with careful references for those
>     needing additional details.
>
> Major Issues: None
>
> Minor Issues:
>     I note that the security considerations (section 6) does refer to
>     congestion issues caused by excessive transmission of BFD requests.
> I
>     wonder if section 5 ("Operation of Multipoint BFD with Active Tail
> over
>     P2MP MPLS LSP") should include a discussion of the congestion
> implications
>     of multiple tails sending notifications at the rate of 1 per second to
> the
>     head end, particularly if the failure is near the head end.  While I
>     suspect that the 1 / second rate is low enough for this to be safe,
>     discussion in the document would be helpful.
>
> ____________________________________________________________________________________________________________
> Ce message et ses pieces jointes peuvent contenir des informations
> confidentielles ou privilegiees et ne doivent donc
> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez
> recu ce message par erreur, veuillez le signaler
> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages
> electroniques etant susceptibles d'alteration,
> Orange decline toute responsabilite si ce message a ete altere, deforme ou
> falsifie. Merci.
>
> This message and its attachments may contain confidential or privileged
> information that may be protected by law;
> they should not be distributed, used or copied without authorisation.
> If you have received this email in error, please notify the sender and
> delete this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been
> modified, changed or falsified.
> Thank you.
> _______________________________________________
> mpls mailing list
> mpls@ietf.org
> https://www.ietf.org/mailman/listinfo/mpls
>