Re: [mpls] Rtgdir last call review of draft-ietf-mpls-p2mp-bfd-06

Greg Mirsky <gregimirsky@gmail.com> Sat, 24 February 2024 22:30 UTC

Return-Path: <gregimirsky@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 93677C15153F; Sat, 24 Feb 2024 14:30:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vmrQHpfLYloy; Sat, 24 Feb 2024 14:30:30 -0800 (PST)
Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AA2CDC14CF15; Sat, 24 Feb 2024 14:30:30 -0800 (PST)
Received: by mail-yb1-xb2c.google.com with SMTP id 3f1490d57ef6-dcc4de7d901so1371314276.0; Sat, 24 Feb 2024 14:30:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708813829; x=1709418629; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cesxwm398NWZRk6f1RXP1GQi8LrLn/763snbHYsxvV8=; b=d2TiYXb1I5ov3WULy6KBexq/w/6IzXZdoKDaBEhgCh1RoLw4E+q7kEUhoU9yQF6GQd B0UhvPCdO9cSOTEW3aXaTBoW7Jx5ZXWWkRKDRir92d1VCJeqmDl0U8GC3hS4R9U/+pJb zHyLpbQDauuLCzM1/ZPglh3vu/i/5CNjzj7DMpdQPFvK/ct4uMcAT22HD+FIavhZ+WYT /9p76Pa5n6ZM1TY33Wirxn1bTsA0eXfntd6jrPVPqpMEaJx7KKWJBLm8PleJK7//qFPz HSVK5NrRzAUZqfQiAKyb/Hq8eYQ6+1H+dyOWYhGfn9t34beSZ30YSFhuyDrwlmV7qK6A oYrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708813829; x=1709418629; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cesxwm398NWZRk6f1RXP1GQi8LrLn/763snbHYsxvV8=; b=XNOnijc2f0VJdfPmbY7U/adfq/uwsMgBY1jx1yq6p8k7sQUYsKrWU6SUdy9IFeUcxE n0skzYmp4EEhYvTUpOrmWR4LPeAjBhV0Fue2uMVhdCDTEsMSJcPpmBfGp9EzjvCGwVfL LGC41u4qatJCx2NgsLzm/zoL/TBQCkK+eAPXdLLMMLci0TPfpDlCy1X9wRCl1Q002LQB M/v+DGli59zsVhoTc7+4SpHtgoZfI39V2r3GaZnesSEuXpwofxUj5zQUB39ggdLaUZBM YYiC5rpcXyl7A4ZdjFL6z62EOE3DjUE8r/1f3RwnDB8Ppl8ljCYnlJQbXczGNw4cycfg qURA==
X-Forwarded-Encrypted: i=1; AJvYcCVAqH1rZIAyEDTARp9h4K8TWI8ZotczHAE25KJD+ld7hWpFZ6jbCsV8okBnyZqkh00+hFxaQbWSomtXpZAESxIkYOlrxDRsUNSyK0lH9FZ5FgHIVetY2UzWTH4nzCMp2svn9suZH/vfVxIt+fNmiXUYspder2k56/sJrjK14IPVzIyFMHMfAUYalkc=
X-Gm-Message-State: AOJu0Yxosg6IKTAXRaGMdRyN2zrA8JlGxk8arpM/VL9kNDm8K0jC0sKV 9ZRwcaRlvi8O9GC6JjWyPotTHcusB86POSHJVYPox35Yk14SmA8xOQI0pV+VcuyqbX428N9HFfy 1Vkc0DtVX10FrS9UYd2rZN0nIMH8=
X-Google-Smtp-Source: AGHT+IGFEcNPo70a91CQ++FXSP7uIqSZ02eBmfIbTAitEHLfAWyY6OgzN1HojEWnjy1zOg6hpOq2cqmAtb0s2Lzy+yI=
X-Received: by 2002:a05:690c:f88:b0:608:20df:8b15 with SMTP id df8-20020a05690c0f8800b0060820df8b15mr3557235ywb.3.1708813829597; Sat, 24 Feb 2024 14:30:29 -0800 (PST)
MIME-Version: 1.0
References: <170864700898.14065.4946299905740369098@ietfa.amsl.com> <CA+RyBmXitJr-57P3y_=pYEqwoHeMo4HKqPKOud-ZZ2dQQb_gGQ@mail.gmail.com> <312A6132-E3B3-45CB-AAA9-C190C0C1B489@gmail.com>
In-Reply-To: <312A6132-E3B3-45CB-AAA9-C190C0C1B489@gmail.com>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Sat, 24 Feb 2024 14:30:18 -0800
Message-ID: <CA+RyBmV81DuESfJGaB2zve5EQ84SvTySKYtwVfY4FGFEyrm5jg@mail.gmail.com>
To: Acee Lindem <acee.ietf@gmail.com>
Cc: Joel Halpern <jmh@joelhalpern.com>, Routing Directorate <rtg-dir@ietf.org>, draft-ietf-mpls-p2mp-bfd.all@ietf.org, last-call <last-call@ietf.org>, mpls <mpls@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000004cede706122839b9"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/dQr7jK4NNBhOFDOOliP07e2pWX8>
Subject: Re: [mpls] Rtgdir last call review of draft-ietf-mpls-p2mp-bfd-06
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Feb 2024 22:30:31 -0000

Thank you,  Acee. Accepted.

Regards,
Greg

On Sat, Feb 24, 2024, 14:21 Acee Lindem <acee.ietf@gmail.com> wrote:

>
>
> On Feb 24, 2024, at 15:34, Greg Mirsky <gregimirsky@gmail.com> wrote:
>
> Hi Joel,
> thank you for your support of this work and the suggestion. Would the
> following update of the last paragraph of Section 5 help:
> OLD TEXT:
>    An ingress LSR that has received the BFD Control packet, as described
>    above, sends the unicast IP/UDP encapsulated BFD Control packet with
>    the Final (F) bit set to the egress LSR.
> NEW TEXT:
>    As described above, an ingress LSR that has received the BFD Control
>    packet sends the unicast IP/UDP encapsulated BFD Control packet with
>    the Final (F) bit set to the egress LSR.  In some scenarios, e.g.,
>    when a p2mp LSP is broken close to its root, and the number of egress
>    LSRs is significantly large, the control plane of the ingress LSR
>    might be congested by the BFD Control packets transmitted by egress
>    LSRs and the process of generating unicast BFD Control packets, as
>    noted above.  To mitigate that, a BFD implementation that supports
>    this specification is RECOMMENDED to use a rate limiter of received
>    BFD Control packets passed to processing in the control plane of the
>    ingress LSR.
>
>
>
> S/passed to processing in the control place of the ingress LSR./passed to
> the ingress LSR’s control plane for processing./
>
> Acee
>
>
> Regards,
> Greg
>
> On Thu, Feb 22, 2024 at 4:10 PM Joel Halpern via Datatracker <
> noreply@ietf.org> wrote:
>
>> Reviewer: Joel Halpern
>> Review result: Ready
>>
>> Hello,
>>
>> I have been selected as the Routing Directorate reviewer for this draft.
>> The
>> Routing Directorate seeks to review all routing or routing-related drafts
>> as
>> they pass through IETF last call and IESG review, and sometimes on special
>> request. The purpose of the review is to provide assistance to the
>> Routing ADs.
>> For more information about the Routing Directorate, please see
>> https://wiki.ietf.org/en/group/rtg/RtgDir
>>
>> Although these comments are primarily for the use of the Routing ADs, it
>> would
>> be helpful if you could consider them along with any other IETF Last Call
>> comments that you receive, and strive to resolve them through discussion
>> or by
>> updating the draft.
>>
>> Document: draft-name-version
>> Reviewer: your-name
>> Review Date: date
>> IETF LC End Date: date-if-known
>> Intended Status: copy-from-I-D
>>
>> Summary:  This document is ready for publication as a Proposed Standard.
>>     I do have one question that I would appreciate being considered.
>>
>> Comments:
>>     The document is clear and readable, with careful references for those
>>     needing additional details.
>>
>> Major Issues: None
>>
>> Minor Issues:
>>     I note that the security considerations (section 6) does refer to
>>     congestion issues caused by excessive transmission of BFD requests.
>>  I
>>     wonder if section 5 ("Operation of Multipoint BFD with Active Tail
>> over
>>     P2MP MPLS LSP") should include a discussion of the congestion
>> implications
>>     of multiple tails sending notifications at the rate of 1 per second
>> to the
>>     head end, particularly if the failure is near the head end.  While I
>>     suspect that the 1 / second rate is low enough for this to be safe,
>>     discussion in the document would be helpful.
>>
>>
>> _______________________________________________
> mpls mailing list
> mpls@ietf.org
> https://www.ietf.org/mailman/listinfo/mpls
>
>
>