Re: [mpls] Benjamin Kaduk's Discuss on draft-ietf-mpls-lsp-ping-registries-update-08: (with DISCUSS and COMMENT)
Benjamin Kaduk <kaduk@mit.edu> Wed, 17 February 2021 17:06 UTC
Return-Path: <kaduk@mit.edu>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6140B3A1B98; Wed, 17 Feb 2021 09:06:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 570gFUEvlVqH; Wed, 17 Feb 2021 09:06:48 -0800 (PST)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6955A3A1B88; Wed, 17 Feb 2021 09:06:47 -0800 (PST)
Received: from kduck.mit.edu ([24.16.140.251]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 11HH6dvN017158 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Feb 2021 12:06:44 -0500
Date: Wed, 17 Feb 2021 09:06:38 -0800
From: Benjamin Kaduk <kaduk@mit.edu>
To: Loa Andersson <loa@pi.nu>
Cc: The IESG <iesg@ietf.org>, mpls@ietf.org, draft-ietf-mpls-lsp-ping-registries-update@ietf.org, mpls-chairs@ietf.org
Message-ID: <20210217170638.GX21@kduck.mit.edu>
References: <161353683280.26233.12157460034972558131@ietfa.amsl.com> <b081355a-a000-eb44-750e-f740fc6fee6a@pi.nu> <20210217155159.GV21@kduck.mit.edu> <1a599365-563a-cff0-c7bd-03d75fb3363d@pi.nu>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1a599365-563a-cff0-c7bd-03d75fb3363d@pi.nu>
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/6LCLRLNZHd25lc13CJSjuYYYGn4>
Subject: Re: [mpls] Benjamin Kaduk's Discuss on draft-ietf-mpls-lsp-ping-registries-update-08: (with DISCUSS and COMMENT)
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Feb 2021 17:06:50 -0000
On Thu, Feb 18, 2021 at 12:45:44AM +0800, Loa Andersson wrote: > Benjamin, > > There is a little glitch in that RFC 8029 and RFC 8611 are not fully > aligned. > > See inline. > > > > On 17/02/2021 23:51, Benjamin Kaduk wrote: > > Hi Loa, > > > > On Wed, Feb 17, 2021 at 02:53:07PM +0800, Loa Andersson wrote: > >> Benjamin, > >> > >> Tnx for review and suggestions. > >> > >> Response to the Discuss. I'm a bit embarrassed over table 22, I don't > >> what happened. > >> > >> On 17/02/2021 12:40, Benjamin Kaduk via Datatracker wrote: > >>> Benjamin Kaduk has entered the following ballot position for > >>> draft-ietf-mpls-lsp-ping-registries-update-08: Discuss > >>> > >>> When responding, please keep the subject line intact and reply to > >>> all email addresses included in the To and CC lines. (Feel free to > >>> cut this introductory paragraph, however.) > >>> > >>> > >>> Please refer to > >>> https://www.ietf.org/iesg/statement/discuss-criteria.html for more > >>> information about IESG DISCUSS and COMMENT positions. > >>> > >>> > >>> The document, along with other ballot positions, can be found here: > >>> https://datatracker.ietf.org/doc/draft-ietf-mpls-lsp-ping-registries-update/ > >>> > >>> > >>> > >>> > >>> ---------------------------------------------------------------------- > >>> > >>> > >> DISCUSS: > >>> ---------------------------------------------------------------------- > >>> > >>> A few super-boring inconsistencies that make the document unfit to > >>> publish as-is but should be mostly trivial to resolve ((3) and (4) > >>> might be a little tedious but should be mechanical): > >>> > >>> (1) Section 3.3.1 says: > >>> > >>> be silently dropped if not recognized. The code points for > >>> experimental use are taken from the ranges previously called 'Vendor > >>> Private Use', the remainder of which now form part of 'RFC > >>> Required'. > >>> > >>> but I don't think this sentence matches what's proposed in Section 6. > >>> I am seeing the code points for experimental use coming out of the > >>> range that is currently described as "specification required", with > >>> the entirety of the range currently described as "vendor private use" > >>> being converted to FCFS. > >> > >> Yes you are right, this was a late change because taking the > >> "Experimental Use" code point from "RFC Required" made sure that we did > >> not have any collisions with code points in use. > >> > >> Would the following be OK? > >> > >> NEW > >> be silently dropped if not recognized. The code points for > >> experimental use are taken from the ranges previously (RFC > >> 8029) called 'Specification Required' and (RFC 8611) "RFC > >> Required". > > > > I think so, thanks. > > > >>> > >>> (2) Section 4.1 says: > >>> > >>> Mandatory and optional are used to indicate whether a response is > >>> needed if a TLV or sub-TLV is not understood on pages 14 and 15 in > >>> Section 3 of RFC 8029. > >>> > >>> but I think the text being modified is on pages 15 and 16 of RFC > >>> 8029 (the page numbers are in the footer, not the header, of the > >>> plain text output format). > >> > >> My mistake, will change to: > >> > >> NEW: > >> Mandatory and optional are used to indicate whether a response is > >> needed if a TLV or sub-TLV is not understood on pages 15 and 16 in > >> Section 3 of RFC 8029. > > > > +1 > > > >>> > >>> (3) Section 6.2.3 describes changes to the procedures for the > >>> Sub-TLVs for TLV 6 sub-registry, but the changes described assume > >>> that the registration procedures are as described by RFC 8029. > >>> However, the registration procedures have already been changed by RFC > >>> 8611, so the changes described no longer make sense. (E.g., there is > >>> not currently a "specification required" procedure active for any > >>> range of this sub-registry.) We do, however, still need to make some > >>> changes to the registration procedures, specifically to convert the > >>> "Private Use" ranges to FCFS and carve out the "Experimental Use" > >>> blocks. > >> > >> If I read this correctly the one thing we need to do is to remove one > >> bullet: > >> > >> > >> o The "Specification Required" registration procedure has been > >> changed to "RFC Required", the comment "Experimental RFC Required" > >> has been removed. > > > > I don't think that's quite everything; we also want. > > > > OLD: > > o The code points registration procedure "Vendor Private Use" has > > been removed and replaced with "First Come, First Served" code > > points. > > NEW: > > o The code points registration procedure "Private Use" has > > been removed and replaced with "First Come, First Served" code > > points. > > NEW: > o RFC 8029 was published before RFC 8126 and uses the old > terminology for some registration procedures, e.g "Vendor > Private Use". RFC 8611 was published after RFC 8126 and uses > the new terminology, e.g. "Private Use". Both "Vendor Private > Use" and "Private Use has been removed and replaced with "First > Come, First Served" code points. That looks accurate to me, and well phrased. I was not entirely sure whether we need the full complexity of it given that the text in question is in Section 6.2.3 that is scoped to a single sub-registry, and that sub-registry (IIRC) only lists the one RFC (8611) as reference, which hopefully means that it's currently only using a single set of terminology. But to be clear, I am not objecting to your NEW version :) Thanks, Ben
- [mpls] Benjamin Kaduk's Discuss on draft-ietf-mpl… Benjamin Kaduk via Datatracker
- Re: [mpls] Benjamin Kaduk's Discuss on draft-ietf… Loa Andersson
- Re: [mpls] Benjamin Kaduk's Discuss on draft-ietf… Benjamin Kaduk
- Re: [mpls] Benjamin Kaduk's Discuss on draft-ietf… Loa Andersson
- Re: [mpls] Benjamin Kaduk's Discuss on draft-ietf… Benjamin Kaduk
- Re: [mpls] Benjamin Kaduk's Discuss on draft-ietf… Loa Andersson