Re: [mpls] RtgDir review: draft-ietf-mpls-extended-admin-group-06.txt

Eric Osborne <eric@notcom.com> Fri, 02 May 2014 15:32 UTC

Return-Path: <eric@notcom.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D8E1F1A0A0D for <mpls@ietfa.amsl.com>; Fri, 2 May 2014 08:32:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.978
X-Spam-Level:
X-Spam-Status: No, score=-1.978 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FM_FORGED_GMAIL=0.622, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z-DxsYib829u for <mpls@ietfa.amsl.com>; Fri, 2 May 2014 08:32:50 -0700 (PDT)
Received: from mail-yk0-f173.google.com (mail-yk0-f173.google.com [209.85.160.173]) by ietfa.amsl.com (Postfix) with ESMTP id 313871A08F4 for <mpls@ietf.org>; Fri, 2 May 2014 08:32:50 -0700 (PDT)
Received: by mail-yk0-f173.google.com with SMTP id 131so3949170ykp.18 for <mpls@ietf.org>; Fri, 02 May 2014 08:32:47 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=tjEtEW5c6m69TZNpPeo+UA4onBgqpgO6vwwsVgTGAL0=; b=f4iDUY2WSJgaicAQ4N8KZoxC4NozVMNenPkfwmZU3d7Vd+DpiKn8ihoxv852yQLDQI IXduZZRChTdiMJwQUWspCAz6GE+/yXlyljWGSXU4KtzTtt95f7nh/1nwpnU6equQNLzv cyCNMlyY08zv+1p3nZgw8CW8+05O3SMcOUn8Km30EdxCKSa2Q+BObEolB0T2m2opLH3c L5FDsZJlWuEPetRvGWN63j5Es16Cn9i0aPL7ds+io16bCGw1hbvOsId84hJ7a7RWzNRu jOKM0ZJgTDziOng/nmk4+9x4Vocz14hl4oQYzlom6T8NqgkPeQ+HmPMjuKRZBV7C5e/V 1mYA==
X-Gm-Message-State: ALoCoQmF6DyU7EbKli6GfJg7WIJiQp/KHLDWIa6y0EvFfhBXPJy9S2KXlDUGYPcqL5E2cgv9dI/D
MIME-Version: 1.0
X-Received: by 10.236.139.70 with SMTP id b46mr23978829yhj.63.1399044767792; Fri, 02 May 2014 08:32:47 -0700 (PDT)
Received: by 10.170.60.5 with HTTP; Fri, 2 May 2014 08:32:47 -0700 (PDT)
In-Reply-To: <5363A354.8090007@lab.ntt.co.jp>
References: <5363A354.8090007@lab.ntt.co.jp>
Date: Fri, 02 May 2014 11:32:47 -0400
Message-ID: <CA+97oKPYkBmxMAkoqX5GNx2KOAgLmq5yWkec5BEcjj30Te95tA@mail.gmail.com>
From: Eric Osborne <eric@notcom.com>
To: Tomonori Takeda <takeda.tomonori@lab.ntt.co.jp>
Content-Type: text/plain; charset="UTF-8"
Archived-At: http://mailarchive.ietf.org/arch/msg/mpls/9cHEXSGUQIEH7OvwYMGcsS0rDh8
Cc: "mpls@ietf.org" <mpls@ietf.org>, "draft-ietf-mpls-extended-admin-group.all@tools.ietf.org" <draft-ietf-mpls-extended-admin-group.all@tools.ietf.org>, b4a99d417be785e4.invalid@internationalized.invalid, d586783d77c2558c.invalid@internationalized.invalid
Subject: Re: [mpls] RtgDir review: draft-ietf-mpls-extended-admin-group-06.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 02 May 2014 15:32:52 -0000

Thanks!

Do I need to fix these and post a new version, or will the RFC Editor
take care of them?




eric

On Fri, May 2, 2014 at 9:53 AM, Tomonori Takeda
<takeda.tomonori@lab.ntt.co.jp> wrote:
> Hello,
>
> I have been selected as the Routing Directorate reviewer for this draft. The
> Routing Directorate seeks to review all routing or routing-related drafts as
> they pass through IETF last call and IESG review, and sometimes on special
> request. The purpose of the review is to provide assistance to the Routing
> ADs. For more information about the Routing Directorate, please see
> http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
>
> Although these comments are primarily for the use of the Routing ADs, it
> would be helpful if you could consider them along with any other IETF Last
> Call comments that you receive, and strive to resolve them through
> discussion or by updating the draft.
>
> Document: draft-ietf-mpls-extended-admin-group-06.txt
> Reviewer: Tomonori Takeda
> Review Date: 2 May 2014
> IETF LC End Date: 6 May 2014
> Intended Status: Standards Track
>
>
> Summary:
> This document is basically ready for publication, but has nits that should
> be considered prior to publication.
>
> Comments:
> This document is short, clearly written and easy to understand.
> This document writes protocol extensions for OSPF-TE and ISIS-TE, which is
> straight-forward.
>
> Major Issues:
> No major issues found.
>
> Minor Issues:
> No minor issues found.
>
> Nits:
>
> o Abstract
>   It says:
>   "the Administrative Group sub-TLV of the Link TLV"
>   Precisely speaking, I think this should be:
>   "the Administrative Group sub-TLV of the Link TLV for OSPFv2/OSPFv3
>    and of the Extended IS Reachability TLV for ISIS"
>   Or this could simply be:
>   "the Administrative Group sub-TLV"
>
> o Section 1, 3rd paragraph
>   s/vaues/values
>
> o Section 2
>   "This document defines a sub-TLV of the Link TLV for both OSPF
>    [RFC3630] and ISIS [RFC5305] ... "
>    Same as above (comment for Abstract).
>
> o Section 2.2
>   "the existing Administrative Group TLVs" should be:
>   "the existing Administrative Group sub-TLVs".
>
> o Section 2.3.2, 3rd paragraph
>   "as the assumption is than an unadvertised bit is set to 0"
>   I guess "than" should be "that".
>
> Thanks,
> Tomonori Takeda
>
> _______________________________________________
> mpls mailing list
> mpls@ietf.org
> https://www.ietf.org/mailman/listinfo/mpls