Re: [mpls] RtgDir review: draft-ietf-mpls-extended-admin-group-06.txt

Eric Osborne <eric@notcom.com> Wed, 14 May 2014 13:45 UTC

Return-Path: <eric@notcom.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3E01D1A00A7 for <mpls@ietfa.amsl.com>; Wed, 14 May 2014 06:45:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.978
X-Spam-Level:
X-Spam-Status: No, score=-1.978 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FM_FORGED_GMAIL=0.622, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id suDtxtN5xSJ0 for <mpls@ietfa.amsl.com>; Wed, 14 May 2014 06:45:09 -0700 (PDT)
Received: from mail-yk0-f180.google.com (mail-yk0-f180.google.com [209.85.160.180]) by ietfa.amsl.com (Postfix) with ESMTP id 59D0D1A009A for <mpls@ietf.org>; Wed, 14 May 2014 06:45:09 -0700 (PDT)
Received: by mail-yk0-f180.google.com with SMTP id q9so1551831ykb.39 for <mpls@ietf.org>; Wed, 14 May 2014 06:45:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=jHynCqrPwJDVWz3rg3m4Iz7UM4olvoWx6hXtJLFqIbc=; b=RJ/xr2tV4gne9ZSq7URTX1T6JTAC17bgQyJWkgLvsQ++uVmD4E4c8wNxXSC/48SrT1 XZA0/msLR8ZjG1tnU44AoipyCvgkIy+hTlGsNxhlLsHgL28fqq37a8EscerNJXMytMQf HAWARbWsja/MXS5eJ8B87GSvaoOnf4HMpL8yB1RF3sxy9Bjc8JlifuPTssqF9h/x5r65 8Zy9BAJ0EPj9lG9PmThhLxLQlKhnlcV+6gjRCFiba+l1I3RRu5ZvVxgcDgm7kelnveoQ 693PAE6ozNv28kCrDoR+N5n54+X2l827UtjrXix4ynUmrvjDH+hUsGz47VhoStHmUsv9 2fsg==
X-Gm-Message-State: ALoCoQn2CHuOIrcHNOoJEyJ+tfuGUc4lvVFw4iBqsGXOiqJq5WnRWmO5oeQgrNGjBP/ocP+ii/hh
MIME-Version: 1.0
X-Received: by 10.236.126.43 with SMTP id a31mr3446989yhi.154.1400075102543; Wed, 14 May 2014 06:45:02 -0700 (PDT)
Received: by 10.170.60.20 with HTTP; Wed, 14 May 2014 06:45:02 -0700 (PDT)
In-Reply-To: <5363A354.8090007@lab.ntt.co.jp>
References: <5363A354.8090007@lab.ntt.co.jp>
Date: Wed, 14 May 2014 09:45:02 -0400
Message-ID: <CA+97oKPoj==BdrTwAapS_73r-9pcqm3AG6gsW4FLRt7Gkdj3dQ@mail.gmail.com>
From: Eric Osborne <eric@notcom.com>
To: Tomonori Takeda <takeda.tomonori@lab.ntt.co.jp>
Content-Type: text/plain; charset="UTF-8"
Archived-At: http://mailarchive.ietf.org/arch/msg/mpls/OK3J0NL1a9eXXG9z3a-CUyH3zQA
Cc: "mpls@ietf.org" <mpls@ietf.org>, "draft-ietf-mpls-extended-admin-group.all@tools.ietf.org" <draft-ietf-mpls-extended-admin-group.all@tools.ietf.org>, b4a99d417be785e4.invalid@internationalized.invalid, d586783d77c2558c.invalid@internationalized.invalid
Subject: Re: [mpls] RtgDir review: draft-ietf-mpls-extended-admin-group-06.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 14 May 2014 13:45:11 -0000

...

All nits have been addressed.
I went with 'the Administrative Group sub-TLV' in the abstract.  For
section 2, I reworded the first paragraph as:

   This document defines the Extended Administrative Group (EAG) sub-TLV
   for both OSPF [RFC3630] and ISIS [RFC5305].





eric

>
> Nits:
>
> o Abstract
>   It says:
>   "the Administrative Group sub-TLV of the Link TLV"
>   Precisely speaking, I think this should be:
>   "the Administrative Group sub-TLV of the Link TLV for OSPFv2/OSPFv3
>    and of the Extended IS Reachability TLV for ISIS"
>   Or this could simply be:
>   "the Administrative Group sub-TLV"
>
> o Section 1, 3rd paragraph
>   s/vaues/values
>
> o Section 2
>   "This document defines a sub-TLV of the Link TLV for both OSPF
>    [RFC3630] and ISIS [RFC5305] ... "
>    Same as above (comment for Abstract).
>
> o Section 2.2
>   "the existing Administrative Group TLVs" should be:
>   "the existing Administrative Group sub-TLVs".
>
> o Section 2.3.2, 3rd paragraph
>   "as the assumption is than an unadvertised bit is set to 0"
>   I guess "than" should be "that".
>
> Thanks,
> Tomonori Takeda
>
> _______________________________________________
> mpls mailing list
> mpls@ietf.org
> https://www.ietf.org/mailman/listinfo/mpls