[mpls] RtgDir review: draft-ietf-mpls-extended-admin-group-06.txt

Tomonori Takeda <takeda.tomonori@lab.ntt.co.jp> Fri, 02 May 2014 13:52 UTC

Return-Path: <takeda.tomonori@lab.ntt.co.jp>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5B3A41A6F71; Fri, 2 May 2014 06:52:43 -0700 (PDT)
X-Quarantine-ID: <cL17ZLTosZAR>
X-Virus-Scanned: amavisd-new at amsl.com
X-Amavis-Alert: BAD HEADER SECTION, Non-encoded 8-bit data (char E2 hex): To: \342rtg-ads@tools.i[...]
X-Spam-Flag: NO
X-Spam-Score: 0.256
X-Spam-Level:
X-Spam-Status: No, score=0.256 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_EQ_JP=1.244, HOST_EQ_JP=1.265, MIME_8BIT_HEADER=0.3, RCVD_IN_DNSWL_NONE=-0.0001, RP_MATCHES_RCVD=-0.651, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cL17ZLTosZAR; Fri, 2 May 2014 06:52:41 -0700 (PDT)
Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by ietfa.amsl.com (Postfix) with ESMTP id 5974E1A0816; Fri, 2 May 2014 06:52:41 -0700 (PDT)
Received: from mfs6.rdh.ecl.ntt.co.jp (mfs6.rdh.ecl.ntt.co.jp [129.60.39.149]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id s42DqQOD016237; Fri, 2 May 2014 22:52:26 +0900
Received: from mfs6.rdh.ecl.ntt.co.jp (localhost.localdomain [127.0.0.1]) by mfs6.rdh.ecl.ntt.co.jp (Postfix) with ESMTP id B8341E0176; Fri, 2 May 2014 22:52:26 +0900 (JST)
Received: from imail2.m.ecl.ntt.co.jp (imail2.m.ecl.ntt.co.jp [129.60.5.247]) by mfs6.rdh.ecl.ntt.co.jp (Postfix) with ESMTP id AC237E016C; Fri, 2 May 2014 22:52:26 +0900 (JST)
Received: from [IPv6:::1] (panasonic.nslab.ecl.ntt.co.jp [129.60.85.25]) by imail2.m.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id s42DqJqR009999; Fri, 2 May 2014 22:52:26 +0900
Message-ID: <5363A354.8090007@lab.ntt.co.jp>
Date: Fri, 02 May 2014 22:53:24 +0900
From: Tomonori Takeda <takeda.tomonori@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; ja-JP; rv:1.9.2.15) Gecko/20110323 Lanikai/3.1.9
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 8bit
To: �rtg-ads@tools.ietf.org
X-TM-AS-MML: No
Archived-At: http://mailarchive.ietf.org/arch/msg/mpls/vgLFdxpAYugVl7rAxQ8EYOov93U
Cc: mpls@ietf.org, �rtg-dir@ietf.org, draft-ietf-mpls-extended-admin-group.all@tools.ietf.org
Subject: [mpls] RtgDir review: draft-ietf-mpls-extended-admin-group-06.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 02 May 2014 13:52:43 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing 
Directorate seeks to review all routing or routing-related drafts as they pass through 
IETF last call and IESG review, and sometimes on special request. The purpose of the 
review is to provide assistance to the Routing ADs. For more information about the Routing 
Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful 
if you could consider them along with any other IETF Last Call comments that you receive, 
and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-mpls-extended-admin-group-06.txt
Reviewer: Tomonori Takeda
Review Date: 2 May 2014
IETF LC End Date: 6 May 2014
Intended Status: Standards Track


Summary:
This document is basically ready for publication, but has nits that should be considered 
prior to publication.

Comments:
This document is short, clearly written and easy to understand.
This document writes protocol extensions for OSPF-TE and ISIS-TE, which is straight-forward.

Major Issues:
No major issues found.

Minor Issues:
No minor issues found.

Nits:

o Abstract
   It says:
   "the Administrative Group sub-TLV of the Link TLV"
   Precisely speaking, I think this should be:
   "the Administrative Group sub-TLV of the Link TLV for OSPFv2/OSPFv3
    and of the Extended IS Reachability TLV for ISIS"
   Or this could simply be:
   "the Administrative Group sub-TLV"

o Section 1, 3rd paragraph
   s/vaues/values

o Section 2
   "This document defines a sub-TLV of the Link TLV for both OSPF
    [RFC3630] and ISIS [RFC5305] ... "
    Same as above (comment for Abstract).

o Section 2.2
   "the existing Administrative Group TLVs" should be:
   "the existing Administrative Group sub-TLVs".

o Section 2.3.2, 3rd paragraph
   "as the assumption is than an unadvertised bit is set to 0"
   I guess "than" should be "that".

Thanks,
Tomonori Takeda